unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Sree Harsha Totakura <sreeharsha@totakura.in>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add miniupnpc.
Date: Sun, 23 Feb 2014 10:43:24 +0100	[thread overview]
Message-ID: <20140223094324.GA26058@debian> (raw)
In-Reply-To: <1393061825-24964-2-git-send-email-sreeharsha@totakura.in>

Hello,

your message headers contain:
  Content-Type: text/plain; charset=y
so that "git am" complains about
  fatal: cannot convert from y to UTF-8
Or does the list software mess it up?

On Sat, Feb 22, 2014 at 10:37:05AM +0100, Sree Harsha Totakura wrote:
> +       #:phases
> +       (alist-delete 
> +          'configure
> +          %standard-phases)))

There is a tiny problem with indentation here.

> +    (license 
> +     (x11-style
> +      "https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/LICENSE"))))

Can you refer to a file in the tarball and add the obigatory comment?
Something like:
    (license (x11-style "file://doc/README"
                        "See 'doc/README' in the distribution."))))
(copy-pasted from w3m).

Thanks,

Andreas

  reply	other threads:[~2014-02-23  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-22  9:37 [PATCH] Add miniupnpc Sree Harsha Totakura
2014-02-22  9:37 ` [PATCH] gnu: " Sree Harsha Totakura
2014-02-23  9:43   ` Andreas Enge [this message]
2014-02-24 17:49     ` Sree Harsha Totakura
2014-02-24 17:49       ` Sree Harsha Totakura
2014-02-24 21:15       ` Andreas Enge
2014-02-24 21:24         ` Sree Harsha Totakura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140223094324.GA26058@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=sreeharsha@totakura.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).