gnu-build-system should set DESTDIR

gnu-build-system should set DESTDIR

[John Darrington]

Per recent discussions:

I think the make install target in gnu-build-system should set DESTDIR to "/" (or "/.")
Rationale:

Many upstream makefiles (eg: 

https://git.gnome.org/browse/gnome-themes-standard/tree/themes/HighContrast/icons/Makefile.am) 

assume that when DESTDIR is unset (or is "") then the package is being installed in a "live" system:

if test -z "$(DESTDIR)"; then \
		echo "Updating Gtk icon cache."; \
		$(gtk_update_icon_cache); \
else \
		echo "*** Icon cache not updated.  After (un)install, run this:"; \
		echo "***   $(gtk_update_icon_cache)"; \
fi

I have noticed that a number of packages in /nix/store/ have their own version 
of icon-theme.cache leading to warnings when doing guix package --install

So we need to set DESTDIR to *something* and to arrange for some kind of post-install hook to update
the cache.  The same goes for top level info nodes.

J'



-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Re: gnu-build-system should set DESTDIR

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> I think the make install target in gnu-build-system should set DESTDIR to "/" (or "/.")
> Rationale:
>
> Many upstream makefiles (eg: 
>
> https://git.gnome.org/browse/gnome-themes-standard/tree/themes/HighContrast/icons/Makefile.am) 

We’re talking about GNOME makefiles only, I think.  The snippet below is
clearly a hack IMO.

> assume that when DESTDIR is unset (or is "") then the package is being installed in a "live" system:
>
> if test -z "$(DESTDIR)"; then \
> 		echo "Updating Gtk icon cache."; \
> 		$(gtk_update_icon_cache); \
> else \
> 		echo "*** Icon cache not updated.  After (un)install, run this:"; \
> 		echo "***   $(gtk_update_icon_cache)"; \
> fi
>
> I have noticed that a number of packages in /nix/store/ have their own version 
> of icon-theme.cache leading to warnings when doing guix package --install
>
> So we need to set DESTDIR to *something* and to arrange for some kind of post-install hook to update
> the cache.  The same goes for top level info nodes.

What about this: we add a GNOME build system doing a few things, such as
handling schemas [0] and setting DESTDIR if that’s a common idiom.

WDYT?

The post-install hook is definitely on the to-do list, but it needs a
bit of thought.

Thanks,
Ludo’.

[0] http://lists.gnu.org/archive/html/guix-devel/2013-10/msg00171.html

Re: gnu-build-system should set DESTDIR

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

On Mon, Feb 10, 2014 at 01:56:49PM +0100, Ludovic Court??s wrote:
     
     We???re talking about GNOME makefiles only, I think.  The snippet below is
     clearly a hack IMO.

Two non-gnome packages which also do this include gnubik and pspp
     
J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: gnu-build-system should set DESTDIR

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> On Mon, Feb 10, 2014 at 01:56:49PM +0100, Ludovic Court??s wrote:
>      
>      We???re talking about GNOME makefiles only, I think.  The snippet below is
>      clearly a hack IMO.
>
> Two non-gnome packages which also do this include gnubik and pspp

They do what?  Their recipes don’t fiddle with DESTDIR, do they?

Ludo’.

Re: gnu-build-system should set DESTDIR

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Mon, Feb 10, 2014 at 05:09:10PM +0100, Ludovic Court??s wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > On Mon, Feb 10, 2014 at 01:56:49PM +0100, Ludovic Court??s wrote:
     >      
     >      We???re talking about GNOME makefiles only, I think.  The snippet below is
     >      clearly a hack IMO.
     >
     > Two non-gnome packages which also do this include gnubik and pspp
     
     They do what?  Their recipes don???t fiddle with DESTDIR, do they?
     
No.  No package should ever change the value of DESTDIR.

They simply update the icon cache iff $DESTDIR = ""  

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: gnu-build-system should set DESTDIR

[Sree Harsha Totakura]

On 02/10/2014 09:19 AM, John Darrington wrote:
> I think the make install target in gnu-build-system should set DESTDIR to "/" (or "/.")
> Rationale:

Setting DESTDIR will then make the install target to install files in
the chroot dir (most likely to /usr/local/ or the prefix dir inside
chroot) inside the chroot.  But the intention is to install into a
directory given by the --prefix variable to `configure'.

Sree

Re: gnu-build-system should set DESTDIR

[John Darrington]

On Mon, Feb 10, 2014 at 01:58:35PM +0100, Sree Harsha Totakura wrote:
     On 02/10/2014 09:19 AM, John Darrington wrote:
     > I think the make install target in gnu-build-system should set DESTDIR to "/" (or "/.")
     
     Setting DESTDIR will then make the install target to install files in
     the chroot dir (most likely to /usr/local/ or the prefix dir inside
     chroot) inside the chroot.  But the intention is to install into a
     directory given by the --prefix variable to `configure'.
     
     Sree

Files are installed into $DESTDIR$prefix  so setting DESTDIR to / will not break this.

J'



-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.