From: Andreas Enge <andreas@enge.fr>
To: Raimon Grau <raimonster@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: luajit recipe
Date: Wed, 5 Feb 2014 00:27:30 +0100 [thread overview]
Message-ID: <20140204232730.GA6428@debian> (raw)
In-Reply-To: <87iosulff2.fsf@gmail.com>
Hello,
On Tue, Feb 04, 2014 at 10:46:25PM +0100, Raimon Grau wrote:
> Here's the luajit recipe. I'd appreciate any comments you have on that
> (It's my first (hopefully not the last) contribution to this project).
excellent!
Just a few very quick comments:
> (define-module (gnu packages luajit)
If you add a module/file, you also need to "register" it in gnu-system.am.
Here, there is already a module lua in the file lua.scm. It would probably
make sense to add your package there.
> (description
> "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
> programming language. Lua is a powerful, dynamic and light-weight programming
> language. It may be embedded or used as a general-purpose, stand-alone
> language.
>
> LuaJIT is Copyright © 2005-2014 Mike Pall")
You should write two spaces after the "." at the end of a sentence. I would
drop the second paragraph (which is also likely to change with newer
versions).
I did not check anything else. Thanks for contributing!
Andreas
next prev parent reply other threads:[~2014-02-04 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 21:46 luajit recipe Raimon Grau
2014-02-04 23:17 ` Ludovic Courtès
2014-02-04 23:27 ` Andreas Enge [this message]
2014-02-05 1:31 ` Cyril Roelandt
2014-02-05 13:54 ` Ludovic Courtès
2014-02-06 0:11 ` Raimon Grau
2014-02-06 0:37 ` Cyril Roelandt
2014-02-06 0:47 ` Raimon Grau
2014-02-06 1:00 ` Cyril Roelandt
2014-02-06 1:28 ` Raimon Grau
2014-02-06 18:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204232730.GA6428@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=raimonster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).