From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 3/3] gnu: Add octave and dependencies Date: Sun, 26 Jan 2014 08:38:16 +0100 Message-ID: <20140126073815.GA19985@jocasta.intra> References: <1390507648-21659-1-git-send-email-jmd@gnu.org> <1390507648-21659-3-git-send-email-jmd@gnu.org> <8761p8ulih.fsf@gnu.org> <20140125161456.GA31777@jocasta.intra> <20140125164217.GA21259@debian> <20140125170440.GA4883@jocasta.intra> <871tzvu743.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7KIj-0002y0-IH for guix-devel@gnu.org; Sun, 26 Jan 2014 02:38:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7KIf-0002YS-CP for guix-devel@gnu.org; Sun, 26 Jan 2014 02:38:41 -0500 Content-Disposition: inline In-Reply-To: <871tzvu743.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court??s Cc: guix-devel@gnu.org, John Darrington --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2014 at 09:41:32PM +0100, Ludovic Court??s wrote: John Darrington skribis: =20 > On Sat, Jan 25, 2014 at 05:42:17PM +0100, Andreas Enge wrote: > On Sat, Jan 25, 2014 at 05:14:57PM +0100, John Darrington wrote: > > The octave build system is rather naive. These propagated in= puts don't actually > > *need* to be present at configure/build time. But the ./conf= igure (rather stupidly IMO) > > checks for their presence, and turns off the relevant feature= s if they are not found. > > Therefore, one must declare them as native-inputs just to kee= p ./configure happy AND > > as propagated inputs because they are called in a pipe from t= he octave program itself. > =20 > Would it be reasonable to patch the lines in which external pro= grams are > called, replacing the program name by its complete path with a = well-chosen > (substitute*)? > Then one would not need to propagate the inputs. > =20 > I don't think that will work. =20 I think it would. If there???s a line like: =20 execlp ("makeinfo" ...); =20 patching that to, say: =20 execl ("/.../bin/makeinfo" ...); =20 will definitely work. (This is what Octave???s build system should be doing, actually.) =20 WDYT? =20 (As an example, see how mingetty is patched to refer to a specific ???login??? program, in admin.scm.) =20 I think I see where you are coming from. If we did what you suggest, then = we could remove makeinfo et al from propagated-inputs, but we would have to add them to inp= uts (in=20 to native-inputs). So it would not reduce the total number of "inputs". Further, it would mea= n we would have to devise a number of potentially complicated patches, which we would be co= ndemned to maintain. Further, it seems to me, to be a bit deceptive. By removing mak= einfo from propagated-inputs we are pretending that makeinfo does not need to be insta= lled along with octave, whereas in fact, it does (if one wants to read the manual from with= in octave). As I understand it, a propagated input means that X must always be installe= d with Y. What benefit does this proposal bring us? J' --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlLku2cACgkQimdxnC3oJ7NLtQCbBLYwlfWC2xsvaZ1JI6gY2hOO ZfgAniWCBniQun6FIV88mW/E+CmvRVzs =ksns -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--