From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 3/3] gnu: Add octave and dependencies Date: Sat, 25 Jan 2014 18:04:40 +0100 Message-ID: <20140125170440.GA4883@jocasta.intra> References: <1390507648-21659-1-git-send-email-jmd@gnu.org> <1390507648-21659-3-git-send-email-jmd@gnu.org> <8761p8ulih.fsf@gnu.org> <20140125161456.GA31777@jocasta.intra> <20140125164217.GA21259@debian> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W76fC-0006fp-05 for guix-devel@gnu.org; Sat, 25 Jan 2014 12:05:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W76f7-00005n-Ij for guix-devel@gnu.org; Sat, 25 Jan 2014 12:04:57 -0500 Content-Disposition: inline In-Reply-To: <20140125164217.GA21259@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org, John Darrington --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2014 at 05:42:17PM +0100, Andreas Enge wrote: On Sat, Jan 25, 2014 at 05:14:57PM +0100, John Darrington wrote: > The octave build system is rather naive. These propagated inputs do= n't actually > *need* to be present at configure/build time. But the ./configure (= rather stupidly IMO) > checks for their presence, and turns off the relevant features if th= ey are not found. > Therefore, one must declare them as native-inputs just to keep ./con= figure happy AND > as propagated inputs because they are called in a pipe from the octa= ve program itself. =20 Would it be reasonable to patch the lines in which external programs a= re called, replacing the program name by its complete path with a well-ch= osen (substitute*)? Then one would not need to propagate the inputs. =20 I don't think that will work. One needs to propagate the inputs. Otherwis= e octave won't work (properly). For example, one needs to ensure that when octave is inst= alled, less is also installed. Otherwise it wont have a pager. Similarly for texinfo - i= f makeinfo does not get installed along with octave, then the integrated documentation won'= t be available. A better approach would be to patch the configure so that it does not bothe= r to check for these programs AND then to patch the install phase to check for them. But = I don't fancy doing that. J' --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlLj7qgACgkQimdxnC3oJ7MpRgCeP3dTruU+YX/0aGHZnDzwDZmi U1IAnRuLSAvJt5iLKZeecg/tkwm4JT1w =2OmK -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--