From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues. Date: Tue, 7 Jan 2014 11:32:11 +0100 Message-ID: <20140107103211.GB11414@jocasta.intra> References: <1387043002-6138-1-git-send-email-john@darrington.wattle.id.au> <1387043002-6138-2-git-send-email-john@darrington.wattle.id.au> <87y53nthwo.fsf@gnu.org> <20131214190218.GA8061@intra> <8761qrta62.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0TxQ-0006jZ-El for guix-devel@gnu.org; Tue, 07 Jan 2014 05:32:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0TxM-000065-6y for guix-devel@gnu.org; Tue, 07 Jan 2014 05:32:24 -0500 Content-Disposition: inline In-Reply-To: <8761qrta62.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court?s Cc: guix-devel@gnu.org --tjCHc7DPkfUGtrlw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 14, 2013 at 10:06:13PM +0100, Ludovic Court??s wrote: John Darrington skribis: =20 > On Sat, Dec 14, 2013 at 07:19:03PM +0100, Ludovic Court??s wrote: > John Darrington skribis: > =20 > > *gnu/packages/gnupg.scm (libgpg-error): Added gcc as a native= input, > > and set the CC_FOR_BUILD variable. > =20 > The implicit inputs when cross-compiling include both the cross= -gcc and > the native gcc (see build-system/gnu.scm.) > =20 > AFAICS setting CC_FOR_BUILD=3Dgcc should be enough (it uses ???= cc??? by > default.) Can you confirm. > > You are right. setting gcc as a native input seems to be unnecessar= y. Somewhat on > a tangent: > Would it not be a good idea to have CC_FOR_BUILD=3Dgcc the default= setting at least > fot the gnu build-system. =20 Yeah, perhaps we could add that when cross building (we have only two occurrences currently, but it may be needed quite often.) Right. PSPP should have it, but does not currently. =20 > > *gnu/packages/gnupg.scm (libgcrypt): Added libgpg-error as a = native input and > > set the --with-gpg-error-prefix configure option. > =20 > This is wrong: libgcrypt would end up linking against the nativ= e libgpg-error. > > I think you are mistaken. The purpose of --with-gpg-error-prefix=3D= is to set the path > of the library which it should be linked against. The issue is, tha= t libgpg-error provides > both a binary (which must be run at configure time) AND a library wh= ich has to be linked. =20 Oh indeed, I was unaware of that. So that explains why libgpg-error must be passed both as a native and target input. =20 However, is --with-gpg-error-prefix really needed? By default the cro= ss gcc will find the target libgpg-error in its search path, and not the native one, so I would guess this is OK. That was not my experience. I will try it again, in case I missed somethin= g. =20 J' --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --tjCHc7DPkfUGtrlw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlLL16sACgkQimdxnC3oJ7NcogCeMBnENPH4YL+SPz3d5rHTueC5 jlYAniQg+f32Mr8/3avJpVETWGwxg+SD =eXds -----END PGP SIGNATURE----- --tjCHc7DPkfUGtrlw--