From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] file depends upon itself! Date: Fri, 13 Dec 2013 16:11:54 +0100 Message-ID: <20131213151154.GA6852@jocasta.intra> References: <20131213100117.GA31522@jocasta.intra> <87eh5gj45k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="6c2NcOVqGQ03X4Wi" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrUPR-0001K3-UV for guix-devel@gnu.org; Fri, 13 Dec 2013 10:12:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrUPN-00034W-6r for guix-devel@gnu.org; Fri, 13 Dec 2013 10:12:09 -0500 Content-Disposition: inline In-Reply-To: <87eh5gj45k.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court??s Cc: guix-devel@gnu.org --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Try this one. J' On Fri, Dec 13, 2013 at 02:01:43PM +0100, Ludovic Court??s wrote: John Darrington skribis: > The file command is somewhat unusual in that it depends upon a natively compiled > version of itself. Like Guile. Initially I added this field for this purpose: (self-native-input? #t) But what you did is better, and is enough to get rid of ???self-native-input????. However, the patch doesn???t apply on ???master???. Could you check what???s going on? Also, make sure the commit log specifies the changes (like ???Add ???native-inputs??? field???) rather than the rationale (info "(standards) Change Log Concepts"). Thanks, Ludo???. -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --6c2NcOVqGQ03X4Wi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-file-Fixed-cross-compilation.patch" >From 5127a509f71d7308ce622d30c6f0dd55845d9890 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Fri, 13 Dec 2013 10:52:12 +0100 Subject: [PATCH] gnu: file: Fixed cross-compilation. * gnu/packages/file.scm (file): [(eq? (%current-target-system) #f)] Add native-inputs. --- gnu/packages/file.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/file.scm b/gnu/packages/file.scm index 1e09fb7..63a9df4 100644 --- a/gnu/packages/file.scm +++ b/gnu/packages/file.scm @@ -34,6 +34,9 @@ (sha256 (base32 "08ix4xrvan0k80n0l5lqfmc4azjv5lyhvhwdxny4r09j5smhv78r")))) (build-system gnu-build-system) + (native-inputs + ;; This package depends upon a native install of itself. + (if (%current-target-system) `(("file" ,file)) '() )) (synopsis "file, a file type guesser") (description "The file command is a file type guesser, a command-line tool that tells -- 1.7.10.4 --6c2NcOVqGQ03X4Wi--