unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Darrington <john@darrington.wattle.id.au>
To: Ludovic Court??s <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] file depends upon itself!
Date: Fri, 13 Dec 2013 16:11:54 +0100	[thread overview]
Message-ID: <20131213151154.GA6852@jocasta.intra> (raw)
In-Reply-To: <87eh5gj45k.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

Try this one.

J'

On Fri, Dec 13, 2013 at 02:01:43PM +0100, Ludovic Court??s wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > The file command is somewhat unusual in that it depends upon a natively compiled
     > version of itself.
     
     Like Guile.  Initially I added this field for this purpose:
     
       (self-native-input? #t)
     
     But what you did is better, and is enough to get rid of
     ???self-native-input????.
     
     However, the patch doesn???t apply on ???master???.  Could you check
     what???s going on?
     
     Also, make sure the commit log specifies the changes (like ???Add
     ???native-inputs??? field???) rather than the rationale (info "(standards)
     Change Log Concepts").
     
     Thanks,
     Ludo???.

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: 0001-gnu-file-Fixed-cross-compilation.patch --]
[-- Type: text/x-diff, Size: 960 bytes --]

From 5127a509f71d7308ce622d30c6f0dd55845d9890 Mon Sep 17 00:00:00 2001
From: John Darrington <jmd@gnu.org>
Date: Fri, 13 Dec 2013 10:52:12 +0100
Subject: [PATCH] gnu: file: Fixed cross-compilation.

* gnu/packages/file.scm (file): [(eq? (%current-target-system) #f)] Add native-inputs.
---
 gnu/packages/file.scm |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/file.scm b/gnu/packages/file.scm
index 1e09fb7..63a9df4 100644
--- a/gnu/packages/file.scm
+++ b/gnu/packages/file.scm
@@ -34,6 +34,9 @@
             (sha256 (base32
                      "08ix4xrvan0k80n0l5lqfmc4azjv5lyhvhwdxny4r09j5smhv78r"))))
    (build-system gnu-build-system)
+   (native-inputs
+    ;; This package depends upon a native install of itself.
+     (if (%current-target-system) `(("file" ,file)) '() ))
    (synopsis "file, a file type guesser")
    (description
     "The file command is a file type guesser, a command-line tool that tells
-- 
1.7.10.4


  reply	other threads:[~2013-12-13 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 10:01 [PATCH] file depends upon itself! John Darrington
2013-12-13 13:01 ` Ludovic Courtès
2013-12-13 15:11   ` John Darrington [this message]
2013-12-13 22:38     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213151154.GA6852@jocasta.intra \
    --to=john@darrington.wattle.id.au \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).