From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add IceCat. Date: Tue, 12 Nov 2013 22:06:28 +0100 Message-ID: <20131112210628.GA24048@debian> References: <20131111194739.GA27236@debian> <87fvr2hbbn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLAX-0006yb-Gw for guix-devel@gnu.org; Tue, 12 Nov 2013 16:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgLAP-000199-O7 for guix-devel@gnu.org; Tue, 12 Nov 2013 16:06:41 -0500 Content-Disposition: inline In-Reply-To: <87fvr2hbbn.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-15?Q?Court=E8s?= Cc: guix-devel@gnu.org On Mon, Nov 11, 2013 at 10:34:36PM +0100, Ludovic Courtès wrote: > Perhaps ‘substring’ instead of ‘string-copy’ (does pretty much the same > thing, but the meaning is clearer IMO.) Okay. I have no preference. > (lambda _ ...) is enough (where ‘_’ is a convention to suggest that we > don’t care about the arguments.) Thanks, that is interesting to know! > > + ;; delete dangling symlinks > Do they cause problem with one of the patch-everything passes? Yes. > Other than that, it looks good to me. Okay, I will push in a moment without trying to compile again, and let hydra pick up any error. Andreas