From: Andreas Enge <andreas@enge.fr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add IceCat.
Date: Tue, 12 Nov 2013 22:06:28 +0100 [thread overview]
Message-ID: <20131112210628.GA24048@debian> (raw)
In-Reply-To: <87fvr2hbbn.fsf@gnu.org>
On Mon, Nov 11, 2013 at 10:34:36PM +0100, Ludovic Courtès wrote:
> Perhaps ‘substring’ instead of ‘string-copy’ (does pretty much the same
> thing, but the meaning is clearer IMO.)
Okay. I have no preference.
> (lambda _ ...) is enough (where ‘_’ is a convention to suggest that we
> don’t care about the arguments.)
Thanks, that is interesting to know!
> > + ;; delete dangling symlinks
> Do they cause problem with one of the patch-everything passes?
Yes.
> Other than that, it looks good to me.
Okay, I will push in a moment without trying to compile again, and let hydra
pick up any error.
Andreas
next prev parent reply other threads:[~2013-11-12 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 19:47 [PATCH] gnu: Add IceCat Andreas Enge
2013-11-11 20:33 ` Cyril Roelandt
2013-11-12 21:13 ` Andreas Enge
2013-11-11 21:34 ` Ludovic Courtès
2013-11-12 21:06 ` Andreas Enge [this message]
2013-11-13 12:54 ` Ludovic Courtès
2013-11-13 19:42 ` Jason Self
2013-11-13 21:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112210628.GA24048@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).