From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] Add libtheora package Date: Mon, 14 Oct 2013 11:23:32 +0200 Message-ID: <20131014092332.GA11904@debian.eduroam.u-bordeaux.fr> References: <525B2ADB.1000501@worcester.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVeNT-0001kD-7s for guix-devel@gnu.org; Mon, 14 Oct 2013 05:23:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVeNL-000161-U3 for guix-devel@gnu.org; Mon, 14 Oct 2013 05:23:51 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:59462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVeNL-00015x-Km for guix-devel@gnu.org; Mon, 14 Oct 2013 05:23:43 -0400 Content-Disposition: inline In-Reply-To: <525B2ADB.1000501@worcester.edu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote: > How does it look? It compiles well and looks good, congratulations! One point, though: If you do cd /nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/ grep Requires *.pc you only see ogg, not vorbis. So I think you can move libvorbis from propagated-inputs into regular inputs. At a later point, you might wish to add libsdl as an input (I think you were working on it already.) Andreas