From: Andreas Enge <andreas@enge.fr>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add libtheora package
Date: Mon, 14 Oct 2013 11:23:32 +0200 [thread overview]
Message-ID: <20131014092332.GA11904@debian.eduroam.u-bordeaux.fr> (raw)
In-Reply-To: <525B2ADB.1000501@worcester.edu>
On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote:
> How does it look?
It compiles well and looks good, congratulations! One point, though:
If you do
cd /nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/
grep Requires *.pc
you only see ogg, not vorbis.
So I think you can move libvorbis from propagated-inputs into regular inputs.
At a later point, you might wish to add libsdl as an input (I think you were
working on it already.)
Andreas
next prev parent reply other threads:[~2013-10-14 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 23:20 [PATCH] Add libtheora package David Thompson
2013-10-14 9:23 ` Andreas Enge [this message]
2013-10-14 18:37 ` David Thompson
2013-10-14 20:43 ` David Thompson
2013-10-14 21:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014092332.GA11904@debian.eduroam.u-bordeaux.fr \
--to=andreas@enge.fr \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).