unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Python 3 native-search-paths
@ 2013-08-31 15:40 Andreas Enge
  2013-08-31 16:07 ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2013-08-31 15:40 UTC (permalink / raw)
  To: guix-devel

I just noticed that there is a variable native-search-paths in python-2,
which looks like it should be updated for python 3. However, when I modify
the package accordingly, it is not recompiled. How come? Is this variable
really needed?

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-08-31 15:40 Python 3 native-search-paths Andreas Enge
@ 2013-08-31 16:07 ` Ludovic Courtès
  2013-08-31 16:43   ` Andreas Enge
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2013-08-31 16:07 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Andreas Enge <andreas@enge.fr> skribis:

> I just noticed that there is a variable native-search-paths in python-2,
> which looks like it should be updated for python 3. However, when I modify
> the package accordingly, it is not recompiled. How come? Is this variable
> really needed?

Yes it is [0].  :-)

Changing it triggers a recompilation of anything that depends on Python,
but not of Python itself.

Ludo’.

[0] http://lists.gnu.org/archive/html/bug-guix/2013-03/msg00158.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-08-31 16:07 ` Ludovic Courtès
@ 2013-08-31 16:43   ` Andreas Enge
  2013-08-31 18:06     ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2013-08-31 16:43 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Sat, Aug 31, 2013 at 06:07:35PM +0200, Ludovic Courtès wrote:
> Andreas Enge <andreas@enge.fr> skribis:
> > I just noticed that there is a variable native-search-paths in python-2,
> > which looks like it should be updated for python 3. However, when I modify
> > the package accordingly, it is not recompiled. How come? Is this variable
> > really needed?
> 
> Yes it is [0].  :-)
> Changing it triggers a recompilation of anything that depends on Python,
> but not of Python itself.

How can it trigger anything if the output path is identical
(here: /nix/store/0hf9lvd48q1l98k5jf98z17zq29955c4-python-3.3.2)?

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-08-31 16:43   ` Andreas Enge
@ 2013-08-31 18:06     ` Ludovic Courtès
  2013-09-01  7:11       ` Andreas Enge
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2013-08-31 18:06 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, Aug 31, 2013 at 06:07:35PM +0200, Ludovic Courtès wrote:
>> Andreas Enge <andreas@enge.fr> skribis:
>> > I just noticed that there is a variable native-search-paths in python-2,
>> > which looks like it should be updated for python 3. However, when I modify
>> > the package accordingly, it is not recompiled. How come? Is this variable
>> > really needed?
>> 
>> Yes it is [0].  :-)
>> Changing it triggers a recompilation of anything that depends on Python,
>> but not of Python itself.
>
> How can it trigger anything if the output path is identical
> (here: /nix/store/0hf9lvd48q1l98k5jf98z17zq29955c4-python-3.3.2)?

It has no effect in the build of Python itself; its effect is only when
building Python code that uses Python and one or more Python libs.

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-08-31 18:06     ` Ludovic Courtès
@ 2013-09-01  7:11       ` Andreas Enge
  2013-09-01 13:31         ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2013-09-01  7:11 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Sat, Aug 31, 2013 at 08:06:34PM +0200, Ludovic Courtès wrote:
> It has no effect in the build of Python itself; its effect is only when
> building Python code that uses Python and one or more Python libs.

I still think something is wrong here and that this variable should be
included into the computation of the hash. When I now recompile a
package depending on python, it gets the same hash, but it is different.

Or more easily: The python package with the new native-search-paths behaves
differently from the previous one, so it should have a different hash.

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-09-01  7:11       ` Andreas Enge
@ 2013-09-01 13:31         ` Ludovic Courtès
  2013-09-01 13:41           ` Andreas Enge
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2013-09-01 13:31 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, Aug 31, 2013 at 08:06:34PM +0200, Ludovic Courtès wrote:
>> It has no effect in the build of Python itself; its effect is only when
>> building Python code that uses Python and one or more Python libs.
>
> I still think something is wrong here and that this variable should be
> included into the computation of the hash. When I now recompile a
> package depending on python, it gets the same hash, but it is different.
>
> Or more easily: The python package with the new native-search-paths behaves
> differently from the previous one, so it should have a different hash.

The hash is the hash of all the inputs to the build process,
recursively.  If a single bit changes somewhere, the hash changes.

But here, search path specifications do not affect the build process of
packages that carry them in any way (an improvement over Nix where
everything is an environment variable, and thus an input to the hash,
even if it is not meant to influence the build process.)

When ‘native-search-paths’ changes in python3, it’s not python3 that
behaves differently: it’s the build process of packages using it that
does.

Hope this clarify things.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Python 3 native-search-paths
  2013-09-01 13:31         ` Ludovic Courtès
@ 2013-09-01 13:41           ` Andreas Enge
  0 siblings, 0 replies; 7+ messages in thread
From: Andreas Enge @ 2013-09-01 13:41 UTC (permalink / raw)
  To: Ludovic Courtès

On Sun, Sep 01, 2013 at 03:31:45PM +0200, Ludovic Courtès wrote:
> When ‘native-search-paths’ changes in python3, it’s not python3 that
> behaves differently: it’s the build process of packages using it that
> does.

Not really. Then the output of, say, pytz, will change when the
native-search-paths of python changes, no? So we would obtain a pytz package
which is binary different, but has the same hash?

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-09-01 13:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-31 15:40 Python 3 native-search-paths Andreas Enge
2013-08-31 16:07 ` Ludovic Courtès
2013-08-31 16:43   ` Andreas Enge
2013-08-31 18:06     ` Ludovic Courtès
2013-09-01  7:11       ` Andreas Enge
2013-09-01 13:31         ` Ludovic Courtès
2013-09-01 13:41           ` Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).