unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Python 3 binaries
Date: Sun, 1 Sep 2013 11:28:17 +0200	[thread overview]
Message-ID: <20130901092817.GA19604@debian> (raw)
In-Reply-To: <5222282D.7000801@gmail.com>

Very well. If we do not wish to make the symlink python->python3,
then we will need special code in patch-shebangs, so that things like
"#!/usr/bin/python" may get rewritten to
"#!/nix/store/...python-3.3.2/bin/python3" if no binary named "python"
is found.

I think the following patch does this:

--- a/guix/build/utils.scm
+++ b/guix/build/utils.scm
@@ -516,7 +516,10 @@ FILE are kept unchanged."
                                  (rest (match:substring m 3))
                                  (has-env (string-suffix? "/env" interp))
                                  (cmd (if has-env arg1 (basename interp)))
-                                 (bin (search-path path cmd)))
+                                 (bin (or (search-path path cmd)
+                                          (if (string=? cmd "python")
+                                              (search-path path "python3")
+                                              #f))))
                             (if bin
                                 (if (string=? bin interp)
                                     #f            ; nothing to do

But it triggers a full rebuild, so it will take me a while to test it.

If you agree to this patch, we would need to revive core-updates, and should
revert to python 2 in master. Could we then build core-updates also on
hydra.gnu.org? This would make it easier to add python modules for the two
different versions.

Andreas

  parent reply	other threads:[~2013-09-01  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 15:30 Python 3 binaries Andreas Enge
2013-08-31 17:30 ` Cyril Roelandt
2013-08-31 18:20   ` Ludovic Courtès
2013-09-01  9:28   ` Andreas Enge [this message]
2013-09-01 10:03     ` Andreas Enge
2013-09-01 14:03     ` Ludovic Courtès
2013-09-01 14:39       ` Andreas Enge
2013-09-01 17:34         ` Ludovic Courtès
2013-09-01 17:40           ` Cyril Roelandt
2013-09-01 18:21             ` Andreas Enge
2013-09-01 17:50           ` Andreas Enge
2013-09-02  6:24           ` Brandon Invergo
2013-09-08 18:35             ` Andreas Enge
  -- strict thread matches above, loose matches on Subject: below --
2013-09-01  8:20 Brandon Invergo
2013-09-01 13:49 ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130901092817.GA19604@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).