From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] gnu: ruby-net-http-digest-auth: Add new package Date: Thu, 17 Nov 2016 20:56:02 +1000 Message-ID: <1d9d1ec0-e95f-26c9-dcd7-fe01bd913cab@uq.edu.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7KMf-0005aD-Ob for guix-devel@gnu.org; Thu, 17 Nov 2016 05:56:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7KMb-000596-Mh for guix-devel@gnu.org; Thu, 17 Nov 2016 05:56:21 -0500 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:57589 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7KMb-00054e-3z for guix-devel@gnu.org; Thu, 17 Nov 2016 05:56:17 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Frederick Muriithi , "guix-devel@gnu.org" Hi Frederick, thanks for the updated patch. I didn't see any functional issues with this patch, but I had some trouble testing this out - can I ask how to test it? My problem was simply that I didn't know of a http-only server with this authentication method. I ask because the last commit to the development repository was in 2013. Below is some minor points about the patch. If you are happy with them and we are confident in the testing then I'll push with these changes. Do not worry about sending an updated patch. On 17/11/16 01:57, Frederick Muriithi wrote: > gnu: ruby-net-http-digest-auth: Add new package > > * gnu/packages/ruby.scm (ruby-net-http-digest-auth): Added a new > package definition I changed the commit message to the following as conventional: gnu: Add ruby-net-http-digest-auth. * gnu/packages/ruby.scm (ruby-net-http-digest-auth): New variable. > --- > gnu/packages/ruby.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index 42beda3..ab10664 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -4179,3 +4179,27 @@ patterns.") > libraries for compiling Ruby native extensions.") > (home-page "https://github.com/ruby-gnome2/pkg-config") > (license license:lgpl2.0+))) > + > +(define-public ruby-net-http-digest-auth > + (package > + (name "ruby-net-http-digest-auth") > + (version "1.4") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "net-http-digest_auth" version)) > + (sha256 > + (base32 > + "14801gr34g0rmqz9pv4rkfa3crfdbyfk6r48vpg5a5407v0sixqi")))) > + (build-system ruby-build-system) > + (inputs > + `(("ruby-hoe" ,ruby-hoe))) This should be a native-input. > + (synopsis > + "Library for HTTP Digest Authentication based on RFC 2617") In general we make a habit of keeping this all on one line. How about this? (synopsis "RFC 2617 HTTP digest authentication library") > + (description > + "This library implements HTTP's Digest Authentication scheme in > ruby. > +This enables you to use the Digest Authentication scheme, > +over the more insecure Basic Authentication scheme") My science-based bias against personal pronouns perhaps, how does this sound? (description "This library implements HTTP's digest authentication scheme based on RFC 2617. This enables the use of the digest authentication scheme instead of the more insecure basic authentication scheme.") > + (home-page > + "http://github.com/drbrain/net-http-digest_auth") Best to keep that on one line. > + (license license:expat))) Thanks. ben