Re: [PATCH] gnu: ruby-net-http-digest-auth: Add new package

[Ben Woodcroft <b.woodcroft@uq.edu.au>]

Hi Frederick, thanks for the updated patch.

I didn't see any functional issues with this patch, but I had some 
trouble testing this out - can I ask how to test it? My problem was 
simply that I didn't know of a http-only server with this authentication 
method. I ask because the last commit to the development repository was 
in 2013.

Below is some minor points about the patch. If you are happy with them 
and we are confident in the testing then I'll push with these changes. 
Do not worry about sending an updated patch.

On 17/11/16 01:57, Frederick Muriithi wrote:
> gnu: ruby-net-http-digest-auth: Add new package
>
> * gnu/packages/ruby.scm (ruby-net-http-digest-auth): Added a new
>   package definition

I changed the commit message to the following as conventional:

gnu: Add ruby-net-http-digest-auth.

* gnu/packages/ruby.scm (ruby-net-http-digest-auth): New variable.

> ---
>  gnu/packages/ruby.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 42beda3..ab10664 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -4179,3 +4179,27 @@ patterns.")
>  libraries for compiling Ruby native extensions.")
>      (home-page "https://github.com/ruby-gnome2/pkg-config")
>      (license license:lgpl2.0+)))
> +
> +(define-public ruby-net-http-digest-auth
> +  (package
> +    (name "ruby-net-http-digest-auth")
> +    (version "1.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "net-http-digest_auth" version))
> +       (sha256
> +        (base32
> + "14801gr34g0rmqz9pv4rkfa3crfdbyfk6r48vpg5a5407v0sixqi"))))
> +    (build-system ruby-build-system)
> +    (inputs
> +     `(("ruby-hoe" ,ruby-hoe)))
This should be a native-input.

> +    (synopsis
> +     "Library for HTTP Digest Authentication based on RFC 2617")
In general we make a habit of keeping this all on one line. How about this?

     (synopsis "RFC 2617 HTTP digest authentication library")

> +    (description
> +     "This library implements HTTP's Digest Authentication scheme in 
> ruby.
> +This enables you to use the Digest Authentication scheme,
> +over the more insecure Basic Authentication scheme")
My science-based bias against personal pronouns perhaps, how does this 
sound?

     (description
      "This library implements HTTP's digest authentication scheme based on
RFC 2617.  This enables the use of the digest authentication scheme instead
of the more insecure basic authentication scheme.")

> +    (home-page
> +     "http://github.com/drbrain/net-http-digest_auth")
Best to keep that on one line.

> +    (license license:expat)))

Thanks.
ben