From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Pimentel Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player Date: Wed, 05 Aug 2015 11:27:51 -0300 Message-ID: <1d73da04df0affa581dbaeead8cb3f35@openmailbox.org> References: <87oailvn9g.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_dfd16a8e4d4713b8bf573d345b2d8bce" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMzfz-00032t-AT for guix-devel@gnu.org; Wed, 05 Aug 2015 10:28:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMzft-0000e4-3u for guix-devel@gnu.org; Wed, 05 Aug 2015 10:28:15 -0400 In-Reply-To: <87oailvn9g.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org, guix-devel-bounces+d4n1=opmbx.org@gnu.org --=_dfd16a8e4d4713b8bf573d345b2d8bce Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-08-05 11:11, Ricardo Wurmus wrote: > Hi Daniel, >=20 > unfortunately, the commit message is still not correct. It=E2=80=99s a= ll on=20 > one > line and =E2=80=9Cgnu: enlightenment:=E2=80=9D should be =E2=80=9Cgnu:=E2= =80=9D instead. If you use > =E2=80=9Cgit commit=E2=80=9D without =E2=80=9C-m=E2=80=9D you can edit = the message in your default > editor (configurable by setting the EDITOR variable). >=20 >> +(define-public rage >> + (package >> + (name "rage") >> + (version "0.1.4") >> + (source (origin >> + (method url-fetch) >> + (uri >> + (string-append >> + =20 >> "http://download.enlightenment.org/rel/apps/rage/rage-" >> + version ".tar.gz")) >> + (sha256 >> + (base32=20 >> "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg")))) >> + (build-system gnu-build-system) >> + (native-inputs >> + `(("pkg-config" ,pkg-config))) >> + (inputs >> + `(("efl" ,efl) >> + ("elementary" ,elementary))) >> + (home-page "http://www.enlightenment.org") >=20 > The home page for =E2=80=9Crage=E2=80=9D actually seems to be > https://www.enlightenment.org/about-rage >=20 >> + (synopsis "Powerful video play based on EFL") >=20 > =E2=80=9Cvideo play=E2=80=9D =E2=80=93> =E2=80=9Cvideo player=E2=80=9D.= Not sure if =E2=80=9CPowerful=E2=80=9D is a good word > for a synopsis. What makes it powerful? If this cannot be expressed > within the limited space of a synopsis it should be omitted. >=20 >> + (description >> + "Rage is a video and audio player written with Enlightenment=20 >> Foundation Libraries >> +with some extra bells and whistles.") >=20 > This line looks a little too long. When in Emacs please just use M-q=20 > to > break the long line according to our limits. >=20 > ~~ Ricardo Thanks Ricardo, I did the corrections using emacs editor and I did commit based on logs=20 (see git log). It's right now? --=20 Daniel Pimentel (d4n1 3:) --=_dfd16a8e4d4713b8bf573d345b2d8bce Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0004-gnu-Add-Rage-player.patch Content-Disposition: attachment; filename=0004-gnu-Add-Rage-player.patch; size=1225 RnJvbSAxMWFjYWU1YmY0Y2JhZDliYjVkODcwNzk4OWU1MzA3NGM2NDdlZjhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgUGltZW50ZWwgPGQ0bjFAbWVtYmVyLmZzZi5vcmc+ CkRhdGU6IFdlZCwgNSBBdWcgMjAxNSAxMToyMjoxNSAtMDMwMApTdWJqZWN0OiBbUEFUQ0ggNC80 XSBnbnU6IEFkZCBSYWdlIHBsYXllci4KCiogZ251L3BhY2thZ2VzL2VubGlnaHRlbm1lbnQuc2Nt OiBDaGFuZ2UgVVJJIGluIGhvbWUtcGFnZSBhbmQgZGVzY3JpcHRpb24uCi0tLQogZ251L3BhY2th Z2VzL2VubGlnaHRlbm1lbnQuc2NtIHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW5s aWdodGVubWVudC5zY20gYi9nbnUvcGFja2FnZXMvZW5saWdodGVubWVudC5zY20KaW5kZXggNWFh NjUyNS4uNDhiOWEzMiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2VubGlnaHRlbm1lbnQuc2Nt CisrKyBiL2dudS9wYWNrYWdlcy9lbmxpZ2h0ZW5tZW50LnNjbQpAQCAtMjU1LDExICsyNTUsMTEg QEAgY29udGVudHMgYW5kIG1vcmUuIikKICAgICAoaW5wdXRzCiAgICAgIGAoKCJlZmwiICxlZmwp CiAgICAgICAgKCJlbGVtZW50YXJ5IiAsZWxlbWVudGFyeSkpKQotICAgIChob21lLXBhZ2UgImh0 dHA6Ly93d3cuZW5saWdodGVubWVudC5vcmciKQotICAgIChzeW5vcHNpcyAiUG93ZXJmdWwgdmlk ZW8gcGxheSBiYXNlZCBvbiBFRkwiKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vd3d3LmVubGln aHRlbm1lbnQub3JnL2Fib3V0LXJhZ2UiKQorICAgIChzeW5vcHNpcyAiVmlkZW8gYW5kIGF1ZGlv IHBsYXllciBiYXNlZCBvbiBFRkwiKQogICAgIChkZXNjcmlwdGlvbgotICAgICAiUmFnZSBpcyBh IHZpZGVvIGFuZCBhdWRpbyBwbGF5ZXIgd3JpdHRlbiB3aXRoIEVubGlnaHRlbm1lbnQgRm91bmRh dGlvbiBMaWJyYXJpZXMgCi13aXRoIHNvbWUgZXh0cmEgYmVsbHMgYW5kIHdoaXN0bGVzLiIpCisg ICAgICJSYWdlIGlzIGEgdmlkZW8gYW5kIGF1ZGlvIHBsYXllciB3cml0dGVuIHdpdGggRW5saWdo dGVubWVudCBGb3VuZGF0aW9uCitMaWJyYXJpZXMgd2l0aCBzb21lIGV4dHJhIGJlbGxzIGFuZCB3 aGlzdGxlcy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6YnNkLTIpKSkKIAogKGRlZmluZS1wdWJs aWMgZW5saWdodGVubWVudAotLSAKMi40LjMKCg== --=_dfd16a8e4d4713b8bf573d345b2d8bce--