From: Daniel Pimentel <d4n1@openmailbox.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org, guix-devel-bounces+d4n1=opmbx.org@gnu.org
Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player
Date: Wed, 05 Aug 2015 11:27:51 -0300 [thread overview]
Message-ID: <1d73da04df0affa581dbaeead8cb3f35@openmailbox.org> (raw)
In-Reply-To: <87oailvn9g.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]
On 2015-08-05 11:11, Ricardo Wurmus wrote:
> Hi Daniel,
>
> unfortunately, the commit message is still not correct. It’s all on
> one
> line and “gnu: enlightenment:” should be “gnu:” instead. If you use
> “git commit” without “-m” you can edit the message in your default
> editor (configurable by setting the EDITOR variable).
>
>> +(define-public rage
>> + (package
>> + (name "rage")
>> + (version "0.1.4")
>> + (source (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append
>> +
>> "http://download.enlightenment.org/rel/apps/rage/rage-"
>> + version ".tar.gz"))
>> + (sha256
>> + (base32
>> "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
>> + (build-system gnu-build-system)
>> + (native-inputs
>> + `(("pkg-config" ,pkg-config)))
>> + (inputs
>> + `(("efl" ,efl)
>> + ("elementary" ,elementary)))
>> + (home-page "http://www.enlightenment.org")
>
> The home page for “rage” actually seems to be
> https://www.enlightenment.org/about-rage
>
>> + (synopsis "Powerful video play based on EFL")
>
> “video play” –> “video player”. Not sure if “Powerful” is a good word
> for a synopsis. What makes it powerful? If this cannot be expressed
> within the limited space of a synopsis it should be omitted.
>
>> + (description
>> + "Rage is a video and audio player written with Enlightenment
>> Foundation Libraries
>> +with some extra bells and whistles.")
>
> This line looks a little too long. When in Emacs please just use M-q
> to
> break the long line according to our limits.
>
> ~~ Ricardo
Thanks Ricardo,
I did the corrections using emacs editor and I did commit based on logs
(see git log). It's right now?
--
Daniel Pimentel (d4n1 3:)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-gnu-Add-Rage-player.patch --]
[-- Type: text/x-diff; name=0004-gnu-Add-Rage-player.patch, Size: 1225 bytes --]
From 11acae5bf4cbad9bb5d8707989e53074c647ef8c Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Wed, 5 Aug 2015 11:22:15 -0300
Subject: [PATCH 4/4] gnu: Add Rage player.
* gnu/packages/enlightenment.scm: Change URI in home-page and description.
---
gnu/packages/enlightenment.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 5aa6525..48b9a32 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -255,11 +255,11 @@ contents and more.")
(inputs
`(("efl" ,efl)
("elementary" ,elementary)))
- (home-page "http://www.enlightenment.org")
- (synopsis "Powerful video play based on EFL")
+ (home-page "https://www.enlightenment.org/about-rage")
+ (synopsis "Video and audio player based on EFL")
(description
- "Rage is a video and audio player written with Enlightenment Foundation Libraries
-with some extra bells and whistles.")
+ "Rage is a video and audio player written with Enlightenment Foundation
+Libraries with some extra bells and whistles.")
(license license:bsd-2)))
(define-public enlightenment
--
2.4.3
next prev parent reply other threads:[~2015-08-05 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:38 [PATCH] Update enlightenment.scm: Add Rage Player Daniel Pimentel
2015-08-05 13:59 ` Thompson, David
2015-08-05 14:08 ` Daniel Pimentel
2015-08-05 14:11 ` Ricardo Wurmus
2015-08-05 14:27 ` Daniel Pimentel [this message]
2015-08-05 14:31 ` Ricardo Wurmus
2015-08-05 14:35 ` Daniel Pimentel
2015-08-06 14:16 ` Daniel Pimentel
2015-08-06 14:24 ` Ricardo Wurmus
2015-08-06 14:33 ` Daniel Pimentel
2015-08-18 16:51 ` Ludovic Courtès
2015-08-18 18:28 ` Daniel Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d73da04df0affa581dbaeead8cb3f35@openmailbox.org \
--to=d4n1@openmailbox.org \
--cc=guix-devel-bounces+d4n1=opmbx.org@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).