unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
Cc: guix-devel@gnu.org
Subject: Commit ‘gnu: ghc-8.10: Disable failing test on i686.’ has a cross-compilation bug
Date: Fri, 05 Nov 2021 20:19:41 +0000	[thread overview]
Message-ID: <1c42b9123b8e425f0045e0c3d128f4e00fdb8fe3.camel@telenet.be> (raw)

Hi,

About this commit:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=89de1924cb535fc2c97d3654e21badaebd43518e

> +           ,@(if (string=? "i686-linux" (%current-system))
> +              '((add-after 'skip-more-tests 'skip-failing-tests-i686
> +                 (lambda _
> +                   (substitute*
'("testsuite/tests/codeGen/should_compile/all.T")
> +                     (("(test\\('T15155l',
)when\\(unregisterised\\(\\), skip\\)" all before)
> +                      (string-append before "when(arch('i386'),
skip)"))))))
> +              '())))))

Barring any reports of the contrary, I'd presume the same would
apply for the Hurd. Also, %current-target-system seems more
appropriate, though here it doesn't matter because it's only
for tests.

I suggest: ,@(if (target-x86-64?) '(...) '())

Greetings,
Maxime
-- 
not hacking on guix for a while, only occassionally looking at IRC logs
and bug reports.  E-mails are unsigned until backup is located.




             reply	other threads:[~2021-11-05 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 20:19 Maxime Devos [this message]
2021-11-06 11:07 ` Commit ‘gnu: ghc-8.10: Disable failing test on i686.’ has a cross-compilation bug Lars-Dominik Braun
2021-11-06 12:42   ` Maxime Devos
2021-11-07 10:17     ` Lars-Dominik Braun
2021-11-07 10:29       ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c42b9123b8e425f0045e0c3d128f4e00fdb8fe3.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).