From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH] Added package xcalib Date: Wed, 16 Nov 2016 01:37:04 +0100 Message-ID: <187506c7022391ac0766a444f73657df@mykolab.ch> References: <20161115193543.GB420@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_58ba02b93e824039b3e9f19de3f9f777" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6oEG-0006h3-Ux for guix-devel@gnu.org; Tue, 15 Nov 2016 19:37:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6oED-0004oD-0B for guix-devel@gnu.org; Tue, 15 Nov 2016 19:37:32 -0500 Received: from mx.kolabnow.com ([95.128.36.1]:62582 helo=mx-out02.mykolab.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6oEC-0004o3-MP for guix-devel@gnu.org; Tue, 15 Nov 2016 19:37:28 -0500 In-Reply-To: <20161115193543.GB420@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=_58ba02b93e824039b3e9f19de3f9f777 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi Leo, Thanks for reviewing this patch and helping me do this right! I have worked through the issues you brought up, and it should at least be better now. Maybe even good. There is no indication of GPL v2 or later in the project though. Best, Petter On 2016-11-15 20:35, Leo Famulari wrote: > On Mon, Nov 14, 2016 at 05:05:55PM +0100, Petter wrote: >> Hi, >> >> I just made a recipe for xcalib, with help from iyzsong. This is the >> first >> time I've created one so please be extra alert while reviewing, and >> don't >> hesitate to inform me of mistakes. > > Thanks Petter and iyzsong! > > I think the package should go in the (gnu packages xdisorg) module > instead of its own module. > >> From 00ca66ec205baf52dc340faa61fd8ac38122e273 Mon Sep 17 00:00:00 2001 >> From: Petter >> Date: Mon, 14 Nov 2016 16:56:33 +0100 >> Subject: [PATCH] Added package xcalib > > The commit title should be "gnu: Add xcalib.". > > Also, please add a "changelog" line describing the code changes. In > this > case, it should be: > > * gnu/packages/xdisorg (xcalib): New variable. > > This is the GNU convention, and we mention it in the manual, section > 8.5 > Submitting Patches [0]. Please refer to earlier Git commits or ask for > help > on IRC if you are unsure about it. > > [0] > https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html > >> +(define-public xcalib >> + (package >> + (name "xcalib") >> + (version "0.8") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> "http://downloads.sourceforge.net/xcalib/" >> + "xcalib-source-" version >> ".tar.gz")) > > We have a SourceForge "mirror" URL that should be used. Grep for > 'mirror://sourceforge' in gnu/packages for some examples of how to use > it. > >> + (arguments >> + '(#:make-flags '("CC=gcc") >> + #:phases (modify-phases %standard-phases >> + (delete 'configure) >> + (delete 'check) > > Please add a comment explaining why we skip the tests. If there is no > test suite, just use "No test suite". Also, we prefer to skip tests by > setting #:tests? #f instead of deleting the check phase. > >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (bin (string-append out "/bin"))) >> + (mkdir-p bin) >> + (install-file "xcalib" bin))))))) > > Okay. Please check if there is any documentation that could also be > installed. You can add a build phase before 'install that just fails: > (lambda _ #f), build with --keep-failed, and then look in the build > directory for man pages, READMEs, Info pages, etc. > >> + (license gpl2))) > > Please double-check if the source files contain the "or later" text in > the license headers. If so, it's gpl2+. --=_58ba02b93e824039b3e9f19de3f9f777 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-xcalib.patch Content-Disposition: attachment; filename=0001-gnu-Add-xcalib.patch; size=2851 RnJvbSA5ZGViNGQ3MzYwYWYzNThhNWVmOWUyODBiNDQzYjNkZjhmODUxNDNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXR0ZXIgPHBldHRlckBteWtvbGFiLmNoPgpEYXRlOiBXZWQs IDE2IE5vdiAyMDE2IDAxOjE0OjM2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQgeGNh bGliLgoKKiBnbnUvcGFja2FnZXMveGRpc29yZyAoeGNhbGliKTogTmV3IHZhcmlhYmxlLgotLS0K IGdudS9wYWNrYWdlcy94ZGlzb3JnLnNjbSB8IDQyICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9nbnUvcGFja2FnZXMveGRpc29yZy5zY20gYi9nbnUvcGFja2FnZXMveGRpc29yZy5z Y20KaW5kZXggYTI2YzcxNi4uZmFmMWE0ZCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3hkaXNv cmcuc2NtCisrKyBiL2dudS9wYWNrYWdlcy94ZGlzb3JnLnNjbQpAQCAtMTUsNiArMTUsNyBAQAog Ozs7IENvcHlyaWdodCDCqSAyMDE2IExlbyBGYW11bGFyaSA8bGVvQGZhbXVsYXJpLm5hbWU+CiA7 OzsgQ29weXJpZ2h0IMKpIDIwMTYgQWxleCBLb3N0IDxhbGV6b3N0QGdtYWlsLmNvbT4KIDs7OyBD b3B5cmlnaHQgwqkgMjAxNiBNYXJpdXMgQmFra2UgPG1iYWtrZUBmYXN0bWFpbC5jb20+Cis7Ozsg Q29weXJpZ2h0IMKpIDIwMTYgUGV0dGVyIDxwZXR0ZXJAbXlrb2xhYi5jaD4KIDs7OwogOzs7IFRo aXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xMDYyLDMgKzEwNjMsNDQgQEAg WENCIHV0aWwteHJtIG1vZHVsZSBwcm92aWRlcyB0aGUgZm9sbG93aW5nIGxpYnJhcmllczoKIAog LSB4cm06IHV0aWxpdHkgZnVuY3Rpb25zIGZvciB0aGUgWCByZXNvdXJjZSBtYW5hZ2VyLiIpCiAg ICAgKGxpY2Vuc2UgbGljZW5zZTp4MTEpKSkKKworKGRlZmluZS1wdWJsaWMgeGNhbGliCisgIChw YWNrYWdlCisgICAgKG5hbWUgInhjYWxpYiIpCisgICAgKHZlcnNpb24gIjAuOCIpCisgICAgKHNv dXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAg ICAgICAodXJpIChzdHJpbmctYXBwZW5kICJtaXJyb3I6Ly9zb3VyY2Vmb3JnZS94Y2FsaWIveGNh bGliLyIgdmVyc2lvbgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIveGNhbGli LXNvdXJjZS0iIHZlcnNpb24gIi50YXIuZ3oiKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAg ICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICIxcmg2eGI1MWM1eHo5MjZkbm44 MmEyZm42NDNnMHNyNGE4ejY2cm42eWk3NTIza2p3NGNhIikpKSkKKyAgICAoYnVpbGQtc3lzdGVt IGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICAnKCM6bWFrZS1mbGFncyAn KCJDQz1nY2MiKQorICAgICAgICM6dGVzdHM/ICNmICAgOyBObyB0ZXN0IHN1aXRlCisgICAgICAg IzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgICAg ICAgKGRlbGV0ZSAnY29uZmlndXJlKQorICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2luc3Rh bGwKKyAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1v dGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAgICAgIChsZXQqICgob3V0IChhc3NvYy1yZWYg b3V0cHV0cyAib3V0IikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChiaW4gKHN0cmlu Zy1hcHBlbmQgb3V0ICIvYmluIikpKQorICAgICAgICAgICAgICAgICAgICAgICAgKG1rZGlyLXAg YmluKQorICAgICAgICAgICAgICAgICAgICAgICAgKGluc3RhbGwtZmlsZSAieGNhbGliIiBiaW4p KSkpCisgICAgICAgICAgICAgICAgICAoYWRkLWFmdGVyICdpbnN0YWxsICdpbnN0YWxsLWRvYwor ICAgICAgICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVy LWtleXMpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKGRvYyAoc3RyaW5nLWFwcGVuZChh c3NvYy1yZWYgb3V0cHV0cyAib3V0IikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIi9zaGFyZS9kb2MvIikpKQorICAgICAgICAgICAgICAgICAgICAgICAg KGluc3RhbGwtZmlsZSAiUkVBRE1FIiBkb2MpCisgICAgICAgICAgICAgICAgICAgICAgICA7OyBB dm9pZCB1bnNwZWNpZmllZCByZXR1cm4gdmFsdWUuCisgICAgICAgICAgICAgICAgICAgICAgICAj dCkpKSkpKQorICAgIChpbnB1dHMgYCgoImxpYngxMSIsIGxpYngxMSkKKyAgICAgICAgICAgICAg KCJsaWJ4ZXh0IiwgbGlieGV4dCkKKyAgICAgICAgICAgICAgKCJsaWJ4eGY4NnZtIiwgbGlieHhm ODZ2bSkpKQorICAgIChzeW5vcHNpcyAiVGlueSBtb25pdG9yIGNhbGlicmF0aW9uIGxvYWRlciBm b3IgWEZyZWU4NiAob3IgWC5vcmcpIikKKyAgICAoZGVzY3JpcHRpb24gInhjYWxpYiBpcyBhIHRp bnkgdG9vbCB0byBsb2FkIHRoZSBjb250ZW50IG9mIHZjZ3QtVGFncyBpbiBJQ0MKK3Byb2ZpbGVz IHRvIHRoZSB2aWRlbyBjYXJkJ3MgZ2FtbWEgcmFtcC4gIEl0IGRvZXMgd29yayB3aXRoIG1vc3Qg dmlkZW8gY2FyZAorZHJpdmVycyBleGNlcHQgdGhlIGdlbmVyaWMgVkVTQSBkcml2ZXIuICBBbHRl ciBicmlnaHRuZXNzLCBjb250cmFzdCwgUkdCLCBhbmQKK2ludmVydCBjb2xvcnMgb24gYSBzcGVj aWZpYyBkaXNwbGF5L3NjcmVlbi4iKQorICAgIChob21lLXBhZ2UgImh0dHA6Ly94Y2FsaWIuc291 cmNlZm9yZ2UubmV0LyIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKSkpCi0tIAoyLjEwLjEK Cg== --=_58ba02b93e824039b3e9f19de3f9f777--