From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sC1hOdW2FGDuUgAA0tVLHw (envelope-from ) for ; Sat, 30 Jan 2021 01:31:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wBEcNdW2FGBzYgAA1q6Kng (envelope-from ) for ; Sat, 30 Jan 2021 01:31:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B6CE94030E for ; Sat, 30 Jan 2021 01:31:01 +0000 (UTC) Received: from localhost ([::1]:34396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5f6K-0004zw-5J for larch@yhetil.org; Fri, 29 Jan 2021 20:31:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5f64-0004vR-1W for guix-devel@gnu.org; Fri, 29 Jan 2021 20:30:45 -0500 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:41304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5f61-00015O-N5 for guix-devel@gnu.org; Fri, 29 Jan 2021 20:30:43 -0500 Received: by mail-qv1-xf35.google.com with SMTP id h21so5417088qvb.8 for ; Fri, 29 Jan 2021 17:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=cBEv/SC5eZtA1VRcHFtXljYSrQEjfX6SZ1ak1qES2J4=; b=puqPWP2g0NGznILUNljOD3/r2+bIgQ3FnyJyxIUGmffSB+okbVJtMC5AUE/bSw++MM DSVc7bLiwUNFhnWLR6GTSGhJVPWl8fVjlzJcV7jm5oK3H9xYdqLChljp7k2/6cwUNOpH UMNrHZPhKhnWx86xz9gsPK1xUjFJWMSgulKTX343z2E6YiF0g4dVnuIf2Vh+A13NYaQu VFq0MG0iH4SJS2ZWemlKs51U/ic5z3is9sitnsfRnPM5wN/jq09YgwQRFofE30BmlV/t xkOC946azUvb+3It4yVPiCc027Xp2Ut9UwBjSgkypPfUGHQktjvewmny5PrPxn/coMJ/ Y1kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=cBEv/SC5eZtA1VRcHFtXljYSrQEjfX6SZ1ak1qES2J4=; b=OVArrThfbM3Y3ObPAE6h1au7v7zTtj/tJqWUQ0XuRc82zQ8rHDLzDXbr382s2LvmCk IyNcRSM+zqYAH2nRIJJbuziSYcEjCYAXSxFT+yoGVUhFdN6Cvyid1c5CKb/zwnuRYgnV LWG60KFqxcK2Y8iVZlzPP5fnqitBUiWHAV8H3T86bg5QwOgWvSCFgxguY5P0pDOAcTjk axS4lAwhY8Bu6jdZYsclfD/9ot42Y2F9C132WtMt8V6xtYT+2nUQox9J8oOACiC7qV6s X95aA57Vqzmv9eQWVftDh6k+7D6Wy2Ac+n7pZPDnmpivUckk6Kj3Lwyelo8PbvllL1g5 bb9g== X-Gm-Message-State: AOAM533xoPCTqhTMMEqpZqAgaqJSAeaZHkM3B6nekOE3poVK2X8TFdzp aDr2NFNy2e8g3XOrlAMD5VMZPf8pGPgEjMzV X-Google-Smtp-Source: ABdhPJxXE07q4kqQzegUbMIBiOXtJPqNeSuLcBdh7sAvIvMuegHXkYIDPZXLYFxEuTxb4PHOegMg3g== X-Received: by 2002:a05:6214:a66:: with SMTP id ef6mr6496637qvb.14.1611970239812; Fri, 29 Jan 2021 17:30:39 -0800 (PST) Received: from ?IPv6:2804:14c:bbe3:444c:ec6b:2e4e:b8f4:b796? ([2804:14c:bbe3:444c:ec6b:2e4e:b8f4:b796]) by smtp.gmail.com with ESMTPSA id j5sm749239qth.80.2021.01.29.17.30.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jan 2021 17:30:38 -0800 (PST) To: zimoun , =?UTF-8?Q?G=c3=a1bor_Boskovits?= , Guix Devel References: <86im7ghd9c.fsf@gmail.com> From: Magali Autocrypt: addr=magalilemes00@gmail.com; keydata= mQINBF/OWLMBEAC9RPIj/byKDnMrDYPUHdDUalPenP0p5XAfFWcWXqlWXAMBMZ0YQMYXPm/d 3VjWcR6D+LMubp1t+Txd26rld0LWOpQxLYWJqxua4/B2nmhH+dLZV0h+QWfXRV4IrJk697q1 HvH+UKt1azS1Ayt4ryO0kW30a0RlcrZHb54FJ6ZOyU6FMk36A1oQGQOC4FMjhfx5MmwK4Jw+ Gt/7w5UF17wI99/iy407P2gEtN+toJ6+SOQ5sXX7Ce29ytYkXO2JhrCtSZ81oyFwYfs3uC0S BEJAs932wRCrAC/sDcXk5Lxh3NEpfIxhazzqnHK31v7i6XypxN2rA1Fq95q0MmCXuFlZ7moU KmMuLY7u2itBvOrbqCECt93VQlKYtTm7Y/zLwqC3GbgKM94gtLGIXt1SiB8MButJL9W3kt0F nAquMqSVqwf/qZ7Shgv8TvhbjqnLLqxHiS2ZlYk+sWzU3EpktL+oKrPx/cIPRpS0mEzCAvW5 Vr4iZpaRNAutql9k9R8ROdzFX6l3B/0uQm7aK96snF1wHCnwfmy7TuCkVpnYqK+ISmPLRQf3 qCgX/BRhQOeo64ofXMNkagEf8WXtgUUqE60ZsMckgZWeM7x61ZnPGcl63UR087+8sXUMpmr3 oKAKZOONrYd9pSzQkWxWYAOqHrBNxzWACgVHgQzoOkDokqrVtwARAQABtDRNYWdhbGkgTGVt ZXMgZG8gU2FjcmFtZW50byA8bWFnYWxpbGVtZXMwMEBnbWFpbC5jb20+iQJOBBMBCgA4FiEE klyOvfRGkx0bZESYLVihEm4t/JAFAl/OWLMCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AA CgkQLVihEm4t/JD+jw/9EanqCg6+Mrut3kDRwVciYag/LcpPY7USd/op7qbt0oh8d8/qALsB RYeVTuA9Iv1UO+z2/5TCsV2Xv6w5//AMKzIuXUTvcHEJLs7sWgx4T5aCMe6BXFBzxE9TIb1u hWOWBRwuV/pNWf4dAMfznyVlAWEjSvBiKq8r/IBIXnvziT3BZ/Yi5/sq1HOHNcgti+DAdQQg o+/J+0dzAnlbXfakb7ER/LcZNIOycbDJ0TWRW300Bc2a3BQnKLU5gqTJbh6BmYBC9OAsagFd 80R/ZQDEawhgdCcnsFLPR+dOj0f5IUGREVi7JZ28vBs9sgo0I0ukBWgti4KSejs336le9cee dK2/ZVbBISb1xJAtfDyLLWevanB51CYIAtvWrwxYtjY1wzcTlbMvafb4OgxHkiPBmm+Ahgrm PpQsW34GEKObY1FVZlDQ1oxhTBvxTITC31I/JESLGkMMUHpznma6LaonL85r5QBXCG7d/Udi jEd3fzEjg8OFq9hnt96qMtrNZq0qrdR5aUq49s3kx34cpUe6lAOJyhQGqRjYe9FMniRqNWV9 XEFUY6SXulg+g6nyXZYyvWMWoZac2nw8XNmszIcYLdtt8pAGLknUfLE8BMF6n0ZH7AA7no4A zDHw8eneyc2NfVZKxIn2MBI+PAR6kf18WcjKC4dkio7QmbhOCE/0kMO5Ag0EX85YswEQALvr yhzW/umU1+vP43ODEcfzZGXxPlgEsslfhBHmTm0YI7lwYMKb9E3rGyL9qMYWDd2G7R3u3gmX yl/eSeh16ZtJRns9GsLS1Qp8a3Zp/XOmKXZff5EGRyJCbo7hpfh+kRFGDoVPAs7ltffV8zjo tEzudapUuR+1culp7qhBS8NP6Ra2r1/jnX5IeQeaFxhPnzA7QYN9tyjYw69bztXAO37SM+5H tzlgXT6XaS/PV88Iv0K77o6D1OfSIcjrbZjSidW7UySZiUwAVRwjjvbMh+Mf3/8HKZgjAiaT 1iR06XBk4IBRaUP9JLv2p7elkMUSDvsn10S3HWoemOFYTUTlWgFLYAc+GKU2gTqIufVzQJvT w2jPM6OqeGBFvVUfDuBBhdoT7zI8f/DbC+WP69eAS1J57hlqI5FFs4z9kfCCxaxfqMXvZciA OUA3j/2WSmdEWveX0zTPWwoOR7jh8FO1wQVxa0E/6/J0/B81R4OOxRhRLsselB+KJFyUXaN1 GZ6hXu33kDu/cn4zm67O060xQ4XFNZKREmCu2vhFLgDlIBAfRoLXLc/z5XDHQA+rKwIfrBxY bGd0DUNTRCh6l3AZ92tXJpQAFJorRtxqKwhzY0bK4kbcxuYW/gVS7/9xnm6DNrlxOr0M1Y77 CpoaVaAvkaXVvnR+pqhI6uBxo0jOjdfDABEBAAGJAjYEGAEKACAWIQSSXI699EaTHRtkRJgt WKESbi38kAUCX85YswIbDAAKCRAtWKESbi38kCQAEACXHJJ6/TqpLki2thK222KnXS7rMWPL Tp7DE4i7Tj0kJDII+F4dbjzx98wR4+QdW/XMCM+9FUMZp9UBd7/TqLgf46PwHGJQ9crt+OKn I5s6Je6fLdToRfHlrb7y8huPs3A5xYmXkuYsjwPKcHwL5u3zopI1d9CWcHD42mnD0sw0km8Q SLX3Cx7Z7Anen76phyLKtf2YKERA6LTPrwKunYheg0YvVT1KKZtXJ4+8zcQHiWDfwbQqYFJ3 y6uoNIGa9wsamtIbhAszuO1NieAh5hQ5ilCAbMK+Uu1Ktm2Bu9RJ4ccnf+U+RE41nkj4mMlY NYGxrsTTjYwZOg5MZGyZHq+W1F+11FBOy1PkQ18Xi4zTamOnyTS/vx3BLjsAThYszggBmNP7 luLc/+x3vAsBVMQVnMXpNd1Kczr7gbUu7HKvG85Em5ETCPxlv6b6CFTY+NuAdOPU4wGe9QDr +dDNnOgaTybO5/p5Im0RZOmnMi+/q3hObfd+Ot6tGhliekaVvZZGpsoc7XTOIujrrnXyNl9r 3jhgd1QoW1Cy0TtM/tkZ/rgv+m0TWyY8KCIo1zdmgzCuVBhfr3PwSbL/+XkoOZODFnFvE6S5 P+4V/UHeaJzG+W9AYmVwcIcfTWX4QeOo2M/qPTRwn9mgJzYfGTr3l64q+iXWA+8MtQls0RYU ijdHLA== Subject: Re: [Outreachy] Feedback on 'guix git log' subcommand Message-ID: <187129df-8f78-5b3b-0a82-3e533db373b7@gmail.com> Date: Fri, 29 Jan 2021 22:30:35 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <86im7ghd9c.fsf@gmail.com> Content-Type: multipart/mixed; boundary="------------CECB593FFA973820D7B6216D" Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=magalilemes00@gmail.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.05 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=puqPWP2g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6B6CE94030E X-Spam-Score: -3.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: L0na90ubfwXk This is a multi-part message in MIME format. --------------CECB593FFA973820D7B6216D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! On 28/01/2021 20:07, zimoun wrote: > Doing that, I am thinking of two nice features: > > 1. get the parent commits > 2. show a specific commit > > For example, > > guix git log --parents=3D3142daccbe # =3D> 631e1f33 > guix git log --show=3D3142daccbe > > so then I can feed =E2=80=9Cguix time-machine=E2=80=9D with 631e1f33 to= have > =E2=80=99python2-setuptools=E2=80=99 before it breaks. I am not sure t= o what =E2=80=9C--show=E2=80=9D > would do. > > WDYT? Both features seem cool. I think that '--show' could simply display the commit message, and other info such as commit author, committer, date and parents. > Hum, =E2=80=99--grep=E2=80=99 seems missing. I do not remember, is it = not working? > Even slowly? It's working but I guess I forgot to add an example :-). You could invoke, for instance =2E/pre-inst-env guix git log --oneline --grep=3D"htop" or =2E/pre-inst-env guix git log --grep=3D"htop" --format=3Dmedium and it should work. > but =E2=80=9Cguix system=E2=80=9D hard code all the subcommands. So, m= aybe hardcoding > the =E2=80=9Clog=E2=80=9D subcommand is the way to do; with translation= in mind, I > guess. I see, but I believe it could also be possible to have the translation in mind, still using an associaton list for %sub-commands, like in the patch attached. wdyt? >> Another thing is that the command is a bit slower than 'git log' itsel= f. >> Thoughts on how that could be improved? > I will provide more on a separate email. And review more in details th= e > code. :-) > > > Thanks for working on that. That=E2=80=99s cool! :-) Great, thank you! Magali --------------CECB593FFA973820D7B6216D Content-Type: text/x-patch; charset=UTF-8; name="guix-git.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="guix-git.patch" diff --git a/guix/scripts/git.scm b/guix/scripts/git.scm index 3b141a622d..dfc4771f44 100644 --- a/guix/scripts/git.scm +++ b/guix/scripts/git.scm @@ -25,8 +25,8 @@ #:export (guix-git)) =20 (define %sub-commands - `(("authenticate" . "verify commit signatures and authorizations") - ("log". "show Git commit history"))) + `(("authenticate" . ,(G_ "verify commit signatures and authorizations"= )) + ("log" . ,(G_ "show Git commit history")))) =20 (define (show-help) (display (G_ "Usage: guix git COMMAND ARGS... @@ -36,7 +36,7 @@ Operate on Git repositories.\n")) (newline) (for-each (match-lambda ((name . help) - (format #t "~13a ~a\n" name help))) + (format #t " ~15a ~a\n" name help))) %sub-commands) (newline) (display (G_ " --------------CECB593FFA973820D7B6216D--