From: Manolis Ragkousis <manolis837@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add the Hurd.
Date: Sun, 9 Apr 2017 09:55:01 +0300 [thread overview]
Message-ID: <1863af86-cb40-73e4-830e-4ac31e1a4ed7@gmail.com> (raw)
In-Reply-To: <20170409024136.GA2700@macbook42.flashner.co.il>
Hello Efraim,
On 04/09/17 05:41, Efraim Flashner wrote:
> On Sat, Apr 08, 2017 at 05:06:57PM +0300, manolis837@gmail.com wrote:
>> From: Manolis Ragkousis <manolis837@gmail.com>
>>
>> + (modify-phases %standard-phases
>> + (add-before 'build 'pre-build
>> + (lambda _
>> + ;; Don't change the ownership of any file at this time.
>> + (substitute* "daemons/Makefile"
>> + (("-o root -m 4755") ""))
>> + (substitute* "utils/Makefile"
>> + (("-o root -m 4755") ""))
>> + #t)))
>
> These substitute* lines could be written as:
> (substitute* '("daemons/Makefile" "utils/Makefile")
> (("-o root -m 4775") ""))
>
Yes you are right. I will fix it and push to master. :)
Manolis
next prev parent reply other threads:[~2017-04-09 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 14:06 [PATCH 1/2] gnu: hurd: Add hurd-source-url procedure manolis837
2017-04-08 14:06 ` [PATCH 2/2] gnu: Add the Hurd manolis837
2017-04-09 2:41 ` Efraim Flashner
2017-04-09 6:55 ` Manolis Ragkousis [this message]
2017-04-13 14:31 ` Ludovic Courtès
2017-04-13 14:30 ` [PATCH 1/2] gnu: hurd: Add hurd-source-url procedure Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1863af86-cb40-73e4-830e-4ac31e1a4ed7@gmail.com \
--to=manolis837@gmail.com \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).