From: sirgazil <sirgazil@zoho.com>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: gnome-characters
Date: Sat, 16 Nov 2019 20:32:01 -0500 [thread overview]
Message-ID: <16e76fcfc53.cda648ca13038.8367109867062204965@zoho.com> (raw)
In-Reply-To: <2786911a189a0dbaefef5ba514ae7c19e3b65928.camel@disroot.org>
---- On Sat, 16 Nov 2019 19:50:12 -0500 Raghav Gururajan <raghavgururajan@disroot.org> wrote ----
> Hello Guix!
>
> So I was able to successfully package 'gnome-characters'. The following
> is the package definition. I have attacted the package definition
> (gnome-characters.scm) with this email.
>
> This is the first time for me with packaging. Can anyone help me how to
> move forward from here, to integrate this with guix upstream?
Maybe it could help to read the Contributing section in GNU Guix Reference Manual (https://guix.gnu.org/manual/en/html_node/Contributing.html#Contributing). You will find packaging guidelines and information about submitting patches to add your package. I haven't submitted any package myself yet, but I would start there, and ask here in case of doubts.
Some things I noticed in your package definition:
• Indentation probably does not follow the coding style of Guix.
• Is the value for "home-page" correct? Maybe it should be https://wiki.gnome.org/Design/Apps/CharacterMap instead?
• In origin's uri there seems to be an unnecessary use of "string-append", as you are only passing one string (not appending two or more).
---
https://sirgazil.bitbucket.io/
prev parent reply other threads:[~2019-11-17 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 0:50 gnome-characters Raghav Gururajan
2019-11-17 1:32 ` sirgazil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e76fcfc53.cda648ca13038.8367109867062204965@zoho.com \
--to=sirgazil@zoho.com \
--cc=guix-devel@gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).