From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OBuXOAKYPWMWMgAAbAwnHQ (envelope-from ) for ; Wed, 05 Oct 2022 16:43:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GF1/OAKYPWO+HAEAauVa8A (envelope-from ) for ; Wed, 05 Oct 2022 16:43:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A14A13EE15 for ; Wed, 5 Oct 2022 16:43:14 +0200 (CEST) Received: from localhost ([::1]:57932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og5c9-0000zz-QD for larch@yhetil.org; Wed, 05 Oct 2022 10:43:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og4yA-0005D9-Dr for guix-devel@gnu.org; Wed, 05 Oct 2022 10:01:56 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:38395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og4y6-0004rp-V2 for guix-devel@gnu.org; Wed, 05 Oct 2022 10:01:54 -0400 Received: (Authenticated sender: tanguy@bioneland.org) by mail.gandi.net (Postfix) with ESMTPSA id 8E85140014; Wed, 5 Oct 2022 14:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bioneland.org; s=gm1; t=1664978503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cEho9pFojnGZdyUB4r35ZxiTjtwU2ywp+AafNSMSpt0=; b=PZZjJvHoESwH8eO+LJagX8ZYlSvVIR8fzhe5R7f6PLeDj/2Fkl3FwEeiJN6Fckohc7e/9h J4Kv8YzP49ovmRMh7QTQxHhQupTFkYUaaeSNHUafYqakehLMX0WghwHppnnzbbSXKsd7YD fJRGc2SkbxjIGNbwirmtnnShsWwAkFx95oiT8vrcebljj1tRP4ayV0JGjo7hmrWESeTtZY zRCY7L5sgLXQ/ihS/arp3t3/HPCMT+jYGYofk3+oCEq6ww8amVrfJ4ax+MLOXOKH3GQY/u W6qouIdbpFOqIw+x+gowklYb27Q4xO6/URMJ95KiZBRoRjpgi3oCtVcEKSX0jw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <87a66wfzeh.fsf@cbaines.net> Subject: Re: Notes from discussion on Quality Assurance from the 10 Years of Guix event From: Tanguy LE CARROUR To: Christopher Baines , guix-devel@gnu.org In-Reply-To: <87a66wfzeh.fsf@cbaines.net> Date: Wed, 05 Oct 2022 16:01:40 +0200 Message-ID: <166497850086.2821.11724664487538606446@localhost> User-Agent: alot/0.10 Received-SPF: pass client-ip=2001:4b98:dc4:8::222; envelope-from=tanguy@bioneland.org; helo=relay2-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664980994; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cEho9pFojnGZdyUB4r35ZxiTjtwU2ywp+AafNSMSpt0=; b=pZKpgCLJ76OSKL0kG1/J9sGtUJ/WFrIYCt4FLSTav7tP6/ZE75eHf+YXLzaJl8u9EF2PBi c41MNDF8ehBVHW/0pQi6gcIBjKxOHZ2BzdQDDqSBj728ciwm5vc8pqMMlVb+VywpRCNCrR aI1oH85ks451iZLA1p2E++iShNFv4nuQRoGcJuv8bJwen2e66drWuBmCjosZC0AiaFHd+/ 4MqsXGyOmMqWqwedxoCate35HI91feY0OcsWefo6onWzDvaqpnn9JLPQKFFyHz3JEV6piY X1T4mceJkBAaja1zOMkzdtOKelbofMqxJrFW/iucn2H+wjXzwtrr+TwuTv8hFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664980994; a=rsa-sha256; cv=none; b=by8uiPPr16cjM+eLUKQUzbp3Y0NZeOCWl945FcNHFUlAOkyv9meKNQbiji1GpGfXDdD0dU ttoG7fy1BngwyuSPl/RFASrPkuF2AieK/Z/s+akMvUiSTQAGCKFuOB+0Dzi5jQRpxbBblu i9XR1YVZTPkXKsTl4HcBfgsQxnZrCmYvAf4vFcq052qgIRjxPce6NBIjnCfqSHJ48dRmi0 47PwAIOr32gKIEkBGgDScW9Pmj/9IfRRofiS7WfXQhLm44bUkE9E5QcZiFTVLbAEwDWzh8 5UFfTZ4Axl90CR70IR4ZsHJKXHx1tSBMDWf7KxGSpwZlrj5cSZRahkUlIxRV9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=bioneland.org header.s=gm1 header.b=PZZjJvHo; dmarc=pass (policy=none) header.from=bioneland.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.26 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=bioneland.org header.s=gm1 header.b=PZZjJvHo; dmarc=pass (policy=none) header.from=bioneland.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A14A13EE15 X-Spam-Score: -8.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2eZxBIAJccHz Hi Chris, Quoting Christopher Baines (2022-09-18 17:55:30) > Here are some notes I took during the discussion on patch review/quality > assurance at the 10 Years of Guix event. Thanks for the notes! After months not contributing, today, I've started contributing patches again! Seems like I've forgotten everything, so I can give you a fresh look at the process=E2=80=A6 > - Minimise the burden for submitters > - Lengthy guidance for submitting patches Actually, the `16.4 Packaging Guidelines` and `16.6 Submitting Patches` are everything that I've ever looked for. The only problem is `16.5.4 Formatting Code` that makes use of `./etc/inden= t-code.el` that was removed back in January. > - Changelog format "format" and "content". I've heard about a magic trick in Emacs, but as a user of "the other editor= ", I have to write everything manually. I guess one could write a command that would detect what has changed and write the changelog. This could also be used on the reviewer/qa side to check if the patch actually does what it says it does. > - Sending patches by email (git send-email) This one is an easy one!=E2=80=A6 at least, as long a you only have 1 patch. For a patch set, one has to generate a cover letter, send it, wait for a bug id to be assigned then send the rest of the patch set. Looks trivial, but (too) many times I ended up creating multiple bug reports for the same patch set. And the fear of messing up the bug report s= ystem was something that discouraged me at the beginning. I still do some mistake from time to time, but=E2=80=A6 I do not care any more, because I n= ow know how to fix them. > - Delay in feedback for first time submitters It doesn't actually have to be a human feedback. But being able to know that everything went well (or not) and what's the status of a patch is would be great. > - Learn how to review more patches Also learn how to review your first patch! Being able to push a "+1" button in the QA interface might be useful? For the time being, I don't know what feedback from me could be useful for a commiter and how to provide it. > - Doing useful things with little time Go through the list of "Update to X.Y.Z." patches, have a quick glance and push the "+1" button? > Actions: > - teams thing for finding out about patches, automate this somehow > - generate a web page listing the people and teams > - Filtered subscription to patches by team What the status on this? Where can I learn more about how teams work? > - Maybe script making contributions like updating packages > - Make a similar tool to Debian's how can I help > - Try to avoid suggesting updating packages with lots of dependencies `guix how-can-i-help` would be amazing! Something that would: - list all the packages in my current profile that can be updated, sorted by number of dependent packages; and - list all the packages in my profile that are currently broken. Actually, for the second point, I guess I'll figure out when upgrading my profile. Or maybe `guix weather` can help!? I guess I'll have to dive more into QA, Data Service, Weather to be of any help. But if you see anything that requires zero-knowledge just let me know! =F0=9F=98=81 Regards, --=20 Tanguy