From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Hilton Chain <hako@ultrarare.space>
Cc: guix-patches@gnu.org, guix-devel@gnu.org
Subject: Re: [PATCH] download: Add url-fetch/xz-file.
Date: Sat, 25 Feb 2023 20:25:24 +0100 [thread overview]
Message-ID: <16189d896f675c30ba117222b7dd36da@tobias.gr> (raw)
In-Reply-To: <87sffz2d9a.wl-hako@ultrarare.space>
Hi Hilton,
I agree with Ludo' and also wonder if a generic
‘url-fetch/compressed-file’ wouldn't be better. There are closure
arguments to be made for this xz-only approach. I don't know if they're
convincing. Cluebats welcome.
(I was going to bring up ‘url-fetch/tarbomb’ as an example, but it
doesn't actually handle anything besides gzip! Madness.)
On 2023-01-25 10:07, Hilton Chain wrote:
> + (setenv "XZ_OPT"
> + (string-join (%xz-parallel-args)))
Why set this kluge…
> + (invoke (string-append #+xz "/bin/unxz")
> + #$file-name)
…when we have full control over xz's arguments?
Kind regards,
T G-R
Sent from a Web browser. Excuse or enjoy my brevity.
prev parent reply other threads:[~2023-02-25 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 9:07 [PATCH] download: Add url-fetch/xz-file Hilton Chain
2023-02-25 17:48 ` Ludovic Courtès
2023-02-25 19:25 ` Tobias Geerinckx-Rice [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16189d896f675c30ba117222b7dd36da@tobias.gr \
--to=me@tobias.gr \
--cc=guix-devel@gnu.org \
--cc=guix-patches@gnu.org \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).