From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sByjK4j13l/xDwAA0tVLHw (envelope-from ) for ; Sun, 20 Dec 2020 06:56:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EOaCJ4j13l90PAAA1q6Kng (envelope-from ) for ; Sun, 20 Dec 2020 06:56:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAF899403C5 for ; Sun, 20 Dec 2020 06:56:07 +0000 (UTC) Received: from localhost ([::1]:53162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqsdS-0007kI-NX for larch@yhetil.org; Sun, 20 Dec 2020 01:56:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqsdJ-0007k3-2l for guix-devel@gnu.org; Sun, 20 Dec 2020 01:55:57 -0500 Received: from knopi.disroot.org ([178.21.23.139]:54784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqsdC-00069B-Qf for guix-devel@gnu.org; Sun, 20 Dec 2020 01:55:53 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1CFA552370; Sun, 20 Dec 2020 07:55:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BQ3j-0YxgNge; Sun, 20 Dec 2020 07:55:44 +0100 (CET) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1608447344; bh=hF8FKWBpv3nFTMO57NfJEl3NU6JfXFDd3JEdh0/+OpQ=; h=Date:From:Subject:To:Cc:In-Reply-To:References; b=JidLGIAyrukNEhCvpV+x6cdRuXWNir7BEvXr270m/M9O3k+Bzz3K4JZQBl43NbfAF g3CuCOrAS14RHM6kxSmKzOHSTwB37x+ozabfLaNHf9ECD6ujowGC2bGLwtefBrVjiF d6dHcQnmOcpnBdQsBfnFWR2Fh0cN+oO9VQWOFu0Z9Vt7XvMNHW3xlp1I1GQqNIx6AF n6224DrMkY01pwtmq2MPmnxIDok+rbUTZxAHpzHpjsP8MOPFB77h9uEmxTLLSymO25 sloHG3EC8MfrGSSgdvKVnPs9iolJU5dLqlzdEBrxa6uiAJM5pjDCsE3WdgNdQ77F6h LJQJOKP+VnNeA== Date: Sun, 20 Dec 2020 06:55:44 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <15ab2e0b0406c56c14175da0fe018d7b@disroot.org> Subject: Re: Questionable "cosmetic changes" commits To: "Christopher Baines" In-Reply-To: <87lfebrk9v.fsf@cbaines.net> References: <87lfebrk9v.fsf@cbaines.net> <87im9g4ukt.fsf@netris.org> Received-SPF: pass client-ip=178.21.23.139; envelope-from=raghavgururajan@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Ryan Prior Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" Reply-to: "Raghav Gururajan" From: "Raghav Gururajan" via "Development of GNU Guix and the GNU System distribution." X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.31 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=disroot.org header.s=mail header.b=JidLGIAy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: DAF899403C5 X-Spam-Score: -2.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: /qv1A/v41v0Y Hi Chris!=0A=0A> In the context of writing Guix packages, propagating the= necessary=0A> inputs to support other packages finding the library via p= kg-config is a=0A> serious thing, not trivial. If it breaks, dependent pa= ckages will likely=0A> change in behaviour or stop building entirely.=0A= =0AI understand. I didn't mean trivial as in importance but as in reason.= Like most common reason why one propagates an input. :-)=0A =0A> As for = the comments, personally, I think the reasons behind propagated=0A> input= s are individual enough and important enough to each package that=0A> it'= s useful to write them down, even if that comment is "these things=0A> ar= e referenced by the .pc file". That way others looking at the package=0A>= definition don't have to wonder or try and dig through the Git history= =0A> to find information about what's going on.=0A=0AAgreed.=0A=0A> Anywa= y, I think the most useful output from this discussion is amending=0A> or= adding to the packaging guilelines to cover this:=0A> =0A> https://guix.= gnu.org/manual/en/html_node/Packaging-Guidelines.html=0A=0AYes, will be u= seful.=0A=0ARegards,=0ARG.