From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: 01/01: gnu: qemu: Enable Samba support.
Date: Wed, 27 Dec 2017 23:41:31 +0000
Message-ID: <159BE99C-4CFD-437B-9768-AF13A5017F55@gmail.com>
References: <20171227092649.22335.79799@vcs0.savannah.gnu.org>
	<20171227092650.69D7B204F7@vcs0.savannah.gnu.org>
	<87r2rfn5pc.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <maxim.cournoyer@gmail.com>) id 1eULKP-00055h-Mv
	for guix-devel@gnu.org; Wed, 27 Dec 2017 18:41:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <maxim.cournoyer@gmail.com>) id 1eULKM-000503-FQ
	for guix-devel@gnu.org; Wed, 27 Dec 2017 18:41:41 -0500
Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]:34611)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <maxim.cournoyer@gmail.com>)
	id 1eULKM-0004z4-5f
	for guix-devel@gnu.org; Wed, 27 Dec 2017 18:41:38 -0500
Received: by mail-io0-x231.google.com with SMTP id q188so12506833iod.1
	for <guix-devel@gnu.org>; Wed, 27 Dec 2017 15:41:37 -0800 (PST)
In-Reply-To: <87r2rfn5pc.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Mark H Weaver <mhw@netris.org>, rhelling@mykolab.com

Hello,

On December 27, 2017 5:53:19 PM EST, Mark H Weaver <mhw@netris=2Eorg> wrot=
e:
>Hi,
>
>rhelling@mykolab=2Ecom (Rutger Helling) writes:
>
>> rhelling pushed a commit to branch master
>> in repository guix=2E
>>
>> commit 84276503059d46c0a42240f8770f59090614d863
>> Author: Rutger Helling <rhelling@mykolab=2Ecom>
>> Date:   Wed Dec 27 10:09:26 2017 +0100
>>
>>     gnu: qemu: Enable Samba support=2E
>>    =20
>>     * gnu/packages/virtualization=2Escm (qemu)[arguments]: Change
>#:configure-flags to
>>     a list, add --smbd flag=2E
>>     [inputs]: Add samba=2E
>
>I see that you have since reverted this commit, but I still thought I'd
>mention that when adding optional features to 'qemu', it would be good
>to remove them from 'qemu-minimal', which inherits from 'qemu'=2E

Maybe this relationship could be turned around? It seems like it'd make mo=
re sense=2E

Maxim