From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: guix-devel@gnu.org, Mark H Weaver <mhw@netris.org>, rhelling@mykolab.com
Subject: Re: 01/01: gnu: qemu: Enable Samba support.
Date: Wed, 27 Dec 2017 23:41:31 +0000 [thread overview]
Message-ID: <159BE99C-4CFD-437B-9768-AF13A5017F55@gmail.com> (raw)
In-Reply-To: <87r2rfn5pc.fsf@netris.org>
Hello,
On December 27, 2017 5:53:19 PM EST, Mark H Weaver <mhw@netris.org> wrote:
>Hi,
>
>rhelling@mykolab.com (Rutger Helling) writes:
>
>> rhelling pushed a commit to branch master
>> in repository guix.
>>
>> commit 84276503059d46c0a42240f8770f59090614d863
>> Author: Rutger Helling <rhelling@mykolab.com>
>> Date: Wed Dec 27 10:09:26 2017 +0100
>>
>> gnu: qemu: Enable Samba support.
>>
>> * gnu/packages/virtualization.scm (qemu)[arguments]: Change
>#:configure-flags to
>> a list, add --smbd flag.
>> [inputs]: Add samba.
>
>I see that you have since reverted this commit, but I still thought I'd
>mention that when adding optional features to 'qemu', it would be good
>to remove them from 'qemu-minimal', which inherits from 'qemu'.
Maybe this relationship could be turned around? It seems like it'd make more sense.
Maxim
next prev parent reply other threads:[~2017-12-27 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171227092649.22335.79799@vcs0.savannah.gnu.org>
[not found] ` <20171227092650.69D7B204F7@vcs0.savannah.gnu.org>
2017-12-27 12:04 ` 01/01: gnu: qemu: Enable Samba support Ludovic Courtès
2017-12-27 13:23 ` Rutger Helling
2017-12-27 20:59 ` Rutger Helling
2017-12-27 22:53 ` Mark H Weaver
2017-12-27 22:56 ` Rutger Helling
2017-12-27 23:41 ` Maxim Cournoyer [this message]
2017-12-28 5:46 ` Rutger Helling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159BE99C-4CFD-437B-9768-AF13A5017F55@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).