From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Meyer Subject: Re: [PATCH] Add Krita to guix Date: Tue, 05 Dec 2017 13:00:19 +0100 Message-ID: <1512475219.805972.1194551712.0632CCB9@webmail.messagingengine.com> References: <1512437175.2661671.1194096888.02FE8D35@webmail.messagingengine.com> <20171205113015.1fd6dcce@scratchpost.org> <1512470002.783113.1194476320.28F161EA@webmail.messagingengine.com> <20171205103935.GF19582@macbook41> <1512475079.805533.1194549768.0033E2E2@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMBth-0005G9-B2 for guix-devel@gnu.org; Tue, 05 Dec 2017 07:00:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMBtc-0001vd-Kd for guix-devel@gnu.org; Tue, 05 Dec 2017 07:00:25 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54269) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMBtc-0001vS-5A for guix-devel@gnu.org; Tue, 05 Dec 2017 07:00:20 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B22FF20DFF for ; Tue, 5 Dec 2017 07:00:19 -0500 (EST) In-Reply-To: <1512475079.805533.1194549768.0033E2E2@webmail.messagingengine.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org But in theory it should work with QT_QPA_PLATFORM, this only yields a comparatively small number of failed test in my run, likey 20-30 out of ~200. Cheers, Mark On Tue, Dec 5, 2017, at 12:57, Mark Meyer wrote: > I tried enabling test, but sometimes it's easiest to just ask, from the > Krita IRC channel: >=20 > 12:49 < ofosos> hey, I'm trying to package Krita for Guix and I'm > getting a lot=20 > errors, when I activate the check phase of the build. > Are these=20 > tests supposed to pass in a release tarball? I have to > add that=20 > I set "QT_QPA_PLATFORM" "offscreen" to facilitate tests > running=20 > at all > 12:50 -!- salamanderrake > [~quassel@2605:a000:122a:32:89c6:d481:6fca:1d06] has=20 > quit [Remote host closed the connection] > 12:52 -!- NullConstant [~quassel@5.172.232.196] has joined #krita > 12:55 < scottyp_mobile> a lot of unit tests fail in general right now. > no one=20 > has had time to maintain those ofosos=20 > 12:55 < ofosos> scottyp_mobile: is this true of the release tarballs? > then I=20 > would simply disable the check phase > 12:56 < scottyp_mobile> this is just true in general > 12:56 < scottyp_mobile> you could try to disable them >=20 > Looks like tests won't work anyways. So the patch can't be improved in > this regard. >=20 > Cheers, Mark >=20 > On Tue, Dec 5, 2017, at 11:39, Efraim Flashner wrote: > > On Tue, Dec 05, 2017 at 11:33:22AM +0100, Mark Meyer wrote: > > > On Tue, Dec 5, 2017, at 11:30, Danny Milosavljevic wrote: > > > > Hi, > > > >=20 > > > > On Tue, 05 Dec 2017 02:26:15 +0100 > > > > Mark Meyer wrote: > > > >=20 > > > > > I disabled all tests, since these required an X11 display to be p= resent. > > > >=20 > > > > Does (setenv "QT_QPA_PLATFORM" "offscreen") help? > > > >=20 > > > > If not, then it's possible to start an X server (Xvfb) in the conta= iner, > > > > something like "/bin/Xvfb :1 -screen 0 640x480x24 &". > > >=20 > > >=20 > > > Disabling the tests worked for me, and this also brings down the comp= ile > > > time, which is already in excess of 1h on my system. > > >=20 > >=20 > > We still prefer to run all the tests as possible, or at least all the > > tests which don't require network access. Since there are no packages > > which depend on krita we have no way of testing the package without > > using it if we don't run the test suite. > >=20 > > --=20 > > Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > > Confidentiality cannot be guaranteed on emails sent or received > > unencrypted > > Email had 1 attachment: > > + signature.asc > > 1k (application/pgp-signature) >=20 >=20 > --=20 > Mark Meyer > mark@ofosos.org >=20 --=20 Mark Meyer mark@ofosos.org