From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH] gnu: Add praat Date: Wed, 31 Aug 2016 11:08:34 -0500 Message-ID: <1472659714.2040308.711705529.7C6A31A2@webmail.messagingengine.com> References: <87bn0ayt1e.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf84K-0002vH-Ql for guix-devel@gnu.org; Wed, 31 Aug 2016 12:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bf84E-0005SC-So for guix-devel@gnu.org; Wed, 31 Aug 2016 12:08:51 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf84C-0005Q7-GO for guix-devel@gnu.org; Wed, 31 Aug 2016 12:08:46 -0400 In-Reply-To: <87bn0ayt1e.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke , Brendan Tildesley , guix-devel@gnu.org On Tue, Aug 30, 2016, at 02:07 PM, Marius Bakke wrote: > I don't have a Guix system with audio atm so someone else will have to > review it :) It works for me on GuixSD OOTB. Brendan Tildesley wrote: > + (home-page "http://praat.org") The docs point to "http://www.praat.org", so I think we should include the www. > + (synopsis "Doing phonetics by computer") > + (description > + "Praat is a program for linguists to analyse, synthesize, and > +manipulate speech, generate graphs for scientific papers, and more.") I know it's Praat's tagline, but the synopsis doesn't match the rest of our packages. Something like "Phonetic analysis program" would be better. The description could probably be a bit more fleshed out too, but I think it's also fine if you don't want to bother. > + (license license:gpl2))) This should be gpl2+. It looks like praat bundles some third-party libraries under external/ with various licenses. These should be unbundled if possible, or else their licenses should be added to praat's license field. Thanks for contributing, hope it's not too much trouble cleaning up these last few details! -- Alex Griffin