From mboxrd@z Thu Jan  1 00:00:00 1970
From: Troy Sankey <sankeytms@gmail.com>
Subject: Re: [PATCH] update notmuch and python bindings
Date: Mon, 08 Aug 2016 09:31:14 -0400
Message-ID: <147066307440.16312.9231740551431440860@what>
References: <147059611699.9624.567002638658964680@what>
	<87zioofc92.fsf@we.make.ritual.n0.is>
	<147063086382.16312.14483597599827932971@what>
	<87lh072111.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sankeytms@gmail.com>) id 1bWkeI-0005b1-6B
	for guix-devel@gnu.org; Mon, 08 Aug 2016 09:31:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sankeytms@gmail.com>) id 1bWkeD-00053J-7U
	for guix-devel@gnu.org; Mon, 08 Aug 2016 09:31:22 -0400
Received: from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242]:36522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sankeytms@gmail.com>) id 1bWkeD-00052Z-2Q
	for guix-devel@gnu.org; Mon, 08 Aug 2016 09:31:17 -0400
Received: by mail-io0-x242.google.com with SMTP id y34so28727838ioi.3
	for <guix-devel@gnu.org>; Mon, 08 Aug 2016 06:31:16 -0700 (PDT)
In-Reply-To: <87lh072111.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org

Quoting ng0 (2016-08-08 03:05:46)
> > -     '(#:tests? #f ;; FIXME: 662 tests; 168 fail and 99 are skipped
> > -                   ;; with perl input: 50 fail and 99 are skipped
> > +     '(#:tests? #f ; FIXME: 694 tests; 170 fail and 100 are skipped
> > +                   ; with perl input: 50 fail and 100 are skipped
>
> I think this comment should not be updated in your patch, like I wrote
> before someone should update the comment when either the whole file is
> addressed in stylistic fixes or when the tests are changed from false to
> true or something test related is changed. Your version bump does not do
> this.

This also changes the numbers.  I assume these failing tests won't be
fixed in the immediate term, so I figured it would be best to at least
keep the comment accurate.

Troy