From: Troy Sankey <sankeytms@gmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH] update notmuch and python bindings
Date: Mon, 08 Aug 2016 09:31:14 -0400 [thread overview]
Message-ID: <147066307440.16312.9231740551431440860@what> (raw)
In-Reply-To: <87lh072111.fsf@we.make.ritual.n0.is>
Quoting ng0 (2016-08-08 03:05:46)
> > - '(#:tests? #f ;; FIXME: 662 tests; 168 fail and 99 are skipped
> > - ;; with perl input: 50 fail and 99 are skipped
> > + '(#:tests? #f ; FIXME: 694 tests; 170 fail and 100 are skipped
> > + ; with perl input: 50 fail and 100 are skipped
>
> I think this comment should not be updated in your patch, like I wrote
> before someone should update the comment when either the whole file is
> addressed in stylistic fixes or when the tests are changed from false to
> true or something test related is changed. Your version bump does not do
> this.
This also changes the numbers. I assume these failing tests won't be
fixed in the immediate term, so I figured it would be best to at least
keep the comment accurate.
Troy
next prev parent reply other threads:[~2016-08-08 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 18:55 [PATCH] update notmuch and python bindings Troy Sankey
2016-08-07 19:29 ` ng0
2016-08-07 20:40 ` Troy Sankey
2016-08-07 22:04 ` ng0
2016-08-08 8:20 ` Alex Kost
2016-08-07 22:24 ` ng0
2016-08-08 4:34 ` Troy Sankey
2016-08-08 7:05 ` ng0
2016-08-08 7:42 ` ng0
2016-08-08 13:31 ` Troy Sankey [this message]
2016-08-08 8:21 ` Alex Kost
2016-08-11 15:18 ` Alex Kost
2016-08-08 21:30 ` Leo Famulari
2016-08-08 8:35 ` Alex Kost
2016-08-08 15:07 ` Troy Sankey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147066307440.16312.9231740551431440860@what \
--to=sankeytms@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).