From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH] add go@1.6 Date: Wed, 27 Jul 2016 20:00:55 -0500 Message-ID: <1469667655.4000333.678845385.2261EF5D@webmail.messagingengine.com> References: <87d1lyzlga.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSZhI-0007Dw-1m for guix-devel@gnu.org; Wed, 27 Jul 2016 21:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSZhD-0003XW-Uk for guix-devel@gnu.org; Wed, 27 Jul 2016 21:01:11 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSZhB-0003TO-Iq for guix-devel@gnu.org; Wed, 27 Jul 2016 21:01:07 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DEE2F2056A for ; Wed, 27 Jul 2016 21:00:55 -0400 (EDT) In-Reply-To: <87d1lyzlga.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Hello Matthew, I'm not done looking at the package, but here are some of my initial thoughts: On Wed, Jul 27, 2016, at 06:54 PM, Matthew Jordan wrote: > (version "1.6.2") Version 1.6.3 was just released to fix a security issue. > (zero? (system* "sh" "all.bash"))))) This seems to work, but I think it should just be `(zero? (system* "./all.bash"))`. It has a shebang, and expects bash, not sh. If it doesn't cause any problems, we should delete pkg/bootstrap/* so that it doesn't retain any references to go@1.4. I think that would drastically reduce the size of its closure. Also, I'm not sure I'm sold on splitting up into multiple outputs, but I haven't thought about it much and don't have a strong opinion. The "tests" output is only 5M and "doc" is only 10M, vs 270M for the default output. -- Alex Griffin