From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH] gnu: Add reptyr. Date: Tue, 12 Jul 2016 15:17:29 -0500 Message-ID: <1468354649.943816.664381969.64789E72@webmail.messagingengine.com> References: <1468006716.1010694.660917729.687C408B@webmail.messagingengine.com> <20160709182035.GB2010@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_14683546499438160"; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN47i-0004MY-F1 for guix-devel@gnu.org; Tue, 12 Jul 2016 16:17:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN47d-00009G-Hd for guix-devel@gnu.org; Tue, 12 Jul 2016 16:17:41 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN47b-00008k-3F for guix-devel@gnu.org; Tue, 12 Jul 2016 16:17:37 -0400 In-Reply-To: <20160709182035.GB2010@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --_----------=_14683546499438160 Content-Transfer-Encoding: 7bit Content-Type: text/plain On Sat, Jul 9, 2016, at 01:20 PM, Leo Famulari wrote: > If we are considering moving these packages around, I think that > screen.scm and tmux.scm should go into terminals.scm. But, I also think > that this patch should not be held up by that discussion. Yes, I didn't necessarily mean just moving tmux into screen.scm. I just meant that they clearly belong next to each other, wherever that is. > Why skip the tests? We prefer to run tests whenever possible. Otherwise, > please add a comment explaining why. For example "No test suite." There's no tests to run. I added a comment on it. > This is short and sweet, but we like to use modify-phases for > consistency. Okay, done. (btw a bunch of packages in suckless.scm do it that way, which is where I copied the arguments field from) > We should capitalize the beginning of the description, and I would also > wrap 'ssh' and 'screen' in texinfo: > > @code{ssh} > @code{screen} I wrapped those commands in texinfo, but I don't think that reptyr should be capitalized even at the beginning of a sentence. Upstream always seems to keep it lower case, and other package descriptions do it this way too (like dtach). I included the updated patch as an attachment. Thanks for the feedback, -- Alex Griffin --_----------=_14683546499438160 Content-Disposition: attachment; filename="0001-gnu-Add-reptyr.patch" Content-Id: <1468350865.928906.957e5eac4ccc0397cb42dbcc5a89ff52e08276c8.575652EC@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-reptyr.patch" RnJvbSAyOWI5YWVjMDRiYjNkNzUwOTIyNjYxYmYwMzYwNzYyZTM5ZjA0Njk0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IEdyaWZmaW4g PGFAYWpncmYuY29tPgpEYXRlOiBGcmksIDggSnVsIDIwMTYgMTQ6Mjc6MzIg LTA1MDAKU3ViamVjdDogW1BBVENIIDEvMl0gZ251OiBBZGQgcmVwdHlyLgoK KiBnbnUvcGFja2FnZXMvc2NyZWVuLnNjbSAocmVwdHlyKTogTmV3IHZhcmlh YmxlLgotLS0KIGdudS9wYWNrYWdlcy9zY3JlZW4uc2NtIHwgMjggKysrKysr KysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI4IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvc2NyZWVu LnNjbSBiL2dudS9wYWNrYWdlcy9zY3JlZW4uc2NtCmluZGV4IGE0ZWVmZDgu LmMwMzFlMWEgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9zY3JlZW4uc2Nt CisrKyBiL2dudS9wYWNrYWdlcy9zY3JlZW4uc2NtCkBAIC0zLDYgKzMsNyBA QAogOzs7IENvcHlyaWdodCDCqSAyMDE0IE1hcmsgSCBXZWF2ZXIgPG1od0Bu ZXRyaXMub3JnPgogOzs7IENvcHlyaWdodCDCqSAyMDE1IEVyaWMgQmF2aWVy IDxiYXZpZXJAbWVtYmVyLmZzZi5vcmc+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MTYgRWZyYWltIEZsYXNobmVyIDxlZnJhaW1AZmxhc2huZXIuY28uaWw+Cis7 OzsgQ29weXJpZ2h0IMKpIDIwMTYgQWxleCBHcmlmZmluIDxhQGFqZ3JmLmNv bT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4Lgog Ozs7CkBAIC0xNDQsMyArMTQ1LDMwIEBAIGFzIGZvbGRpbmcgcm9vbSBkaXZp ZGVycy4gIFRoZSBCeW9idSBzb2Z0d2FyZSBpbmNsdWRlcyBhbiBlbmhhbmNl ZCBwcm9maWxlLAogY29uZmlndXJhdGlvbiB1dGlsaXRpZXMsIGFuZCBzeXN0 ZW0gc3RhdHVzIG5vdGlmaWNhdGlvbnMgZm9yIHRoZSBHTlUgU2NyZWVuCiB3 aW5kb3cgbWFuYWdlciBhcyB3ZWxsIGFzIHRoZSBUbXV4IHRlcm1pbmFsIG11 bHRpcGxleGVyLiIpCiAgICAgKGxpY2Vuc2UgZ3BsMyspKSkKKworKGRlZmlu ZS1wdWJsaWMgcmVwdHlyCisgIChwYWNrYWdlCisgICAgKG5hbWUgInJlcHR5 ciIpCisgICAgKHZlcnNpb24gIjAuNi4yIikKKyAgICAoc291cmNlCisgICAg IChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAo dXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vbmVsaGFn ZS9yZXB0eXIvYXJjaGl2ZSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICIvcmVwdHlyLSIgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgIChzaGEy NTYKKyAgICAgICAgKGJhc2UzMgorICAgICAgICAgIjA3cGZsMHJrZ204bTNm M2p5OHI5bDJ5dm5oZjhsZ2xscHNrM21oNTdtaHpkeHE4ZmFnZjciKSkpKQor ICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJn dW1lbnRzCisgICAgICcoIzp0ZXN0cz8gI2YgOyBubyB0ZXN0cworICAgICAg ICM6bWFrZS1mbGFncyAobGlzdCAiQ0M9Z2NjIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiUFJFRklYPSIgJW91dHB1dCkp CisgICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBo YXNlcyAoZGVsZXRlICdjb25maWd1cmUpKSkpCisgICAgKGhvbWUtcGFnZSAi aHR0cHM6Ly9naXRodWIuY29tL25lbGhhZ2UvcmVwdHlyIikKKyAgICAoc3lu b3BzaXMgIlRvb2wgZm9yIHJlcGFyZW50aW5nIGEgcnVubmluZyBwcm9ncmFt IHRvIGEgbmV3IHRlcm1pbmFsIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAg InJlcHR5ciBpcyBhIHV0aWxpdHkgZm9yIHRha2luZyBhbiBleGlzdGluZyBy dW5uaW5nIHByb2dyYW0gYW5kIGF0dGFjaGluZworaXQgdG8gYSBuZXcgdGVy bWluYWwuICBTdGFydGVkIGEgbG9uZy1ydW5uaW5nIHByb2Nlc3Mgb3ZlciBA Y29kZXtzc2h9LCBidXQgaGF2ZQordG8gbGVhdmUgYW5kIGRvbid0IHdhbnQg dG8gaW50ZXJydXB0IGl0PyAgSnVzdCBzdGFydCBhIEBjb2Rle3NjcmVlbn0s IHVzZQorcmVwdHlyIHRvIGdyYWIgaXQsIGFuZCB0aGVuIGtpbGwgdGhlIHNz aCBzZXNzaW9uIGFuZCBoZWFkIG9uIGhvbWUuIikKKyAgICAobGljZW5zZSBl eHBhdCkpKQotLSAKMi45LjAKCg== --_----------=_14683546499438160--