From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv. Date: Thu, 07 Jul 2016 09:39:48 -0500 Message-ID: <1467902388.677813.659579777.62341118@webmail.messagingengine.com> References: <1467849895.1613559.659003001.5BC78E49@webmail.messagingengine.com> <87k2gxzzxt.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_14679023886778130"; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLATC-0008Mu-Es for guix-devel@gnu.org; Thu, 07 Jul 2016 10:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLAT9-00056S-AB for guix-devel@gnu.org; Thu, 07 Jul 2016 10:40:02 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLAT6-00055c-R7 for guix-devel@gnu.org; Thu, 07 Jul 2016 10:39:59 -0400 In-Reply-To: <87k2gxzzxt.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --_----------=_14679023886778130 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote: > > + (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/rel= eases/download/v" > > + version "/gnome-mpv-" version ".tar.xz")) >=20 > This line looks a bit long to me. Have you checked with =E2=80=9Cguix li= nt > gnome-mpv=E2=80=9D? Actually, yes I did, and it didn't catch it. Maybe there's a bug in the linter? Anyway, here's an updated patch. In addition to correcting the long line, I also tweaked the synopsis and description to make clear that this is a media player, for the benefit of anyone who hasn't heard of mpv. --=20 Alex Griffin --_----------=_14679023886778130 Content-Disposition: attachment; filename="0002-gnu-Add-gnome-mpv.patch" Content-Id: <1467902119.676995.7d6717719dec795b9e07323a7dc5376beefbb9bf.140E8BA3@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-gnu-Add-gnome-mpv.patch" RnJvbSBlM2Y0MDY3M2I2ODgzYmJhMDIzZWVjOWViODk5NWRmOTdkOTI0NWZk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IEdyaWZmaW4g PGFAYWpncmYuY29tPgpEYXRlOiBXZWQsIDYgSnVsIDIwMTYgMTg6NTg6MTcg LTA1MDAKU3ViamVjdDogW1BBVENIIDIvMl0gZ251OiBBZGQgZ25vbWUtbXB2 LgoKKiBnbnUvcGFja2FnZXMvdmlkZW8uc2NtIChnbm9tZS1tcHYpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3ZpZGVvLnNjbSB8IDI5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg MjkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy92 aWRlby5zY20gYi9nbnUvcGFja2FnZXMvdmlkZW8uc2NtCmluZGV4IGFlMTgx M2QuLjY4ODhlMzYgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy92aWRlby5z Y20KKysrIGIvZ251L3BhY2thZ2VzL3ZpZGVvLnNjbQpAQCAtMzMsNiArMzMs NyBAQAogICAjOnVzZS1tb2R1bGUgKGd1aXggZ2l0LWRvd25sb2FkKQogICAj OnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGNtYWtlKQogICAjOnVz ZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGdudSkKKyAgIzp1c2UtbW9k dWxlIChndWl4IGJ1aWxkLXN5c3RlbSBnbGliLW9yLWd0aykKICAgIzp1c2Ut bW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBweXRob24pCiAgICM6dXNlLW1v ZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gd2FmKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcykKQEAgLTgyOSw2ICs4MzAsMzQgQEAgZm9yayBvZiBt cGxheWVyMiBhbmQgTVBsYXllci4gIEl0IHNoYXJlcyBzb21lIGZlYXR1cmVz IHdpdGggdGhlIGZvcm1lcgogcHJvamVjdHMgd2hpbGUgaW50cm9kdWNpbmcg bWFueSBtb3JlLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykpKQog CisoZGVmaW5lLXB1YmxpYyBnbm9tZS1tcHYKKyAgKHBhY2thZ2UKKyAgICAo bmFtZSAiZ25vbWUtbXB2IikKKyAgICAodmVyc2lvbiAiMC45IikKKyAgICAo c291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRj aCkKKyAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdGh1 Yi5jb20vZ25vbWUtbXB2L2dub21lLW1wdi9yZWxlYXNlcyIKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICIvZG93bmxvYWQvdiIgdmVyc2lvbiAiL2du b21lLW1wdi0iIHZlcnNpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICIudGFyLnh6IikpCisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMy CisgICAgICAgICAiMDZwZ3hsNmYza2tneHY4bmxteWw3Z3kzcGc1NXNxZjh2 Z3I4bTY0MjZtbHBtNHAzcWRuMCIpKSkpCisgICAgKG5hdGl2ZS1pbnB1dHMK KyAgICAgYCgoImludGx0b29sIiAsaW50bHRvb2wpCisgICAgICAgKCJwa2ct Y29uZmlnIiAscGtnLWNvbmZpZykpKQorICAgIChpbnB1dHMKKyAgICAgYCgo Imd0aysiICxndGsrKQorICAgICAgICgibGliZXBveHkiICxsaWJlcG94eSkK KyAgICAgICAoIm1wdiIgLG1wdikpKQorICAgIChidWlsZC1zeXN0ZW0gZ2xp Yi1vci1ndGstYnVpbGQtc3lzdGVtKQorICAgIChob21lLXBhZ2UgImh0dHBz Oi8vZ2l0aHViLmNvbS9nbm9tZS1tcHYvZ25vbWUtbXB2IikKKyAgICAoc3lu b3BzaXMgIkdUSysgZnJvbnRlbmQgZm9yIHRoZSBtcHYgbWVkaWEgcGxheWVy IikKKyAgICAoZGVzY3JpcHRpb24gIkdOT01FIE1QViBpcyBhIHNpbXBsZSBH VEsrIGZyb250ZW5kIGZvciB0aGUgbXB2IG1lZGlhIHBsYXllci4KK0dOT01F IE1QViBpbnRlcmFjdHMgd2l0aCBtcHYgdmlhIHRoZSBjbGllbnQgQVBJIGV4 cG9ydGVkIGJ5IGxpYm1wdiwgYWxsb3dpbmcKK2FjY2VzcyB0byBtcHYncyBw b3dlcmZ1bCBwbGF5YmFjayBjYXBhYmlsaXRpZXMuIikKKyAgICAobGljZW5z ZSBsaWNlbnNlOmdwbDMrKSkpCisKIChkZWZpbmUtcHVibGljIGxpYnZweAog ICAocGFja2FnZQogICAgIChuYW1lICJsaWJ2cHgiKQotLSAKMi45LjAKCg== --_----------=_14679023886778130--