From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Sankey Subject: Re: [PATCH] gnu: Add alot and python-urwidtrees Date: Sat, 02 Jul 2016 14:43:44 -0400 Message-ID: <1467482402-sup-3704@what> References: <1467396878-sup-4584@what> <20160701215050.GA4187@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-1467485024-598196-22442-7379-7-=" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJPtR-000898-15 for guix-devel@gnu.org; Sat, 02 Jul 2016 14:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJPtL-00031G-4O for guix-devel@gnu.org; Sat, 02 Jul 2016 14:43:52 -0400 Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]:34278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJPtK-00031C-Uu for guix-devel@gnu.org; Sat, 02 Jul 2016 14:43:47 -0400 Received: by mail-qt0-x22b.google.com with SMTP id m2so72300029qtd.1 for ; Sat, 02 Jul 2016 11:43:46 -0700 (PDT) Received: from localhost (c-98-217-8-51.hsd1.ma.comcast.net. [98.217.8.51]) by smtp.gmail.com with ESMTPSA id e41sm1925379qta.37.2016.07.02.11.43.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jul 2016 11:43:45 -0700 (PDT) In-reply-to: <20160701215050.GA4187@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel --=-1467485024-598196-22442-7379-7-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On 2016-07-01 17:50:50 -0400, Leo Famulari wrote: > Thanks for this patch! Thanks for pointing out all my mistakes! :) > > +(define-public alot > > > + (uri (string-append "https://github.com/pazz/alot/archive/" > > + version ".tar.gz")) > > When possible, we prefer to use PyPi for downloading Python source code. > But in this case, I don't see version 0.3.7 on PyPi, so we'll use > GitHub. Maybe I'll poke the devs about this. > > + (synopsis "Commandline MUA using notmuch and urwid") > > How about "Command-line mail client using @code{notmuch} and > @code{urwid}"? I'm not sure if the synopses support texinfo markup, > while I know the descriptions do. $ guix package --show=alot | grep synopsis synopsis: Commandline MUA using @code{notmuch} and @code{urwid} I guess no markup support in the synopsis, I'll just trim it down to: "Commandline MUA using notmuch" It uses python-urwid inasmuch as it uses python-twisted, but it's (to me) primarily known for its usage of the notmuch mail indexing system and for being written in python. I'll poke the devs and come back with a new patch if necessary. > > + (description > > + "Alot is an experimental terminal MUA based on notmuch mail. It is > > +written in python using the urwid toolkit.") > > Can you unpack 'MUA' and wrap notmuch and urwid in texinfo as above? Still including the 'MUA' abbreviation because I think it is common enough. Some linting: $ EVERYTHING_EXCEPT_CVE=description,gnu-description,inputs-should-be-native,patch-file-names,home-page,license,source,source-file-name,derivation,synopsis,formatting $ guix lint -c $EVERYTHING_EXCEPT_CVE alot python{2,}-urwidtrees $ echo $? 0 (CVE checker takes too long, I'm using slow wifi from a café) Finally, I'll say that I do use it, and it does build and work correctly. Troy --=-1467485024-598196-22442-7379-7-= Content-Disposition: attachment; filename="0001-gnu-Add-python-urwidtrees.patch" Content-Type: application/octet-stream; name="0001-gnu-Add-python-urwidtrees.patch" Content-Transfer-Encoding: base64 RnJvbSBhMjQ4MGQ0NDcwNjU2MDdjZTAyNmFlMjM3NTY0YWJmZWMxMmEyNmVk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IFNhbmtleSA8 c2Fua2V5dG1zQGdtYWlsLmNvbT4KRGF0ZTogU2F0LCAyIEp1bCAyMDE2IDE0 OjI3OjQxIC0wNDAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIGdudTogQWRkIHB5 dGhvbi11cndpZHRyZWVzCgotLS0KIGdudS9wYWNrYWdlcy9weXRob24uc2Nt IHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFu Z2VkLCAyNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2th Z2VzL3B5dGhvbi5zY20gYi9nbnUvcGFja2FnZXMvcHl0aG9uLnNjbQppbmRl eCA2ODRjMzcyLi4yN2M2NTE1IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMv cHl0aG9uLnNjbQorKysgYi9nbnUvcGFja2FnZXMvcHl0aG9uLnNjbQpAQCAt MjIsNiArMjIsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDE2IEhhcnRtdXQg R29lYmVsIDxoLmdvZWJlbEBjcmF6eS1jb21waWxlcnMuY29tPgogOzs7IENv cHlyaWdodCDCqSAyMDE2IERhbmllbCBQaW1lbnRlbCA8ZDRuMUBkNG4xLm9y Zz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBTb3UgQnVubmJ1IDxpeXpzb25n QGdtYWlsLmNvbT4KKzs7OyBDb3B5cmlnaHQgwqkgMjAxNiBUcm95IFNhbmtl eSA8c2Fua2V5dG1zQGdtYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBp cyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC00NDg4LDYgKzQ0ODksMzEg QEAgZmVhdHVyZXMgdXNlZnVsIGZvciB0ZXh0IGNvbnNvbGUgYXBwbGljYXRp b25zLiIpCiAoZGVmaW5lLXB1YmxpYyBweXRob24yLXVyd2lkCiAgIChwYWNr YWdlLXdpdGgtcHl0aG9uMiBweXRob24tdXJ3aWQpKQogCisoZGVmaW5lLXB1 YmxpYyBweXRob24tdXJ3aWR0cmVlcworICAocGFja2FnZQorICAgIChuYW1l ICJweXRob24tdXJ3aWR0cmVlcyIpCisgICAgKHZlcnNpb24gIjEuMC4xLjEi KQorICAgIChzb3VyY2UKKyAgICAgIChvcmlnaW4KKyAgICAgICAgKG1ldGhv ZCB1cmwtZmV0Y2gpCisgICAgICAgICh1cmkgKHB5cGktdXJpICJ1cndpZHRy ZWVzIiB2ZXJzaW9uKSkKKyAgICAgICAgKHNoYTI1NgorICAgICAgICAgIChi YXNlMzIKKyAgICAgICAgICAgICIxemN2eTEyczdoM2ZhemYzM2Q2eTdiNHYx OXA4aGc5NXhxd2hxbG13Nmp6OWZxNzZ2OWg4IikpKSkKKyAgICAoYnVpbGQt c3lzdGVtIHB5dGhvbi1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cwor ICAgICAnKCM6dGVzdHM/ICNmKSkgOyBubyB0ZXN0cworICAgIChuYXRpdmUt aW5wdXRzIGAoKCJweXRob24tc2V0dXB0b29scyIgLHB5dGhvbi1zZXR1cHRv b2xzKSkpCisgICAgKGlucHV0cyBgKCgicHl0aG9uLXVyd2lkIiAscHl0aG9u LXVyd2lkKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29t L3BhenovdXJ3aWR0cmVlcyIpCisgICAgKHN5bm9wc2lzICJUcmVlIHdpZGdl dHMgZm9yIHVyd2lkIikKKyAgICAoZGVzY3JpcHRpb24gIlVyd2lkdHJlZXMg aXMgYSBXaWRnZXQgQ29udGFpbmVyIEFQSSBmb3IgdGhlIEBjb2Rle3Vyd2lk fQordG9vbGtpdC4gIFVzZSBpdCB0byBidWlsZCB0cmVlcyBvZiB3aWRnZXRz LiIpCisgICAgKGxpY2Vuc2UgZ3BsMyspKSkKKworKGRlZmluZS1wdWJsaWMg cHl0aG9uMi11cndpZHRyZWVzCisgIChwYWNrYWdlLXdpdGgtcHl0aG9uMiBw eXRob24tdXJ3aWR0cmVlcykpCisKIChkZWZpbmUtcHVibGljIHB5dGhvbi1k YnVzCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgInB5dGhvbi1kYnVzIikKLS0g CjIuMS40Cgo= --=-1467485024-598196-22442-7379-7-= Content-Disposition: attachment; filename="0002-gnu-Add-alot.patch" Content-Type: application/octet-stream; name="0002-gnu-Add-alot.patch" Content-Transfer-Encoding: base64 RnJvbSBiZWFjZjI4YmYyNzY2NmZiNGExZTEzY2M5NTY3YTMyZDIyNzc3OWIy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IFNhbmtleSA8 c2Fua2V5dG1zQGdtYWlsLmNvbT4KRGF0ZTogU2F0LCAyIEp1bCAyMDE2IDE0 OjI4OjM1IC0wNDAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGdudTogQWRkIGFs b3QKCi0tLQogZ251L3BhY2thZ2VzL21haWwuc2NtIHwgMzUgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAz NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL21h aWwuc2NtIGIvZ251L3BhY2thZ2VzL21haWwuc2NtCmluZGV4IGMzYmFhNzIu LjQ0ZTdlZjAgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tYWlsLnNjbQor KysgYi9nbnUvcGFja2FnZXMvbWFpbC5zY20KQEAgLTE0LDYgKzE0LDcgQEAK IDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBMZW8gRmFtdWxhcmkgPGxlb0BmYW11 bGFyaS5uYW1lPgogOzs7IENvcHlyaWdodCDCqSAyMDE2IEx1a2FzIEdyYWRs IDxsZ3JhZGxAb3Blbm1haWxib3gub3JnPgogOzs7IENvcHlyaWdodCDCqSAy MDE2IEFsZXggS29zdCA8YWxlem9zdEBnbWFpbC5jb20+Cis7OzsgQ29weXJp Z2h0IMKpIDIwMTYgVHJveSBTYW5rZXkgPHNhbmtleXRtc0BnbWFpbC5jb20+ CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7 OwpAQCAtMzk3LDYgKzM5OCw0MCBAQCBtZXNzYWdlcyB5b3UgbmVlZDsgaW4g YWRkaXRpb24sIGl0IGFsbG93cyB5b3UgdG8gdmlldyBtZXNzYWdlcywgZXh0 cmFjdAogYXR0YWNobWVudHMsIGNyZWF0ZSBuZXcgbWFpbGRpcnMsIGFuZCBz byBvbi4iKQogICAgIChsaWNlbnNlIGdwbDMrKSkpCiAKKyhkZWZpbmUtcHVi bGljIGFsb3QKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAiYWxvdCIpCisgICAg KHZlcnNpb24gIjAuMy43IikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAg ICAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAgICAgICAgICAgIDsg djAuMy43IG5vdCBvbiBQeVBpIHlldCwgc28gdXNlIGdpdGh1YiBpbnN0ZWFk CisgICAgICAgICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHBzOi8v Z2l0aHViLmNvbS9wYXp6L2Fsb3QvYXJjaGl2ZS8iCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAg ICAgICAgICAgICAoZmlsZS1uYW1lIChzdHJpbmctYXBwZW5kICJhbG90LSIg dmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgICAgICAgICAoc2hhMjU2Cisg ICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjA5bWQ5 bGxnMzhyNnhieThsMHkwemY4bmhsaDkxY3I0eHMwcjE1YjI5NGhocDhobDJi Z3giKSkpKQorICAgIChidWlsZC1zeXN0ZW0gcHl0aG9uLWJ1aWxkLXN5c3Rl bSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzp0ZXN0cz8gI2YgOyBubyB0 ZXN0cworICAgICAgIDsgcHl0aG9uIDMgaXMgdW5zdXBwb3J0ZWQsIG1vcmUg aW5mbzoKKyAgICAgICA7IGh0dHBzOi8vZ2l0aHViLmNvbS9wYXp6L2Fsb3Qv YmxvYi8wLjMuNy9kb2NzL3NvdXJjZS9mYXEucnN0CisgICAgICAgIzpweXRo b24gLHB5dGhvbi0yKSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJweXRob24y LW1hZ2ljIiAscHl0aG9uMi1tYWdpYykKKyAgICAgICAoInB5dGhvbjItY29u Zmlnb2JqIiAscHl0aG9uMi1jb25maWdvYmopCisgICAgICAgKCJweXRob24y LXR3aXN0ZWQiICxweXRob24yLXR3aXN0ZWQpCisgICAgICAgKCJweXRob24y LXVyd2lkIiAscHl0aG9uMi11cndpZCkKKyAgICAgICAoInB5dGhvbjItdXJ3 aWR0cmVlcyIgLHB5dGhvbjItdXJ3aWR0cmVlcykKKyAgICAgICAoInB5dGhv bjItcHlncGdtZSIgLHB5dGhvbjItcHlncGdtZSkKKyAgICAgICAoInB5dGhv bjItbm90bXVjaCIgLHB5dGhvbjItbm90bXVjaCkpKQorICAgIChob21lLXBh Z2UgImh0dHBzOi8vZ2l0aHViLmNvbS9wYXp6L2Fsb3QiKQorICAgIChzeW5v cHNpcyAiQ29tbWFuZGxpbmUgTVVBIHVzaW5nIG5vdG11Y2giKQorICAgIChk ZXNjcmlwdGlvbgorICAgICAiQWxvdCBpcyBhbiBleHBlcmltZW50YWwgdGVy bWluYWwgbWFpbCB1c2VyIGFnZW50IChNVUEpIGJhc2VkIG9uCitAY29kZXtu b3RtdWNofSBtYWlsLiAgSXQgaXMgd3JpdHRlbiBpbiBweXRob24gdXNpbmcg dGhlIEBjb2Rle3Vyd2lkfSB0b29sa2l0LiIpCisgICAgKGxpY2Vuc2UgZ3Bs MyspKSkKKwogKGRlZmluZS1wdWJsaWMgbm90bXVjaAogICAocGFja2FnZQog ICAgIChuYW1lICJub3RtdWNoIikKLS0gCjIuMS40Cgo= --=-1467485024-598196-22442-7379-7-=--