From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH 2/3] gnu: Add ledger. Date: Sat, 07 May 2016 21:10:48 -0500 Message-ID: <1462673448.1215366.601202601.6F8B62D7@webmail.messagingengine.com> References: <1462646320.1130194.601019473.51C9DD36@webmail.messagingengine.com> <1462648816.1139014.601038209.3A886EEC@webmail.messagingengine.com> <20160507222330.GA16592@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_146267344812153660"; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azEBQ-0000tt-UE for guix-devel@gnu.org; Sat, 07 May 2016 22:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azEBN-0002h2-Q2 for guix-devel@gnu.org; Sat, 07 May 2016 22:10:59 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:49186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azEBL-0002eW-Dj for guix-devel@gnu.org; Sat, 07 May 2016 22:10:57 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7A857203DE for ; Sat, 7 May 2016 22:10:48 -0400 (EDT) In-Reply-To: <20160507222330.GA16592@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --_----------=_146267344812153660 Content-Transfer-Encoding: 7bit Content-Type: text/plain On Sat, May 7, 2016, at 05:23 PM, Leo Famulari wrote: > It works, at least for the basic things I tried against the examples in > 'tests/input'. Speaking of which, it would be nice to include an example > in the output, perhaps under 'share/doc/ledger'. Okay, done. > Will you make this line < 80 characters? Done. > What's the story with the library? Are there any programs that use it? Not that I know of, which is why I didn't include it (well, also I couldn't figure out how to tell cmake that I don't want it to put stuff in "$out/lib64"). And Python users will probably prefer beancount to the ledger module. (Beancount is a reimplementation of ledger in Python.) > There are some GPL'd files in 'contrib/', 'lisp/', and 'python/res/' > > The file 'tools/update_copyright_year' has an Expat license. > > And, I think that unless we delete the bundled utfcpp, we are > distributing it through `guix build --source ledger`, so we should > mention its Boost license. Is the license field for the source tarball or the package that actually gets installed? If it's the former, I have to say that's really unintuitive. I was aware of these extra licenses, but none of that code gets installed after you build the package. Note that emacs-ledger-mode uses the same source tarball and I specified its license as GPL2+. Instead of changing the license field in this patch, I added a note about the other files to make it clear that changing the build options may require the license field to change too. I can change it again if that's wrong, but it seems to me that the license field should really be about what gets installed. -- Alex Griffin --_----------=_146267344812153660 Content-Disposition: attachment; filename="0002-gnu-Add-ledger.patch" Content-Id: <1462673445.1215292.5e9bc99cda2655dfcbea775c95c3af91ffd923d5.79ECF730@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-gnu-Add-ledger.patch" RnJvbSBiOTdmODJkYzZiZWQ5NjJmZGM1OWFkNjc0Nzg1Y2I3MTIyODQ2ZjRh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IEdyaWZmaW4g PGFAYWpncmYuY29tPgpEYXRlOiBTYXQsIDcgTWF5IDIwMTYgMTI6MjA6NDcg LTA1MDAKU3ViamVjdDogW1BBVENIIDIvM10gZ251OiBBZGQgbGVkZ2VyLgoK KiBnbnUvcGFja2FnZXMvZmluYW5jZS5zY20gKGxlZGdlcik6IE5ldyB2YXJp YWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvZmluYW5jZS5zY20gfCA3MyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK IDEgZmlsZSBjaGFuZ2VkLCA3MyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZ251L3BhY2thZ2VzL2ZpbmFuY2Uuc2NtIGIvZ251L3BhY2thZ2VzL2Zp bmFuY2Uuc2NtCmluZGV4IGU5NDg3ZDQuLmU1N2RmYWYgMTAwNjQ0Ci0tLSBh L2dudS9wYWNrYWdlcy9maW5hbmNlLnNjbQorKysgYi9nbnUvcGFja2FnZXMv ZmluYW5jZS5zY20KQEAgLTEsNiArMSw3IEBACiA7OzsgR05VIEd1aXggLS0t IEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKIDs7OyBD b3B5cmlnaHQgwqkgMjAxNSBBbmRyZWFzIEVuZ2UgPGFuZHJlYXNAZW5nZS5m cj4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBFZnJhaW0gRmxhc2huZXIgPGVm cmFpbUBmbGFzaG5lci5jby5pbD4KKzs7OyBDb3B5cmlnaHQgwqkgMjAxNiBB bGV4IEdyaWZmaW4gPGFAYWpncmYuY29tPgogOzs7CiA7OzsgVGhpcyBmaWxl IGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTIzLDE0ICsyNCwyMCBA QAogICM6dXNlLW1vZHVsZSAoZ3VpeCBkb3dubG9hZCkKICAjOnVzZS1tb2R1 bGUgKGd1aXggYnVpbGQgdXRpbHMpCiAgIzp1c2UtbW9kdWxlIChndWl4IGJ1 aWxkLXN5c3RlbSBnbnUpCisgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5 c3RlbSBjbWFrZSkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBib29z dCkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBkYXRhYmFzZXMpCisg Izp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ3JvZmYpCisgIzp1c2UtbW9k dWxlIChnbnUgcGFja2FnZXMgbGliZWRpdCkKICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBsaW51eCkKKyAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdl cyBtdWx0aXByZWNpc2lvbikKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdl cyBwa2ctY29uZmlnKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBy b3RvYnVmKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbikK ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBxdCkKKyAjOnVzZS1tb2R1 bGUgKGdudSBwYWNrYWdlcyB0ZXhpbmZvKQogICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHRscykKKyAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB1 bmljb2RlKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHVwbnApKQog CiAoZGVmaW5lLXB1YmxpYyBiaXRjb2luLWNvcmUKQEAgLTgxLDMgKzg4LDY5 IEBAIGNvbGxlY3RpdmVseSBieSB0aGUgbmV0d29yay4gIEJpdGNvaW4gQ29y ZSBpcyB0aGUgcmVmZXJlbmNlIGltcGxlbWVudGF0aW9uCiBvZiB0aGUgYml0 Y29pbiBwcm90b2NvbC4gIFRoaXMgcGFja2FnZSBwcm92aWRlcyB0aGUgQml0 Y29pbiBDb3JlIGNvbW1hbmQKIGxpbmUgY2xpZW50IGFuZCBhIGNsaWVudCBi YXNlZCBvbiBRdC4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkK KworKGRlZmluZS1wdWJsaWMgbGVkZ2VyCisgIChwYWNrYWdlCisgICAgKG5h bWUgImxlZGdlciIpCisgICAgKHZlcnNpb24gIjMuMS4xIikKKyAgICAoc291 cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gp CisgICAgICAgICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHBzOi8v Z2l0aHViLmNvbS9sZWRnZXIvbGVkZ2VyL2FyY2hpdmUvdiIKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJzaW9uCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIi50YXIuZ3oiKSkKKyAgICAgICAg ICAgICAgKGZpbGUtbmFtZSAoc3RyaW5nLWFwcGVuZCBuYW1lICItIiB2ZXJz aW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAg ICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMTJqbHYzZ3Nq aHJqYTI1cTlocndoNzNjZGFjZDJsM2MyeXluOHFuaWphdjltZGhuYnc0aCIp KSkpCisgICAgKGJ1aWxkLXN5c3RlbSBjbWFrZS1idWlsZC1zeXN0ZW0pCisg ICAgOzsgSWYgeW91IGNoYW5nZSB0aGUgYnVpbGQgZmxhZ3MgeW91IG1heSBu ZWVkIHRvIGNoYW5nZSB0aGUgbGljZW5zZSBmaWVsZAorICAgIDs7IHRvbzsg c2VlIGJlbG93LgorICAgIChhcmd1bWVudHMKKyAgICAgYCgjOnBoYXNlcwor ICAgICAgIChtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAg ICAgIChhZGQtYmVmb3JlICdjb25maWd1cmUgJ2luc3RhbGwtZXhhbXBsZXMK KyAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgKGxldCogKChv dXQgKGFzc29jLXJlZiAlb3V0cHV0cyAib3V0IikpCisgICAgICAgICAgICAg ICAgICAgIChleGFtcGxlcyAoc3RyaW5nLWFwcGVuZCBvdXQKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvc2hhcmUv ZG9jL2xlZGdlci9leGFtcGxlcyIpKSkKKyAgICAgICAgICAgICAgIChpbnN0 YWxsLWZpbGUgInRlc3QvaW5wdXQvc2FtcGxlLmRhdCIgZXhhbXBsZXMpCisg ICAgICAgICAgICAgICAoaW5zdGFsbC1maWxlICJ0ZXN0L2lucHV0L2RlbW8u bGVkZ2VyIiBleGFtcGxlcykpKSkKKyAgICAgICAgIChhZGQtYWZ0ZXIgJ2J1 aWxkICdidWlsZC1kb2MKKyAgICAgICAgICAgKGxhbWJkYSBfICh6ZXJvPyAo c3lzdGVtKiAibWFrZSIgImRvYyIpKSkpKQorICAgICAgICM6Y29uZmlndXJl LWZsYWdzCisgICAgICAgYCgiLURCVUlMRF9ET0NTOkJPT0w9T04iCisgICAg ICAgICAiLURCVUlMRF9MSUJSQVJZOkJPT0w9T0ZGIgorICAgICAgICAgLChz dHJpbmctYXBwZW5kICItRFVURkNQUF9JTkNMVURFX0RJUjpQQVRIPSIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtcmVmICVidWlsZC1pbnB1 dHMgInV0ZmNwcCIpCisgICAgICAgICAgICAgICAgICAgICAgICAgIi9pbmNs dWRlIikpKSkKKyAgICAoaW5wdXRzIGAoKCJib29zdCIgLGJvb3N0KQorICAg ICAgICAgICAgICAoImdtcCIgLGdtcCkKKyAgICAgICAgICAgICAgKCJsaWJl ZGl0IiAsbGliZWRpdCkKKyAgICAgICAgICAgICAgKCJtcGZyIiAsbXBmcikK KyAgICAgICAgICAgICAgKCJ1dGZjcHAiICx1dGZjcHApKSkKKyAgICAobmF0 aXZlLWlucHV0cyBgKCgidGV4aW5mbyIgLHRleGluZm8pCisgICAgICAgICAg ICAgICAgICAgICAoImdyb2ZmIiAsZ3JvZmYpKSkKKyAgICAoaG9tZS1wYWdl ICJodHRwOi8vbGVkZ2VyLWNsaS5vcmcvIikKKyAgICAoc3lub3BzaXMgIkNv bW1hbmQtbGluZSBkb3VibGUtZW50cnkgYWNjb3VudGluZyBwcm9ncmFtIikK KyAgICAoZGVzY3JpcHRpb24KKyAgICAgIkxlZGdlciBpcyBhIHBvd2VyZnVs LCBkb3VibGUtZW50cnkgYWNjb3VudGluZyBzeXN0ZW0gdGhhdCBpcworICAg ICBhY2Nlc3NlZCBmcm9tIHRoZSBVTklYIGNvbW1hbmQtbGluZS4gIFRoaXMg bWF5IHB1dCBvZmYgc29tZSB1c2VycywKKyAgICAgc2luY2UgdGhlcmUgaXMg bm8gZmxhc2h5IFVJLCBidXQgZm9yIHRob3NlIHdobyB3YW50IHVucGFyYWxs ZWxlZAorICAgICByZXBvcnRpbmcgYWNjZXNzIHRvIHRoZWlyIGRhdGEgdGhl cmUgYXJlIGZldyBhbHRlcm5hdGl2ZXMuCisKKyAgICAgTGVkZ2VyIHVzZXMg dGV4dCBmaWxlcyBmb3IgaW5wdXQuICBJdCByZWFkcyB0aGUgZmlsZXMgYW5k IGdlbmVyYXRlcworICAgICByZXBvcnRzOyB0aGVyZSBpcyBubyBvdGhlciBk YXRhYmFzZSBvciBzdG9yZWQgc3RhdGUuICBUbyB1c2UgTGVkZ2VyLAorICAg ICB5b3UgY3JlYXRlIGEgZmlsZSBvZiB5b3VyIGFjY291bnQgbmFtZXMgYW5k IHRyYW5zYWN0aW9ucywgcnVuIGZyb20KKyAgICAgdGhlIGNvbW1hbmQgbGlu ZSB3aXRoIHNvbWUgb3B0aW9ucyB0byBzcGVjaWZ5IGlucHV0IGFuZCByZXF1 ZXN0ZWQKKyAgICAgcmVwb3J0cywgYW5kIGdldCBvdXRwdXQuICBUaGUgb3V0 cHV0IGlzIGdlbmVyYWxseSBwbGFpbiB0ZXh0LCB0aG91Z2gKKyAgICAgeW91 IGNvdWxkIGdlbmVyYXRlIGEgZ3JhcGggb3IgaHRtbCBpbnN0ZWFkLiAgTGVk Z2VyIGlzIHNpbXBsZSBpbgorICAgICBjb25jZXB0LCBzdXJwcmlzaW5nbHkg cmljaCBpbiBhYmlsaXR5LCBhbmQgZWFzeSB0byB1c2UuIikKKyAgICA7OyBU aGVyZSBhcmUgc29tZSBleHRyYSBsaWNlbnNlcyBpbiBmaWxlcyB3aGljaCBk byBub3QgcHJlc2VudGx5IGdldAorICAgIDs7IGluc3RhbGxlZCB3aGVuIHlv dSBidWlsZCB0aGlzIHBhY2thZ2UuICBEaWZmZXJlbnQgdmVyc2lvbnMgb2Yg dGhlIEdQTAorICAgIDs7IGFyZSB1c2VkIGluIHRoZSBjb250cmliLCBsaXNw LCBhbmQgcHl0aG9uIHN1YmRpcmVjdG9yaWVzLiBBbHNvIHRoZSBmaWxlCisg ICAgOzsgYHRvb2xzL3VwZGF0ZV9jb3B5cmlnaHRfeWVhcmAgaGFzIGFuIEV4 cGF0IGxpY2Vuc2UuCisgICAgKGxpY2Vuc2UgKGxpc3QgbGljZW5zZTpic2Qt MworICAgICAgICAgICAgICAgICAgIGxpY2Vuc2U6YXNsMi4wCisgICAgICAg ICAgICAgICAgICAgKGxpY2Vuc2U6bm9uLWNvcHlsZWZ0CisgICAgICAgICAg ICAgICAgICAgICJmaWxlOi8vc3JjL3djd2lkdGguY2MiCisgICAgICAgICAg ICAgICAgICAgICJTZWUgc3JjL3djd2lkdGguY2MgaW4gdGhlIGRpc3RyaWJ1 dGlvbi4iKSkpKSkKLS0gCjIuNy40Cgo= --_----------=_146267344812153660--