From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH 1/3] gnu: Add utfcpp. Date: Sat, 07 May 2016 21:10:39 -0500 Message-ID: <1462673439.1215291.601202577.5D6E31AB@webmail.messagingengine.com> References: <1462646181.1130095.601018617.5F6ADC8F@webmail.messagingengine.com> <20160507221923.GA16050@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_146267343912152912"; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azEBM-0000nC-OL for guix-devel@gnu.org; Sat, 07 May 2016 22:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azEBI-0002ee-Dp for guix-devel@gnu.org; Sat, 07 May 2016 22:10:55 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azEBF-0002eN-Oo for guix-devel@gnu.org; Sat, 07 May 2016 22:10:52 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2CDA420231 for ; Sat, 7 May 2016 22:10:40 -0400 (EDT) In-Reply-To: <20160507221923.GA16050@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --_----------=_146267343912152912 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Sat, May 7, 2016, at 05:19 PM, Leo Famulari wrote: > Not a bad idea for a new module, but I wonder if you considered any of > the existing modules? Are none of them appropriate? Nothing else seemed to fit, but I'm open to suggestions. > > +(define-public utfcpp >=20 > I'm curious =E2=80=94 are there any significant differences between this = and the > bundled library? No, as far as I can tell it's the same code but with different upstream maintainers. > Can you make sure these lines are < 80 characters? >=20 > Otherwise, LGTM! Yup, here's a new patch. --=20 Alex Griffin --_----------=_146267343912152912 Content-Disposition: attachment; filename="0001-gnu-Add-utfcpp.patch" Content-Id: <1462673433.1215290.99f6988844ceb2d7cc2d25ecddbb6d9c31d9571b.374BA84F@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-utfcpp.patch" RnJvbSBiOTFkOWY0NTMzOWI3ODk2NWFmNDZhOTUxYTA5MjJjMjljZDFkZTk1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IEdyaWZmaW4g PGFAYWpncmYuY29tPgpEYXRlOiBTYXQsIDcgTWF5IDIwMTYgMTI6MTY6Mzkg LTA1MDAKU3ViamVjdDogW1BBVENIIDEvM10gZ251OiBBZGQgdXRmY3BwLgoK KiBnbnUvcGFja2FnZXMvdW5pY29kZS5zY206IE5ldyBmaWxlLgotLS0KIGdu dS9wYWNrYWdlcy91bmljb2RlLnNjbSB8IDYzICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5n ZWQsIDYzIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnbnUv cGFja2FnZXMvdW5pY29kZS5zY20KCmRpZmYgLS1naXQgYS9nbnUvcGFja2Fn ZXMvdW5pY29kZS5zY20gYi9nbnUvcGFja2FnZXMvdW5pY29kZS5zY20KbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTM4NmIwYgotLS0g L2Rldi9udWxsCisrKyBiL2dudS9wYWNrYWdlcy91bmljb2RlLnNjbQpAQCAt MCwwICsxLDYzIEBACis7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFj a2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKKzs7OyBDb3B5cmlnaHQgwqkgMjAx NiBBbGV4IEdyaWZmaW4gPGFAYWpncmYuY29tPgorOzs7Cis7OzsgVGhpcyBm aWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCis7OzsKKzs7OyBHTlUgR3VpeCBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IgbW9kaWZ5IGl0Cis7OzsgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7OyB0 aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAz IG9mIHRoZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5b3VyIG9wdGlvbikgYW55 IGxhdGVyIHZlcnNpb24uCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0cmli dXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQK Kzs7OyBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBp bXBsaWVkIHdhcnJhbnR5IG9mCis7OzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzs7 IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu Cis7OzsKKzs7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9m IHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorOzs7IGFsb25nIHdp dGggR05VIEd1aXguICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3Jn L2xpY2Vuc2VzLz4uCisKKyhkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMg dW5pY29kZSkKKyAjOnVzZS1tb2R1bGUgKChndWl4IGxpY2Vuc2VzKSAjOnBy ZWZpeCBsaWNlbnNlOikKKyAjOnVzZS1tb2R1bGUgKGd1aXggcGFja2FnZXMp CisgIzp1c2UtbW9kdWxlIChndWl4IGRvd25sb2FkKQorICM6dXNlLW1vZHVs ZSAoZ3VpeCBidWlsZC1zeXN0ZW0gdHJpdmlhbCkKKyAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyB6aXApKQorCisoZGVmaW5lLXB1YmxpYyB1dGZjcHAK KyAgKHBhY2thZ2UKKyAgICAobmFtZSAidXRmY3BwIikKKyAgICAodmVyc2lv biAiMi4zLjQiKQorICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAg ICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAgICAgICAgKHVyaQorICAg ICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQKKyAgICAgICAgICAgICAgICAi bWlycm9yOi8vc291cmNlZm9yZ2UvcHJvamVjdC91dGZjcHAvdXRmOGNwcF8y eC9SZWxlYXNlJTIwIgorICAgICAgICAgICAgICAgIHZlcnNpb24gIi91dGY4 X3YiCisgICAgICAgICAgICAgICAgKHN0cmluZy1tYXAgKGxhbWJkYSAoeCkg KGlmIChlcT8geCAjXC4pICNcXyB4KSkgdmVyc2lvbikKKyAgICAgICAgICAg ICAgICAiLnppcCIpKQorICAgICAgICAgICAgICAoZmlsZS1uYW1lIChzdHJp bmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24gIi56aXAiKSkKKyAgICAgICAg ICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgKGJhc2UzMgorICAgICAg ICAgICAgICAgICIxdnFoczBhaXBjdnZkcndjczdoM2pzcnlnNm1nYm1jNHMz NG41Y202ZDM2cTRueHd3d3JrIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIHRy aXZpYWwtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgYCgj Om1vZHVsZXMgKChndWl4IGJ1aWxkIHV0aWxzKSkKKyAgICAgICAjOmJ1aWxk ZXIKKyAgICAgICAoYmVnaW4KKyAgICAgICAgICh1c2UtbW9kdWxlcyAoZ3Vp eCBidWlsZCB1dGlscykpCisgICAgICAgICAobGV0ICgoc291cmNlIChhc3Nv Yy1yZWYgJWJ1aWxkLWlucHV0cyAic291cmNlIikpCisgICAgICAgICAgICAg ICAob3V0ICAgIChhc3NvYy1yZWYgJW91dHB1dHMgIm91dCIpKQorICAgICAg ICAgICAgICAgKHVuemlwICAoc3RyaW5nLWFwcGVuZCAoYXNzb2MtcmVmICVi dWlsZC1pbnB1dHMgInVuemlwIikKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIi9iaW4vdW56aXAiKSkpCisgICAgICAgICAgICht a2Rpci1wIG91dCkKKyAgICAgICAgICAgKHdpdGgtZGlyZWN0b3J5LWV4Y3Vy c2lvbiBvdXQKKyAgICAgICAgICAgICAoc3lzdGVtKiB1bnppcCBzb3VyY2Up CisgICAgICAgICAgICAgKG1rZGlyLXAgInNoYXJlL2RvYyIpCisgICAgICAg ICAgICAgKHJlbmFtZS1maWxlICJkb2MiICJzaGFyZS9kb2MvdXRmY3BwIikK KyAgICAgICAgICAgICAocmVuYW1lLWZpbGUgInNvdXJjZSIgImluY2x1ZGUi KSkpKSkpCisgICAgKG5hdGl2ZS1pbnB1dHMgYCgoInVuemlwIiAsdW56aXAp KSkKKyAgICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vbmVtdHJp Zi91dGZjcHAiKQorICAgIChzeW5vcHNpcyAiUG9ydGFibGUgQysrIGxpYnJh cnkgZm9yIGhhbmRsaW5nIFVURi04IikKKyAgICAoZGVzY3JpcHRpb24gIlVU RjgtQ1BQIGlzIGEgQysrIGxpYnJhcnkgZm9yIGhhbmRsaW5nIFVURi04IGVu Y29kZWQgdGV4dAorICAgICAgICAgICAgICAgICBpbiBhIHBvcnRhYmxlIHdh eS4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Ym9vc3QxLjApKSkKLS0gCjIu Ny40Cgo= --_----------=_146267343912152912--