[PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[Alex Griffin]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's really no reason for other programs to need to see your bash
prompt, so I removed a couple `export` keywords from the default bashrc.
-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-system-Do-not-export-PS1-in-etc-skel-.bashrc.patch --]
[-- Type: text/x-patch; name="0001-system-Do-not-export-PS1-in-etc-skel-.bashrc.patch", Size: 775 bytes --]

From 597c788a6604bcd84a24a469d92c1fbd47f4bedb Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Thu, 5 May 2016 09:59:03 -0500
Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

---
 gnu/system/shadow.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm
index a13ef11..1aa4422 100644
--- a/gnu/system/shadow.scm
+++ b/gnu/system/shadow.scm
@@ -166,9 +166,9 @@ fi
 # Adjust the prompt depending on whether we're in 'guix environment'.
 if [ -n \"$GUIX_ENVIRONMENT\" ]
 then
-    export PS1='\\u@\\h \\w [env]\\$ '
+    PS1='\\u@\\h \\w [env]\\$ '
 else
-    export PS1='\\u@\\h \\w\\$ '
+    PS1='\\u@\\h \\w\\$ '
 fi
 alias ls='ls -p --color'
 alias ll='ls -l'\n"))
-- 
2.7.4

Re: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[Alex Griffin]

Also, is this a large enough change that I should I have added my name
to the copyright notice? I have a few more patches nearly ready to
submit once I figure out this process, and I'm wondering what the
threshold is. What if all I do is update a version number+hash?

Thanks,
-- 
Alex Griffin

On Thu, May 5, 2016, at 10:07 AM, Alex Griffin wrote:
> There's really no reason for other programs to need to see your bash
> prompt, so I removed a couple `export` keywords from the default bashrc.
> -- 
> Alex Griffin
> Email had 1 attachment:
> + 0001-system-Do-not-export-PS1-in-etc-skel-.bashrc.patch
>   1k (text/x-patch)

Re: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On Thu, May 05, 2016 at 10:17:36AM -0500, Alex Griffin wrote:
> Also, is this a large enough change that I should I have added my name
> to the copyright notice? I have a few more patches nearly ready to
> submit once I figure out this process, and I'm wondering what the
> threshold is. What if all I do is update a version number+hash?
> 
> Thanks,
> -- 
> Alex Griffin
> 

I'm totally not a lawyer, but I believe officially and legally any
change you make is yours and needs/should have a copyright line.
On the other side, I believe that if you make a change and don't
attach your name to it then it's as if you've tossed it into the file
with all the other commits there and it can be assumed to follow the
rest of the file/project in terms of copyright.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[Alex Griffin]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Thu, May 5, 2016, at 05:34 PM, Efraim Flashner wrote:
> I'm totally not a lawyer, but I believe officially and legally any
> change you make is yours and needs/should have a copyright line.
> On the other side, I believe that if you make a change and don't
> attach your name to it then it's as if you've tossed it into the file
> with all the other commits there and it can be assumed to follow the
> rest of the file/project in terms of copyright.

Okay, well I'll just go by that policy then unless someone else
disagrees. Here's an updated patch with a copyright line.
-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-system-Do-not-export-PS1-in-etc-skel-.bashrc.patch --]
[-- Type: text/x-patch; name="0001-system-Do-not-export-PS1-in-etc-skel-.bashrc.patch", Size: 1017 bytes --]

From d635ffb29d3755acaa646c293543d4a6a27cc9b4 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Thu, 5 May 2016 09:59:03 -0500
Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

---
 gnu/system/shadow.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm
index a13ef11..b8837c6 100644
--- a/gnu/system/shadow.scm
+++ b/gnu/system/shadow.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -166,9 +167,9 @@ fi
 # Adjust the prompt depending on whether we're in 'guix environment'.
 if [ -n \"$GUIX_ENVIRONMENT\" ]
 then
-    export PS1='\\u@\\h \\w [env]\\$ '
+    PS1='\\u@\\h \\w [env]\\$ '
 else
-    export PS1='\\u@\\h \\w\\$ '
+    PS1='\\u@\\h \\w\\$ '
 fi
 alias ls='ls -p --color'
 alias ll='ls -l'\n"))
-- 
2.7.4

Re: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

[Ludovic Courtès]

Alex Griffin <a@ajgrf.com> skribis:

> On Thu, May 5, 2016, at 05:34 PM, Efraim Flashner wrote:
>> I'm totally not a lawyer, but I believe officially and legally any
>> change you make is yours and needs/should have a copyright line.
>> On the other side, I believe that if you make a change and don't
>> attach your name to it then it's as if you've tossed it into the file
>> with all the other commits there and it can be assumed to follow the
>> rest of the file/project in terms of copyright.
>
> Okay, well I'll just go by that policy then unless someone else
> disagrees. Here's an updated patch with a copyright line.

Yeah I think it’s reasonable.

> From d635ffb29d3755acaa646c293543d4a6a27cc9b4 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Thu, 5 May 2016 09:59:03 -0500
> Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

Indeed, good catch.

Committed with a ChangeLog-style commit log, thank you!

Ludo’.