From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Griffin Subject: Re: [PATCH 2/2] Add jq Date: Sat, 26 Mar 2016 14:13:39 -0500 Message-ID: <1459019619.979274.560403538.738A9771@webmail.messagingengine.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajtea-0007r4-RD for guix-devel@gnu.org; Sat, 26 Mar 2016 15:13:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajteW-0005Om-Is for guix-devel@gnu.org; Sat, 26 Mar 2016 15:13:44 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajteW-0005Oi-EJ for guix-devel@gnu.org; Sat, 26 Mar 2016 15:13:40 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 03C1F204E5 for ; Sat, 26 Mar 2016 15:13:39 -0400 (EDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org Heh, I've had this packaged for ages (along with some others) and I've put off submitting because I don't have a good workflow yet for git+email. I should probably do something about that. Anyway, your oniguruma package looks good to me. Here's a few notes about jq: You listed jq's license at cc-by3.0, but that's only for the docs. Most of the jq code is under the x11 license, except a few files which were taken from other projects. I don't know how to specify multiple licenses - maybe someone more experienced with Guix can chime in? Your source URL is not stable (the hash will change at any time because it's autogenerated by Github and not guaranteed to be identical). I would use https://github.com/stedolan/jq/releases/download/jq-1.5/jq-1.5.tar.gz instead. You should add valgrind as a dependency so that the test suite can run. Finally, your description is a bit sparse. Here's what I wrote: jq is like sed for JSON data =E2=80=93 you can use it to slice and filt= er and map and transform structured data with the same ease that sed, awk, grep and friends let you play with text. It is written in portable C, and it has zero runtime dependencies. jq can mangle the data format that you have into the one that you want with very little effort, and the program to do so is often shorter and simpler than you=E2=80=99d expect. Hope that helps! --=20 Alex Griffin On Sat, Mar 26, 2016, at 12:41 PM, Jelle Licht wrote: > ... and the actual package I wanted to use on guix! > Email had 1 attachment: > * 0002-gnu-Add-jq.patch > =C2=A0 3k (text/x-patch)