Adding idle3-tools while unable to run ‘guix lint’

Adding idle3-tools while unable to run ‘guix lint’

[Tobias Geerinckx-Rice]

Hullo Guix,

YAPackage. I'd love to run ‘guix lint’, but then:

  ~blah$ ./pre-inst-env guix lint idle3-tools
  gnu/packages/disk.scm:193:15: idle3-tools-0.9.1: \
    URI http://idle3-tools.sourceforge.net unreachable: \
    Connection timed out

I don't know if this is the cause or just a symptom. Full error output
is pasted below. Loading the URI in my browser, of course, works fine.

Kind regards,

T G-R

--

gnu/packages/disk.scm:193:15: idle3-tools-0.9.1: URI http://idle3-tools.sourceforge.net unreachable: Connection timed out
;;; Failed to autoload make-session in (gnutls):
;;; ERROR: missing interface for module (gnutls)
Backtrace:
In ice-9/boot-9.scm:
  63: 19 [call-with-prompt prompt0 ...]
In ice-9/eval.scm:
 432: 18 [eval # #]
In ice-9/boot-9.scm:
2401: 17 [save-module-excursion #<procedure 1ad9940 at ice-9/boot-9.scm:4045:3 ()>]
4050: 16 [#<procedure 1ad9940 at ice-9/boot-9.scm:4045:3 ()>]
1724: 15 [%start-stack load-stack ...]
1729: 14 [#<procedure 1af1ea0 ()>]
In unknown file:
   ?: 13 [primitive-load "/home/nckx/Hacking/guix/scripts/guix"]
In guix/ui.scm:
1177: 12 [run-guix-command lint "idle3-tools"]
In srfi/srfi-1.scm:
 619: 11 [for-each #<procedure 2b43420 at guix/scripts/lint.scm:867:20 (spec)> #]
 619: 10 [for-each #<procedure 3980b10 at guix/scripts/lint.scm:778:14 (checker)> #]
In guix/scripts/lint.scm:
 608: 9 [check-vulnerabilities #]
 602: 8 [#<procedure 2b3f6a0 at guix/scripts/lint.scm:600:4 (package)> #]
In unknown file:
   ?: 7 [force #<promise #<procedure 2b3f780 at guix/scripts/lint.scm:589:16 ()>>]
In guix/scripts/lint.scm:
 592: 6 [#<procedure 2b3f780 at guix/scripts/lint.scm:589:16 ()>]
In ice-9/boot-9.scm:
 157: 5 [catch getaddrinfo-error ...]
In guix/cve.scm:
  63: 4 [call-with-cve-port #<procedure 2b21760 at guix/cve.scm:139:3 (port)>]
In guix/http-client.scm:
 292: 3 [#<procedure 50f4780 at guix/http-client.scm:313:6 args> system-error ...]
 234: 2 [loop #]
In guix/build/download.scm:
 367: 1 [open-connection-for-uri # # #f]
 252: 0 [tls-wrap #<input-output: socket 10> "nvd.nist.gov"]

guix/build/download.scm:252:17: In procedure tls-wrap:
guix/build/download.scm:252:17: In procedure module-lookup: Unbound variable: make-session

[PATCH] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

* gnu/packages/disk.scm (idle3-tools): New variable.
* gnu/packages/disk.scm: Introduce license name space.
---
 gnu/packages/disk.scm | 40 ++++++++++++++++++++++++++++++++++------
 1 file changed, 34 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index b9240a3..92475a1 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -20,7 +20,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages disk)
-  #:use-module (guix licenses)
+  #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
@@ -68,7 +68,7 @@
     (description
      "GNU Parted is a package for creating and manipulating disk partition
 tables.  It includes a library and command-line utility.")
-    (license gpl3+)))
+    (license license:gpl3+)))
 
 (define-public fdisk
   (package
@@ -94,7 +94,7 @@ tables.  It includes a library and command-line utility.")
      "GNU fdisk provides a GNU version of the common disk partitioning tool
 fdisk.  fdisk is used for the creation and manipulation of disk partition
 tables, and it understands a variety of different formats.")
-    (license gpl3+)))
+    (license license:gpl3+)))
 
 (define-public ddrescue
   (package
@@ -117,7 +117,7 @@ tables, and it understands a variety of different formats.")
 from one file to another, working to rescue data in case of read errors.  The
 program also includes a tool for manipulating its log files, which are used
 to recover data more efficiently by only reading the necessary blocks.")
-    (license gpl3+)))
+    (license license:gpl3+)))
 
 (define-public dosfstools
   (package
@@ -144,7 +144,7 @@ to recover data more efficiently by only reading the necessary blocks.")
     (description
      "The dosfstools package includes the mkfs.fat and fsck.fat utilities,
 which respectively make and check MS-DOS FAT filesystems.")
-    (license gpl3+)))
+    (license license:gpl3+)))
 
 (define-public sdparm
   (package
@@ -170,4 +170,32 @@ uses a SCSI command set.  Such devices include CD/DVD drives (irrespective of
 transport), SCSI and ATAPI tape drives, and SCSI enclosures.  This utility can
 also send commands associated with starting and stopping the media, loading
 and unloading removable media and some other housekeeping functions.")
-    (license bsd-3)))
+    (license license:bsd-3)))
+
+(define-public idle3-tools
+  (package
+    (name "idle3-tools")
+    (version "0.9.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/idle3-tools/idle3-tools-"
+                           version ".tgz"))
+       (sha256
+        (base32
+         "00ia7xq9yldxyl9gz0mr4xa568nav14p0fnv82f2rbbkg060cy4p"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no test suite
+       #:phases (modify-phases %standard-phases
+         (delete 'configure))
+       #:make-flags '("CC=gcc")))
+    (home-page "http://idle3-tools.sourceforge.net")
+    (synopsis "Change or disable Western Digital hard drives' Idle3 timer")
+    (description
+     "Idle3-tools provides a utility to get, set, or disable the Idle3 timer
+present in many Western Digital hard drives.  This timer is part of the
+\"IntelliPark\" feature that stops the disk when not in use.  Unfortunately,
+the default timer setting is not well suited to Linux or other *nix systems,
+and can dramatically shorten the lifespan of the drive if left unchecked.")
+    (license license:gpl3+)))
-- 
2.7.0

Re: Adding idle3-tools while unable to run ‘guix lint’

[Pjotr Prins]

guile gnutls is missing which means it should be installed and
visible from

  export GUILE_LOAD_PATH="/home/wrk/.guix-profile/share/guile/site/2.0"

I am thinking, to make things easier, why don't we have a guix-dev
package which includes guix, guile, emacs and all related packages and
emacs extensions typically used for development?

That way guix lint and emacs can work out of the box. All it needs is
setting the search paths.

Pj.

On Tue, Feb 16, 2016 at 04:56:31AM +0100, Tobias Geerinckx-Rice wrote:
> Hullo Guix,
> 
> YAPackage. I'd love to run ‘guix lint’, but then:
> 
>   ~blah$ ./pre-inst-env guix lint idle3-tools
>   gnu/packages/disk.scm:193:15: idle3-tools-0.9.1: \
>     URI http://idle3-tools.sourceforge.net unreachable: \
>     Connection timed out
> 
> I don't know if this is the cause or just a symptom. Full error output
> is pasted below. Loading the URI in my browser, of course, works fine.
> 
> Kind regards,
> 
> T G-R
> 
> --
> 
> gnu/packages/disk.scm:193:15: idle3-tools-0.9.1: URI http://idle3-tools.sourceforge.net unreachable: Connection timed out
> ;;; Failed to autoload make-session in (gnutls):
> ;;; ERROR: missing interface for module (gnutls)
> Backtrace:
> In ice-9/boot-9.scm:
>   63: 19 [call-with-prompt prompt0 ...]
> In ice-9/eval.scm:
>  432: 18 [eval # #]
> In ice-9/boot-9.scm:
> 2401: 17 [save-module-excursion #<procedure 1ad9940 at ice-9/boot-9.scm:4045:3 ()>]
> 4050: 16 [#<procedure 1ad9940 at ice-9/boot-9.scm:4045:3 ()>]
> 1724: 15 [%start-stack load-stack ...]
> 1729: 14 [#<procedure 1af1ea0 ()>]
> In unknown file:
>    ?: 13 [primitive-load "/home/nckx/Hacking/guix/scripts/guix"]
> In guix/ui.scm:
> 1177: 12 [run-guix-command lint "idle3-tools"]
> In srfi/srfi-1.scm:
>  619: 11 [for-each #<procedure 2b43420 at guix/scripts/lint.scm:867:20 (spec)> #]
>  619: 10 [for-each #<procedure 3980b10 at guix/scripts/lint.scm:778:14 (checker)> #]
> In guix/scripts/lint.scm:
>  608: 9 [check-vulnerabilities #]
>  602: 8 [#<procedure 2b3f6a0 at guix/scripts/lint.scm:600:4 (package)> #]
> In unknown file:
>    ?: 7 [force #<promise #<procedure 2b3f780 at guix/scripts/lint.scm:589:16 ()>>]
> In guix/scripts/lint.scm:
>  592: 6 [#<procedure 2b3f780 at guix/scripts/lint.scm:589:16 ()>]
> In ice-9/boot-9.scm:
>  157: 5 [catch getaddrinfo-error ...]
> In guix/cve.scm:
>   63: 4 [call-with-cve-port #<procedure 2b21760 at guix/cve.scm:139:3 (port)>]
> In guix/http-client.scm:
>  292: 3 [#<procedure 50f4780 at guix/http-client.scm:313:6 args> system-error ...]
>  234: 2 [loop #]
> In guix/build/download.scm:
>  367: 1 [open-connection-for-uri # # #f]
>  252: 0 [tls-wrap #<input-output: socket 10> "nvd.nist.gov"]
> 
> guix/build/download.scm:252:17: In procedure tls-wrap:
> guix/build/download.scm:252:17: In procedure module-lookup: Unbound variable: make-session
> 
> 

-- 

Re: Adding idle3-tools while unable to run ‘guix lint’

[Tobias Geerinckx-Rice]

Thanks Pjotr!

I would have naively expected ‘gnutls’ to be a dependency of ‘guix’
and available to the latter at run time (wrappers; magic), but I guess
that's not how Guile/Guix works?

On 16 February 2016 at 08:26, Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> guile gnutls is missing which means it should be installed and
> visible from
>
>   export GUILE_LOAD_PATH="/home/wrk/.guix-profile/share/guile/site/2.0"

/nix/store/k5m7fb4r3p71mkvaxgqh242aq8kr6h6s-guile-2.0.11/bin/guile:
symbol lookup error:
/gnu/store/rdi8195mysf340rm54xqjmxpl1qjq1wb-nettle-3.2/lib/libhogweed.so.4:
undefined symbol: __gmpz_limbs_read

:-/

> [...] out of the box.

That would be nice.

Kind regards,

T G-R

Re: Adding idle3-tools while unable to run ‘guix lint’

[Tobias Geerinckx-Rice]

Hmm,

On 16 February 2016 at 17:22, Tobias Geerinckx-Rice
<tobias.geerinckx.rice@gmail.com> wrote:
>
> /nix/store/k5m7fb4r3p71mkvaxgqh242aq8kr6h6s-guile-2.0.11/bin/guile:
> symbol lookup error:
> /gnu/store/rdi8195mysf340rm54xqjmxpl1qjq1wb-nettle-3.2/lib/libhogweed.so.4:
> undefined symbol: __gmpz_limbs_read
>
> :-/

My guix checkout was littered with hard-coded paths to Nix's Guile:

  nix/scripts/list-runtime-roots:#!/nix/store/...-guile-2.0.11/bin/guile -ds
  scripts/guix:#!/nix/store/...-guile-2.0.11/bin/guile --no-auto-compile
  config.status:S["GUILE_CONFIG"]="/nix/store/...-guile-2.0.11/bin/guile-config"
  config.status:S["GUILE"]="/nix/store/...-guile-2.0.11/bin/guile"

Running

  guix$ find -type f -exec sed
's@/nix/store/k5m7fb4r3p71mkvaxgqh242aq8kr6h6s-guile-2.0.11@/gnu/store/b44k6wx7nxn0kh2kchlazgas2ybc576v-guile-2.0.11@g'
-i {} \;

‘solved’ that. Is this normal? Should't that have been bootstrapped out?

Kind regards,

T G-R

Re: Adding idle3-tools while unable to run ‘guix lint’

[Ricardo Wurmus]

Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> writes:

> Hmm,
>
> On 16 February 2016 at 17:22, Tobias Geerinckx-Rice
> <tobias.geerinckx.rice@gmail.com> wrote:
>>
>> /nix/store/k5m7fb4r3p71mkvaxgqh242aq8kr6h6s-guile-2.0.11/bin/guile:
>> symbol lookup error:
>> /gnu/store/rdi8195mysf340rm54xqjmxpl1qjq1wb-nettle-3.2/lib/libhogweed.so.4:
>> undefined symbol: __gmpz_limbs_read
>>
>> :-/
>
> My guix checkout was littered with hard-coded paths to Nix's Guile:
>
>   nix/scripts/list-runtime-roots:#!/nix/store/...-guile-2.0.11/bin/guile -ds
>   scripts/guix:#!/nix/store/...-guile-2.0.11/bin/guile --no-auto-compile
>   config.status:S["GUILE_CONFIG"]="/nix/store/...-guile-2.0.11/bin/guile-config"
>   config.status:S["GUILE"]="/nix/store/...-guile-2.0.11/bin/guile"
>
> Running
>
>   guix$ find -type f -exec sed
> 's@/nix/store/k5m7fb4r3p71mkvaxgqh242aq8kr6h6s-guile-2.0.11@/gnu/store/b44k6wx7nxn0kh2kchlazgas2ybc576v-guile-2.0.11@g'
> -i {} \;
>
> ‘solved’ that. Is this normal? Should't that have been bootstrapped out?

These paths are recorded at configure time.  The “./configure” script
checks for the full paths of dependencies and substitutes the
placeholders in the sources.

The error at the very top shows that your Guile (which happens to be in
Nix) is broken.  Maybe it is broken because of your environment.  It
doesn’t seem normal for a binary in Nix to load a library in the Guix
store.  (Do you have LD_LIBRARY_PATH set, or something similar that
could mess with where libraries are loaded from?)

Instead of using “find” and “sed” it would have been sufficient to rerun
“./configure” in a suitable environment containing Guile and the other
dependencies.

~~ Ricardo

Re: [PATCH] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

Hallo Guix,

Perhaps I should have added that I did run `guix lint'
on this without issues.

Anyone fancy having a look?

T G-R

Re: [PATCH] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

For example, I'm now no longer sure why I added a licence
namespace nor whether that's a good idea.

Now, if you'll excuse me, I need to throw a certain console
browser out of a very high window.

On 04/03/2016, Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> wrote:
> Hallo Guix,
>
> Perhaps I should have added that I did run `guix lint'
> on this without issues.
>
> Anyone fancy having a look?
>
> T G-R
>

Re: [PATCH] gnu: Add idle3-tools.

[Leo Famulari]

On Fri, Mar 04, 2016 at 04:22:36AM +0100, Tobias Geerinckx-Rice wrote:
> For example, I'm now no longer sure why I added a licence
> namespace nor whether that's a good idea.

I'm not sure either :)

There are licenses and packages both named 'expat' and 'openssl', so
when we need to use both the package and the license of one of those
names in a single module, we must prefix the license. Otherwise the
symbol is ambiguous and the module can't be built.

If that's not the case here, can you resubmit without the license
prefix?

> 
> Now, if you'll excuse me, I need to throw a certain console
> browser out of a very high window.
> 
> On 04/03/2016, Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> wrote:
> > Hallo Guix,
> >
> > Perhaps I should have added that I did run `guix lint'
> > on this without issues.
> >
> > Anyone fancy having a look?
> >
> > T G-R
> >
> 

[PATCH v2] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

* gnu/packages/disk.scm (idle3-tools): New variable.
---
 gnu/packages/disk.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index b9240a3..37c7bf5 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -171,3 +171,31 @@ transport), SCSI and ATAPI tape drives, and SCSI enclosures.  This utility can
 also send commands associated with starting and stopping the media, loading
 and unloading removable media and some other housekeeping functions.")
     (license bsd-3)))
+
+(define-public idle3-tools
+  (package
+    (name "idle3-tools")
+    (version "0.9.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/idle3-tools/idle3-tools-"
+                           version ".tgz"))
+       (sha256
+        (base32
+         "00ia7xq9yldxyl9gz0mr4xa568nav14p0fnv82f2rbbkg060cy4p"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no test suite
+       #:phases (modify-phases %standard-phases
+         (delete 'configure))
+       #:make-flags '("CC=gcc")))
+    (home-page "http://idle3-tools.sourceforge.net")
+    (synopsis "Change or disable Western Digital hard drives' Idle3 timer")
+    (description
+     "Idle3-tools provides a utility to get, set, or disable the Idle3 timer
+present in many Western Digital hard drives.  This timer is part of the
+\"IntelliPark\" feature that stops the disk when not in use.  Unfortunately,
+the default timer setting is not well suited to Linux or other *nix systems,
+and can dramatically shorten the lifespan of the drive if left unchecked.")
+    (license gpl3+)))
-- 
2.7.0

Re: [PATCH v2] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

Leo,

I just realised that I forgot to add you in CC. I'm still learning the
finer points of git send-email...

(Of course, if you had already seen the updated patch, cheerily ignore
this message.)

Kind regards,

T G-R

On 08/03/2016, Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> wrote:
> * gnu/packages/disk.scm (idle3-tools): New variable.
> ---
>  gnu/packages/disk.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
> index b9240a3..37c7bf5 100644
> --- a/gnu/packages/disk.scm
> +++ b/gnu/packages/disk.scm
> @@ -171,3 +171,31 @@ transport), SCSI and ATAPI tape drives, and SCSI
> enclosures.  This utility can
>  also send commands associated with starting and stopping the media,
> loading
>  and unloading removable media and some other housekeeping functions.")
>      (license bsd-3)))
> +
> +(define-public idle3-tools
> +  (package
> +    (name "idle3-tools")
> +    (version "0.9.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/idle3-tools/idle3-tools-"
> +                           version ".tgz"))
> +       (sha256
> +        (base32
> +         "00ia7xq9yldxyl9gz0mr4xa568nav14p0fnv82f2rbbkg060cy4p"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ;no test suite
> +       #:phases (modify-phases %standard-phases
> +         (delete 'configure))
> +       #:make-flags '("CC=gcc")))
> +    (home-page "http://idle3-tools.sourceforge.net")
> +    (synopsis "Change or disable Western Digital hard drives' Idle3
> timer")
> +    (description
> +     "Idle3-tools provides a utility to get, set, or disable the Idle3
> timer
> +present in many Western Digital hard drives.  This timer is part of the
> +\"IntelliPark\" feature that stops the disk when not in use.
> Unfortunately,
> +the default timer setting is not well suited to Linux or other *nix
> systems,
> +and can dramatically shorten the lifespan of the drive if left
> unchecked.")
> +    (license gpl3+)))
> --
> 2.7.0
>
>

Re: [PATCH v2] gnu: Add idle3-tools.

[Leo Famulari]

On Wed, Mar 16, 2016 at 05:02:24AM +0100, Tobias Geerinckx-Rice wrote:
> Leo,
> 
> I just realised that I forgot to add you in CC. I'm still learning the
> finer points of git send-email...
> 
> (Of course, if you had already seen the updated patch, cheerily ignore
> this message.)

I'm sorry, my inbox grew too large!

I standardized the indentation of modify-phases, set DESTDIR in the
#:make-flags to make the installation succeed, and I also removed a
'/usr' from the path to the manpage:

+       (modify-phases %standard-phases
+         (delete 'configure))
+       #:make-flags (list "CC=gcc"
+                          (string-append "manprefix=")
+                          (string-append "DESTDIR="
+                                         (assoc-ref %outputs "out")))))

Did it work for you without setting DESTDIR?

Anyways, pushed as 8e14e059c40c!

Thanks for packaging this, and sorry again for the delay!

> 
> Kind regards,
> 
> T G-R
> 
> On 08/03/2016, Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> wrote:
> > * gnu/packages/disk.scm (idle3-tools): New variable.
> > ---
> >  gnu/packages/disk.scm | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
> > index b9240a3..37c7bf5 100644
> > --- a/gnu/packages/disk.scm
> > +++ b/gnu/packages/disk.scm
> > @@ -171,3 +171,31 @@ transport), SCSI and ATAPI tape drives, and SCSI
> > enclosures.  This utility can
> >  also send commands associated with starting and stopping the media,
> > loading
> >  and unloading removable media and some other housekeeping functions.")
> >      (license bsd-3)))
> > +
> > +(define-public idle3-tools
> > +  (package
> > +    (name "idle3-tools")
> > +    (version "0.9.1")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "mirror://sourceforge/idle3-tools/idle3-tools-"
> > +                           version ".tgz"))
> > +       (sha256
> > +        (base32
> > +         "00ia7xq9yldxyl9gz0mr4xa568nav14p0fnv82f2rbbkg060cy4p"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:tests? #f ;no test suite
> > +       #:phases (modify-phases %standard-phases
> > +         (delete 'configure))
> > +       #:make-flags '("CC=gcc")))
> > +    (home-page "http://idle3-tools.sourceforge.net")
> > +    (synopsis "Change or disable Western Digital hard drives' Idle3
> > timer")
> > +    (description
> > +     "Idle3-tools provides a utility to get, set, or disable the Idle3
> > timer
> > +present in many Western Digital hard drives.  This timer is part of the
> > +\"IntelliPark\" feature that stops the disk when not in use.
> > Unfortunately,
> > +the default timer setting is not well suited to Linux or other *nix
> > systems,
> > +and can dramatically shorten the lifespan of the drive if left
> > unchecked.")
> > +    (license gpl3+)))
> > --
> > 2.7.0
> >
> >

Re: [PATCH v2] gnu: Add idle3-tools.

[Tobias Geerinckx-Rice]

Leo,

On 16/03/2016, Leo Famulari <leo@famulari.name> wrote:
> I standardized the indentation of modify-phases, set DESTDIR in the
> #:make-flags to make the installation succeed, and I also removed a
> '/usr' from the path to the manpage: [...]
> Did it work for you without setting DESTDIR?

Hm, it obviously couldn't have. Yet I'm not in the habit of sending
patches without testing them (and if I had, it surely would have
contained more errors). So I've no idea what happened here.

Sorry you had to do extra work, and thanks for doing it!

Kind regards,

T G-R