From: Mathieu Lirzin <mthl@gnu.org>
To: guix-devel@gnu.org
Subject: [PATCH 02/13] lint: Remove an unneeded clause in 'check-patch-file-names'.
Date: Sun, 24 Jan 2016 21:19:20 +0100 [thread overview]
Message-ID: <1453666771-16869-3-git-send-email-mthl@gnu.org> (raw)
In-Reply-To: <1453666771-16869-1-git-send-email-mthl@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
* guix/scripts/lint.scm (check-patch-file-names): Don't check if patches
start with the package full name since matching the package name (which
is a prefix of the full name) is sufficient.
---
guix/scripts/lint.scm | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-lint-Remove-an-unneeded-clause-in-check-patch-file-n.patch --]
[-- Type: text/x-patch; name="0002-lint-Remove-an-unneeded-clause-in-check-patch-file-n.patch", Size: 1497 bytes --]
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index e2cc965..25f49a7 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -2,7 +2,7 @@
;;; Copyright © 2014 Cyril Roelandt <tipecaml@gmail.com>
;;; Copyright © 2014, 2015 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2013, 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
+;;; Copyright © 2015, 2016 Mathieu Lirzin <mthl@gnu.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -417,15 +417,12 @@ patch could not be found."
(emit-warning package (condition-message c)
'patch-file-names)))
(let ((patches (and=> (package-source package) origin-patches))
- (name (package-name package))
- (full-name (package-full-name package)))
+ (name (package-name package)))
(when (and patches
(any (match-lambda
((? string? patch)
(let ((file (basename patch)))
- (not (or (eq? (string-contains file name) 0)
- (eq? (string-contains file full-name)
- 0)))))
+ (not (eq? (string-contains file name) 0))))
(_
;; This must be an <origin> or something like that.
#f))
next prev parent reply other threads:[~2016-01-24 20:20 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 20:19 [PATCH 00/13] New syntax 'package@version' and compilation improvements Mathieu Lirzin
2016-01-24 20:19 ` [PATCH 01/13] tests: Use 'dummy-origin' for lint tests when possible Mathieu Lirzin
2016-01-26 15:58 ` Ludovic Courtès
2016-01-24 20:19 ` Mathieu Lirzin [this message]
2016-01-26 16:00 ` [PATCH 02/13] lint: Remove an unneeded clause in 'check-patch-file-names' Ludovic Courtès
2016-01-24 20:19 ` [PATCH 03/13] lint: Rewrite 'check-patch-file-names' Mathieu Lirzin
2016-01-26 16:01 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 04/13] utils: Use '@' for separating package names and version numbers Mathieu Lirzin
2016-01-25 11:37 ` Alex Kost
2016-01-25 20:56 ` Mathieu Lirzin
2016-01-26 16:22 ` Ludovic Courtès
2016-01-26 20:52 ` Mathieu Lirzin
2016-01-26 21:08 ` Ludovic Courtès
2016-02-19 20:49 ` Mathieu Lirzin
2016-02-23 11:11 ` Ludovic Courtès
2016-02-29 0:28 ` Mathieu Lirzin
2016-02-29 16:00 ` Ludovic Courtès
2016-03-02 21:35 ` Mathieu Lirzin
2016-03-05 1:28 ` Nils Gillmann
2016-03-05 9:24 ` Alex Kost
2016-03-05 9:36 ` Mathieu Lirzin
2016-03-03 10:29 ` Alex Kost
2016-03-03 16:55 ` Ludovic Courtès
2016-03-04 10:19 ` Alex Kost
2016-03-04 23:03 ` Mathieu Lirzin
2016-03-04 23:25 ` Ludovic Courtès
2016-03-05 1:08 ` Mathieu Lirzin
2016-03-05 9:16 ` Alex Kost
2016-01-25 14:04 ` Thompson, David
2016-01-25 21:41 ` Mathieu Lirzin
2016-01-25 23:33 ` Alex Kost
2016-01-26 17:57 ` Mathieu Lirzin
2016-01-24 20:19 ` [PATCH 05/13] packages: Use '@' in package record printers Mathieu Lirzin
2016-01-26 16:22 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 06/13] build: Generate man pages after compiling guile objects Mathieu Lirzin
2016-01-26 16:52 ` Ludovic Courtès
2016-01-26 20:08 ` Mathieu Lirzin
2016-01-28 2:37 ` Eric Bavier
2016-01-28 15:44 ` Mathieu Lirzin
2016-01-28 15:59 ` Eric Bavier
2016-01-28 17:00 ` Mathieu Lirzin
2016-01-29 0:27 ` Eric Bavier
2016-01-29 16:17 ` Mathieu Lirzin
2016-01-29 16:46 ` Eric Bavier
2016-01-29 22:56 ` Mathieu Lirzin
2016-01-31 9:17 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 07/13] build: Add 'DL' silent rule Mathieu Lirzin
2016-01-26 16:28 ` Ludovic Courtès
2016-01-26 17:44 ` Mathieu Lirzin
2016-01-26 19:22 ` Taylan Ulrich Bayırlı/Kammer
2016-01-26 21:06 ` Ludovic Courtès
2016-01-26 21:14 ` Mathieu Lirzin
2016-01-24 20:19 ` [PATCH 08/13] build: Add 'DOT' " Mathieu Lirzin
2016-01-26 16:28 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 09/13] build: Add 'EMACS' " Mathieu Lirzin
2016-01-26 16:28 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 10/13] build: Add 'HELP2MAN' " Mathieu Lirzin
2016-01-26 16:29 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 11/13] build: Delete emacs/guix-autoloads.el when 'make clean' Mathieu Lirzin
2016-01-26 16:33 ` Ludovic Courtès
2016-01-26 22:55 ` Mathieu Lirzin
2016-01-24 20:19 ` [PATCH 12/13] build: Use 'GEN' and 'at' silent rules Mathieu Lirzin
2016-01-26 16:34 ` Ludovic Courtès
2016-01-24 20:19 ` [PATCH 13/13] Update .gitignore Mathieu Lirzin
2016-01-26 16:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453666771-16869-3-git-send-email-mthl@gnu.org \
--to=mthl@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).