[PATCH 1/2] gnu: Add ghc-transformers

[PATCH 1/2] gnu: Add ghc-transformers

[James David Trotter]

* gnu/packages/haskell.scm (ghc-transformers): New variable.
---
 gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 34cad87..33d58f4 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -458,6 +458,30 @@ Haskell software by automating the fetching, configuration, compilation and
 installation of Haskell libraries and programs.")
    (license bsd-3)))
 
+(define-public ghc-transformers
+  (package
+    (name "ghc-transformers")
+    (version "0.4.3.0")
+    (outputs '("out" "doc"))
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://hackage.haskell.org/package/transformers/transformers-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32 "179sbhvc9dghyw58hz80109pbrzgh7vh437227a51jhmx2bsgl5k"))))
+    (build-system haskell-build-system)
+    (home-page "http://hub.darcs.net/ross/transformers")
+    (synopsis "Concrete functor and monad transformers")
+    (description
+     "A portable library of functor and monad transformers, inspired by the
+paper \"Functional Programming with Overloading and Higher-Order
+Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
+1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")
+    (license bsd-3)))
+
 (define-public ghc-mtl
   (package
     (name "ghc-mtl")
-- 
2.4.3

[PATCH 2/2] gnu: ghc-mtl: Upgrade to 2.2.1.

[James David Trotter]

* gnu/packages/haskell.scm (ghc-mtl): Upgrade to 2.2.1.
---
 gnu/packages/haskell.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33d58f4..c5dcbf3 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -485,7 +485,7 @@ Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
 (define-public ghc-mtl
   (package
     (name "ghc-mtl")
-    (version "2.1.3.1")
+    (version "2.2.1")
     (outputs '("out" "doc"))
     (source
      (origin
@@ -496,8 +496,9 @@ Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
              ".tar.gz"))
        (sha256
         (base32
-         "1xpn2wjmqbh2cg1yssc6749xpgcqlrrg4iilwqgkcjgvaxlpdbvp"))))
+         "1icdbj2rshzn0m1zz5wa7v3xvkf6qw811p4s7jgqwvx1ydwrvrfa"))))
     (build-system haskell-build-system)
+    (propagated-inputs `(("ghc-transformers" ,ghc-transformers)))
     (home-page "http://github.com/ekmett/mtl")
     (synopsis
      "Monad classes, using functional dependencies")
-- 
2.4.3

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Eric Bavier]

Hello James,

Thanks for the patch.  Comments inline.

On Sun, 11 Oct 2015 22:23:55 +0200
James David Trotter <james.trotter@gmail.com> wrote:

> * gnu/packages/haskell.scm (ghc-transformers): New variable.
> ---
>  gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Could you please add a copyright statement for yourself at the top of
gnu/packages/haskell.scm?

> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 34cad87..33d58f4 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -458,6 +458,30 @@ Haskell software by automating the fetching, configuration, compilation and
>  installation of Haskell libraries and programs.")
>     (license bsd-3)))
>  
> +(define-public ghc-transformers
> +  (package
> +    (name "ghc-transformers")
> +    (version "0.4.3.0")
> +    (outputs '("out" "doc"))

Although other ghc packages in haskell.scm include these two outputs,
the "out" output very often ends up referencing the "doc" output, so
both end up installed in practice, so it should be safe to remove this
field.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/transformers/transformers-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32 "179sbhvc9dghyw58hz80109pbrzgh7vh437227a51jhmx2bsgl5k"))))
> +    (build-system haskell-build-system)
> +    (home-page "http://hub.darcs.net/ross/transformers")

This is the repository page.  Perhaps the hackage.haskell.org address
would be more appropriate, as many other packages use.  WDYT?

> +    (synopsis "Concrete functor and monad transformers")
> +    (description
> +     "A portable library of functor and monad transformers, inspired by the
> +paper \"Functional Programming with Overloading and Higher-Order
> +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")

Descriptions can now optionally include texinfo markup, so maybe that
last could be "@url{http://web.cecs.pdx.edu/...}"

> +    (license bsd-3)))
> +
>  (define-public ghc-mtl
>    (package
>      (name "ghc-mtl")

Otherwise looks good.  Could you send an updated patch?

`~Eric

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Eric Bavier]

On Tue, 13 Oct 2015 11:43:24 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Eric Bavier <ericbavier@openmailbox.org> skribis:
> 
> > Although other ghc packages in haskell.scm include these two outputs,
> > the "out" output very often ends up referencing the "doc" output, so
> > both end up installed in practice, so it should be safe to remove this
> > field.
> 
> Oh, too bad.  Do you know why the reference is kept?  Does that look
> like something that can be fixed?

References to the doc directory is often kept in the
lib/ghc-7.8.4/package.d/<package>.conf (or similar) file, in the
'haddock-interfaces' and 'haddock-html' fields.  We may be able to just
scrub the references, but it may break some user expectations about
using 'ghc-pkg' to find the location of documentation for a library.

> >> +    (description
> >> +     "A portable library of functor and monad transformers, inspired by the
> >> +paper \"Functional Programming with Overloading and Higher-Order
> >> +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
> >> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")
> >
> > Descriptions can now optionally include texinfo markup, so maybe that
> > last could be "@url{http://web.cecs.pdx.edu/...}"
> 
> Better yet:
> 
>   @uref{http://web.cecs.pdx.edu/..., "Functional Programming…"}

Much better.

`~Eric

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Ludovic Courtès]

Eric Bavier <ericbavier@openmailbox.org> skribis:

> Although other ghc packages in haskell.scm include these two outputs,
> the "out" output very often ends up referencing the "doc" output, so
> both end up installed in practice, so it should be safe to remove this
> field.

Oh, too bad.  Do you know why the reference is kept?  Does that look
like something that can be fixed?

>> +    (description
>> +     "A portable library of functor and monad transformers, inspired by the
>> +paper \"Functional Programming with Overloading and Higher-Order
>> +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
>> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")
>
> Descriptions can now optionally include texinfo markup, so maybe that
> last could be "@url{http://web.cecs.pdx.edu/...}"

Better yet:

  @uref{http://web.cecs.pdx.edu/..., "Functional Programming…"}

Thanks,
Ludo’.

Re: [PATCH 1/2] gnu: Add ghc-transformers

[James David Trotter]

Hi,

Thanks for the feedback!


On 13 October 2015 at 10:56, Eric Bavier <ericbavier@openmailbox.org> wrote:
>
> On Tue, 13 Oct 2015 11:43:24 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
> > Eric Bavier <ericbavier@openmailbox.org> skribis:
> >
> > > Although other ghc packages in haskell.scm include these two outputs,
> > > the "out" output very often ends up referencing the "doc" output, so
> > > both end up installed in practice, so it should be safe to remove this
> > > field.
> >
> > Oh, too bad.  Do you know why the reference is kept?  Does that look
> > like something that can be fixed?
>
> References to the doc directory is often kept in the
> lib/ghc-7.8.4/package.d/<package>.conf (or similar) file, in the
> 'haddock-interfaces' and 'haddock-html' fields.  We may be able to just
> scrub the references, but it may break some user expectations about
> using 'ghc-pkg' to find the location of documentation for a library.
>

Are you saying that the whole line should be dropped, or only "doc"?

>
> > >> +    (description
> > >> +     "A portable library of functor and monad transformers, inspired by the
> > >> +paper \"Functional Programming with Overloading and Higher-Order
> > >> +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
> > >> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")
> > >
> > > Descriptions can now optionally include texinfo markup, so maybe that
> > > last could be "@url{http://web.cecs.pdx.edu/...}"
> >
> > Better yet:
> >
> >   @uref{http://web.cecs.pdx.edu/..., "Functional Programming…"}
>
> Much better.
>

OK, I'll make the recommended changes and send a new patch.

--
James

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Eric Bavier]

On Tue, 13 Oct 2015 23:11:52 +0200
James David Trotter <james.trotter@gmail.com> wrote:

> On 13 October 2015 at 10:56, Eric Bavier <ericbavier@openmailbox.org> wrote:
> >
> > On Tue, 13 Oct 2015 11:43:24 +0200
> > ludo@gnu.org (Ludovic Courtès) wrote:
> >
> > > Eric Bavier <ericbavier@openmailbox.org> skribis:
> > >
> > > > Although other ghc packages in haskell.scm include these two outputs,
> > > > the "out" output very often ends up referencing the "doc" output, so
> > > > both end up installed in practice, so it should be safe to remove this
> > > > field.
> > >
> > > Oh, too bad.  Do you know why the reference is kept?  Does that look
> > > like something that can be fixed?
> >
> > References to the doc directory is often kept in the
> > lib/ghc-7.8.4/package.d/<package>.conf (or similar) file, in the
> > 'haddock-interfaces' and 'haddock-html' fields.  We may be able to just
> > scrub the references, but it may break some user expectations about
> > using 'ghc-pkg' to find the location of documentation for a library.
> >
> 
> Are you saying that the whole line should be dropped, or only "doc"?

The 'outputs' field is not necessary, so, yes, the
entire line in this case may be dropped.

> > > >> +    (description
> > > >> +     "A portable library of functor and monad transformers, inspired by the
> > > >> +paper \"Functional Programming with Overloading and Higher-Order
> > > >> +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming,
> > > >> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")
> > > >
> > > > Descriptions can now optionally include texinfo markup, so maybe that
> > > > last could be "@url{http://web.cecs.pdx.edu/...}"
> > >
> > > Better yet:
> > >
> > >   @uref{http://web.cecs.pdx.edu/..., "Functional Programming…"}
> >
> > Much better.
> >
> 
> OK, I'll make the recommended changes and send a new patch.

Great, thanks!

`~Eric

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Paul van der Walt]

Hello James, all,

On 2015-10-11 at 22:23, quoth James David Trotter:
> +(define-public ghc-transformers
> +  (package
> +    (name "ghc-transformers")
> +    (version "0.4.3.0")

Now that there are patches ready to provide the latest Haskell Platform
(version 7.10.2a as listed on [0]), i propose we refrain from packaging
things which GHC already provides.  Notably, providing a newer version
generally causes warnings (and occasional build failures depending on
which package we're talking about — Idris was one of those) that GHC
requires (e.g., as in this case) "transformers-0.4.2.0" but some other
dependency requires "transformers-0.4.3.0".  Therefore, we should only
package cabal items *not* on the `Core Libraries' list at [0].

WDYT?

Kind regards,
p.

0. <https://www.haskell.org/platform/contents.html>

Re: [PATCH 1/2] gnu: Add ghc-transformers

[James David Trotter]

Hi Paul,



On 15 October 2015 at 17:24, Paul van der Walt <paul@denknerd.org> wrote:
> Hello James, all,
>
> On 2015-10-11 at 22:23, quoth James David Trotter:
>> +(define-public ghc-transformers
>> +  (package
>> +    (name "ghc-transformers")
>> +    (version "0.4.3.0")
>
> Now that there are patches ready to provide the latest Haskell Platform
> (version 7.10.2a as listed on [0]), i propose we refrain from packaging
> things which GHC already provides.  Notably, providing a newer version
> generally causes warnings (and occasional build failures depending on
> which package we're talking about — Idris was one of those) that GHC
> requires (e.g., as in this case) "transformers-0.4.2.0" but some other
> dependency requires "transformers-0.4.3.0".  Therefore, we should only
> package cabal items *not* on the `Core Libraries' list at [0].
>
> WDYT?
>

I just saw your set of patches for adding Idris, which is great!

I was just about to submit a (somewhat overlapping) set of about
thirty patches in order to add Agda to guix. Hopefully, this should
become easier after your patches.

If I understand correctly, then this patch can just be dropped?


Regards,
James

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Paul van der Walt]

Hi James,

On 2015-10-15 at 19:21, quoth James David Trotter:
> I was just about to submit a (somewhat overlapping) set of about
> thirty patches in order to add Agda to guix. Hopefully, this should
> become easier after your patches.

Cool, Agda was my next target, glad that's done then! :)  Thank you! :D

> If I understand correctly, then this patch can just be dropped?

I've got a patch which removes it in the review-queue :).

A strange thing though: by that logic, ghc-transformers-compat should
not be packaged, but i got errors when i took it away.  I'll investigate
further.

Cheers,
p.

Re: [PATCH 1/2] gnu: Add ghc-transformers

[Paul van der Walt]

Hi James,

On 2015-10-15 at 19:21, quoth James David Trotter:
> I was just about to submit a (somewhat overlapping) set of about
> thirty patches in order to add Agda to guix. Hopefully, this should
> become easier after your patches.

I've pushed the branch wip-haskell-platform-7.10.2-a, perhaps it would
be a good idea to rebase your Agda patches onto HEAD of that branch?
That way we can be sure they work with the updated Haskell Platform, and
we can start reviewing your patches, too.

If somebody more experienced than me thinks that's a terrible idea,
please correct me :).

Kind regards,
p.