From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: [PATCH] import: pypi: detect requirements from requirements.txt. Date: Sun, 8 Mar 2015 00:51:28 +0100 Message-ID: <1425772288-8771-1-git-send-email-tipecaml@gmail.com> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUOVT-0002ZR-Jg for guix-devel@gnu.org; Sat, 07 Mar 2015 18:51:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUOVO-0002t1-F9 for guix-devel@gnu.org; Sat, 07 Mar 2015 18:51:43 -0500 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:33858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUOVO-0002sv-4e for guix-devel@gnu.org; Sat, 07 Mar 2015 18:51:38 -0500 Received: by wesx3 with SMTP id x3so13294004wes.1 for ; Sat, 07 Mar 2015 15:51:37 -0800 (PST) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org * guix/import/pypi.scm (compute-inputs, guess-requirements): New functions. --- guix/import/pypi.scm | 146 ++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 115 insertions(+), 31 deletions(-) diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm index 8567cad..9ac3342 100644 --- a/guix/import/pypi.scm +++ b/guix/import/pypi.scm @@ -21,6 +21,7 @@ #:use-module (ice-9 match) #:use-module (ice-9 pretty-print) #:use-module (ice-9 regex) + #:use-module ((ice-9 rdelim) #:select (read-line)) #:use-module (srfi srfi-1) #:use-module (rnrs bytevectors) #:use-module (json) @@ -77,42 +78,125 @@ or #f on failure." with dashes." (string-join (string-split (string-downcase str) #\_) "-")) -(define (guix-hash-url url) - "Download the resource at URL and return the hash in nix-base32 format." - (call-with-temporary-output-file - (lambda (temp port) - (and (url-fetch url temp) - (bytevector->nix-base32-string - (call-with-input-file temp port-sha256)))))) +(define (guix-hash-url filename) + "Return the hash of FILENAME in nix-base32 format." + (bytevector->nix-base32-string + (call-with-input-file filename port-sha256))) + +(define (guix-name name) + (if (string-prefix? "python-" name) + (snake-case name) + (string-append "python-" (snake-case name)))) + +(define (maybe-inputs guix-name inputs) + (match inputs + (() + '()) + ((inputs ...) + (list (list guix-name + (list 'quasiquote inputs)))))) + +(define (guess-requirements source-url tarball) + "Given SOURCE-URL and a TARBALL of the package, return a list of the required +packages specified in the requirements.txt file." + + (define (tarball-directory url) + "Given the URL of the package's tarball, return the name of the directory +that will be created upon decompressing it." + ;; TODO: Support more archive formats. + (let ((basename (substring url (+ 1 (string-rindex url #\/))))) + (cond + ((string-suffix? ".tar.gz" basename) + (string-drop-right basename 7)) + ((string-suffix? ".tar.bz2" basename) + (string-drop-right basename 8)) + (else #f)))) + + (define (read-requirements requirements-file) + "Given REQUIREMENTS-FILE, a Python requirements.txt file, return a list of +name/variable pairs describing the requirements." + (call-with-input-file requirements-file + (lambda (port) + (let loop ((result '())) + (let ((line (read-line port))) + (if (eof-object? line) + result + (loop (if (or (string-null? line) + (eq? (string-ref line 0) #\#)) + result + (let ((input (guix-name (clean-requirement line)))) + ;; Argparse has been part of Python since 2.7. + (if (string=? input "python-argparse") + result + (cons input result))))))))))) + + (define (clean-requirement s) + "Given a requirement LINE, as can be found in a Python requirements.txt +file, remove everything other than the actual name of the required package, and +return it." + (string-take s + (or (string-index s (lambda (c) + (member c '(#\< #\> #\= #\#)))) + (string-length s)))) + + (let* ((dirname (tarball-directory source-url)) + (req-file (if (string? dirname) + (string-append dirname "/requirements.txt") + #f))) + (if (and (string? req-file) + ;; TODO: support more formats. + (zero? (system* "tar" "xf" tarball req-file))) + (dynamic-wind + (const #t) + (lambda () + (read-requirements req-file)) + (lambda () + (delete-file req-file) + (rmdir dirname))) + '()))) + +(define (compute-inputs source-url tarball) + "Given the SOURCE-URL of an already downloaded TARBALL, return a list of +name/variable pairs describing the required inputs of this package." + (sort + (map (lambda (input) + (list input (list 'unquote (string->symbol input)))) + (append '("python-setuptools") + (guess-requirements source-url tarball))) + (lambda args + (match args + (((a _ ...) (b _ ...)) + (string-ciguix-package package-name) "Fetch the metadata for PACKAGE-NAME from pypi.python.org, and return the -- 1.8.4.rc3