Re: [PATCH] gnu: Add gnugo.

[David Hashe <david.hashe@dhashe.com>]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Taking everyone's feedback into account, here is the updated patch.

David

On Thu, 2015-02-19 at 18:39 -0500, Mark H Weaver wrote:
> Hi!
> 
> David Hashe <david.hashe@dhashe.com> writes:
> 
> > ---
> >  gnu-system.am          |  1 
> >  gnu/packages/gnugo.scm | 44 ﯯ뻻ﯯ뻻ﯯ뻻ﯯ뻻ﯯ뻻ﯯ뙾⥞뇈媞ޝ, 45 insertions()
> >  create mode 100644 gnu/packages/gnugo.scm
> 
> I agree with the feedback from Alex Kost and Andreas Enge,
> and will only add two more comments:
> 
> * It needs a proper commit message.  Assuming that it ends up in
>   games.scm, the commit message would be:
> 
> --8<---------------cut here---------------start------------->8---
> gnu: Add gnugo.
> 
> * gnu/packages/games.scm (gnugo): New variable.
> --8<---------------cut here---------------end--------------->8---
> 
> * Regarding the 'texinfo' input: I'm not sure if it's needed or not, but
>   if it turns out to be needed, it certainly belongs in 'native-inputs',
>   not 'inputs'.  The difference is only important when cross-compiling.
> 
> Thank you, and welcome to our community :)
> 
>      Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnugo.patch --]
[-- Type: text/x-patch; name="gnugo.patch"; charset="UTF-7", Size: 2039 bytes --]

From f694d4edd90094a98875456cae689c37d8d1765e Mon Sep 17 00:00:00 2001
From: David Hashe <david.hashe@dhashe.com>
Date: Thu, 19 Feb 2015 18:47:55 -0600
Subject: [PATCH] gnu: Add gnugo.

* gnu/packages/games.scm (gnugo): New variable.
---
 gnu/packages/games.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 9b8983e..687e037 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2014, 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
+;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -834,3 +835,27 @@ straight into any libretro-compatible frontend.  RetroArch is the official
 reference frontend for the libretro API, currently used by most as a modular
 multi-system game/emulator system.")
     (license license:gpl3+)))
+
+(define-public gnugo
+  (package
+    (name "gnugo")
+    (version "3.8")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "mirror://gnu/gnugo/gnugo-" version
+                                 ".tar.gz"))
+             (sha256
+              (base32
+               "0wkahvqpzq6lzl5r49a4sd4p52frdmphnqsfdv7gdp24bykdfs6s"))))
+    (build-system gnu-build-system)
+    (inputs `(("readline" ,readline)))
+    (synopsis "Go game")
+    (description "GNU Go is a program that plays the game of Go, in which
+players place stones on a grid to form territory or capture other stones.
+While it can be played directly from the terminal, rendered in ASCII
+characters, it is also possible to play GNU Go with 3rd party graphical
+interfaces or even in Emacs.  It supports the standard game storage format
+(SGF, Smart Game Format) and inter-process communication format (GMP, Go
+Modem Protocol).")
+    (home-page "http://www.gnu.org/software/gnugo/")
+    (license license:gpl3+)))
-- 
1.9.1