[PATCH] Kernel Configuration

["Jason Self" <jason@bluehome.net>]

[-- Attachment #1.1: Type: text/plain, Size: 461 bytes --]

Hello, I wanted to make sure that I was doing this correctly before
committing anything. It seems that it's best to have all of the
kernel's config stuff centrally located. Plus, all of these are
already enabled in the normal config, and I'd argue in a better way.
For example: CONFIG_VIRTIO_BLK should be built in, not a module. Doing
it as a module can cause difficulties when running in a VM in some
cases and the normal config already has it as a built-in.

[-- Attachment #1.2: 0001-gnu-linux-libre-Configuration-options-should-be-spec.patch --]
[-- Type: application/octet-stream, Size: 2064 bytes --]

From aec034aab287ce3ba84139be6f773d0a6144f2f1 Mon Sep 17 00:00:00 2001
From: Jason Self <j@jxself.org>
Date: Wed, 24 Sep 2014 11:37:37 -0700
Subject: [PATCH 1/1] gnu: linux-libre: Configuration options should be
 specified in the configuration file.

* gnu/packages/linux.scm (linux-libre): Configuration options should be specified in the configuration file.

Signed-off-by: Jason Self <j@jxself.org>
---
 gnu/packages/linux.scm |   18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 3e19c35..110e1f3 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -215,24 +215,6 @@ for SYSTEM, or #f if there is no configuration for SYSTEM."
                      (chmod ".config" #o666))
                    (system* "make" "defconfig"))
 
-               ;; Appending works even when the option wasn't in the
-               ;; file.  The last one prevails if duplicated.
-               (let ((port (open-file ".config" "a")))
-                 (display (string-append "CONFIG_NET_9P=m\n"
-                                         "CONFIG_NET_9P_VIRTIO=m\n"
-                                         "CONFIG_VIRTIO_BLK=m\n"
-                                         "CONFIG_VIRTIO_NET=m\n"
-                                         ;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
-                                         "CONFIG_DEVPTS_MULTIPLE_INSTANCES=y\n"
-                                         "CONFIG_VIRTIO_PCI=m\n"
-                                         "CONFIG_VIRTIO_BALLOON=m\n"
-                                         "CONFIG_VIRTIO_MMIO=m\n"
-                                         "CONFIG_FUSE_FS=m\n"
-                                         "CONFIG_CIFS=m\n"
-                                         "CONFIG_9P_FS=m\n")
-                          port)
-                 (close-port port))
-
                (zero? (system* "make" "oldconfig"))
 
                ;; Call the default `build' phase so `-j' is correctly
-- 
1.7.9.5


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]