From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sree Harsha Totakura <sreeharsha@totakura.in>
Subject: Update patch: Add (guix svn-download)
Date: Wed, 26 Mar 2014 17:59:00 +0100
Message-ID: <1395853141-3078-1-git-send-email-sreeharsha@totakura.in>
References: <87eh1p0x30.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sreeharsha@totakura.in>) id 1WSrBN-0000vv-Ls
	for guix-devel@gnu.org; Wed, 26 Mar 2014 13:00:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sreeharsha@totakura.in>) id 1WSrBH-0005EE-7Z
	for guix-devel@gnu.org; Wed, 26 Mar 2014 13:00:05 -0400
Received: from mail-out1.informatik.tu-muenchen.de ([131.159.0.8]:54720
	helo=smtp1.informatik.tu-muenchen.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sreeharsha@totakura.in>) id 1WSrBH-0005Ds-24
	for guix-devel@gnu.org; Wed, 26 Mar 2014 12:59:59 -0400
Received: (Authenticated sender: totakura)
	by mail.in.tum.de (Postfix) with ESMTPSA id 2283B2403AD
	for <guix-devel@gnu.org>; Wed, 26 Mar 2014 17:59:55 +0100 (CET)
In-Reply-To: <87eh1p0x30.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: guix-devel@gnu.org

On 03/26/2014 05:00 PM, Ludovic Court=C3=A8s wrote:
> Sree Harsha Totakura <sreeharsha@totakura.in> skribis:=20
>=20
>> * guix/svn-download.scm, guix/build/svn.scm: New files.
>> * Makefile.am (MODULES): Add them.
>=20
>> +(define* (svn-fetch url revision directory
>> +                    #:key (svn-command "svn"))
>> +  "Fetch REVISION from URL into DIRECTORY.  REVISION must be a valid =
svn
>> +revision.  Return #t on success, #f otherwise."
>=20
> =E2=80=98revision=E2=80=99 can/should be a number, no?  Please augment =
the docstring to
> say that, and...

Yes, `revision' is a number.

>> +  (and (zero? (system* svn-command "checkout" "--non-interactive"
>> +                       ;; Trust the server certificate.  This is OK a=
s we
>> +                       ;; verify the checksum later.  This can be rem=
oved when
>> +                       ;; ca-certificates package is added.
>> +                       "--trust-server-cert" "-r" revision url direct=
ory))
>=20
> ... possibly use (number->string revision) here =E2=86=91.
>=20
>> +(define-record-type* <svn-reference>
>> +  svn-reference make-svn-reference
>> +  svn-reference?
>> +  (url    svn-reference-url)
>> +  (revision svn-reference-revision))
>=20
> Please align things, add a comment saying whether =E2=80=98revision=E2=80=
=99 is a number
> or string, and add a newline before =E2=80=98define-record-type*=E2=80=99=
.

OK, here's the updated patch.

-
Sree