* cmake-build-system: build tests only if #:tests? is true?
@ 2024-03-02 21:16 Hartmut Goebel
2024-03-02 21:23 ` Ekaitz Zarraga
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Hartmut Goebel @ 2024-03-02 21:16 UTC (permalink / raw)
To: Guix-devel
Hi,
I found an old and unfinished patch in my pile. It optimizes building
with cmake by not building the test if "#:tests?" is false. (Basically
it passes -DBUILD_TESTING=OFF/ON" depending on "#:tests?".)
Is this of interest? Then I would take my time and finish the patch.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-02 21:16 cmake-build-system: build tests only if #:tests? is true? Hartmut Goebel
@ 2024-03-02 21:23 ` Ekaitz Zarraga
2024-03-02 22:22 ` Hartmut Goebel
2024-03-04 3:07 ` Maxim Cournoyer
2024-03-04 16:00 ` Greg Hogan
2 siblings, 1 reply; 10+ messages in thread
From: Ekaitz Zarraga @ 2024-03-02 21:23 UTC (permalink / raw)
To: Hartmut Goebel, Guix-devel
Hi,
On 2024-03-02 22:16, Hartmut Goebel wrote:
> Hi,
>
> I found an old and unfinished patch in my pile. It optimizes building
> with cmake by not building the test if "#:tests?" is false. (Basically
> it passes -DBUILD_TESTING=OFF/ON" depending on "#:tests?".)
>
> Is this of interest? Then I would take my time and finish the patch.
>
This looks pretty cool but it might rebuild many packages. Or am I
mistaken here? core-updates?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-02 21:23 ` Ekaitz Zarraga
@ 2024-03-02 22:22 ` Hartmut Goebel
2024-03-04 14:10 ` Jean-Pierre De Jesus Diaz
0 siblings, 1 reply; 10+ messages in thread
From: Hartmut Goebel @ 2024-03-02 22:22 UTC (permalink / raw)
To: Ekaitz Zarraga; +Cc: Guix-devel
Am 02.03.24 um 22:23 schrieb Ekaitz Zarraga:
> core-updates?
Yes, many, many packages. Thus of course, this would need to go into
core-updates.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-02 22:22 ` Hartmut Goebel
@ 2024-03-04 14:10 ` Jean-Pierre De Jesus Diaz
0 siblings, 0 replies; 10+ messages in thread
From: Jean-Pierre De Jesus Diaz @ 2024-03-04 14:10 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: Ekaitz Zarraga, Guix-devel
On Sat, Mar 2, 2024 at 10:23 PM Hartmut Goebel
<h.goebel@crazy-compilers.com> wrote:
>
> Am 02.03.24 um 22:23 schrieb Ekaitz Zarraga:
> > core-updates?
>
> Yes, many, many packages. Thus of course, this would need to go into
> core-updates.
>
> --
> Regards
> Hartmut Goebel
>
> | Hartmut Goebel | h.goebel@crazy-compilers.com |
> | www.crazy-compilers.com | compilers which you thought are impossible |
>
>
I think another patch would be a good candidate for core-updates if
cmake-build-system is being updated:
https://issues.guix.gnu.org/68366
It is also needed for:
https://issues.guix.gnu.org/69476
--
Thanks,
Jean-Pierre De Jesus DIAZ
Foundation Devices, Inc.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-02 21:16 cmake-build-system: build tests only if #:tests? is true? Hartmut Goebel
2024-03-02 21:23 ` Ekaitz Zarraga
@ 2024-03-04 3:07 ` Maxim Cournoyer
2024-03-04 16:00 ` Greg Hogan
2 siblings, 0 replies; 10+ messages in thread
From: Maxim Cournoyer @ 2024-03-04 3:07 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: Guix-devel
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Hi,
>
> I found an old and unfinished patch in my pile. It optimizes building
> with cmake by not building the test if "#:tests?" is false. (Basically
> it passes -DBUILD_TESTING=OFF/ON" depending on "#:tests?".)
>
> Is this of interest? Then I would take my time and finish the patch.
Yes, this looks like a neat improvement.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-02 21:16 cmake-build-system: build tests only if #:tests? is true? Hartmut Goebel
2024-03-02 21:23 ` Ekaitz Zarraga
2024-03-04 3:07 ` Maxim Cournoyer
@ 2024-03-04 16:00 ` Greg Hogan
2024-03-04 23:01 ` Hartmut Goebel
2 siblings, 1 reply; 10+ messages in thread
From: Greg Hogan @ 2024-03-04 16:00 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: Guix-devel
On Sat, Mar 2, 2024 at 4:17 PM Hartmut Goebel
<h.goebel@crazy-compilers.com> wrote:
>
> Hi,
>
> I found an old and unfinished patch in my pile. It optimizes building
> with cmake by not building the test if "#:tests?" is false. (Basically
> it passes -DBUILD_TESTING=OFF/ON" depending on "#:tests?".)
>
> Is this of interest? Then I would take my time and finish the patch.
Hi Hartmut,
I have been testing a set of patches (since last summer) based on the
following mailing list discussion (from 2021) to rewrite the
cmake-build-system build, check, and install functions to use cmake
utilities rather than depend on the gnu-build-system. This allows for
parallel tests and a package-defined #:generator.
https://lists.gnu.org/archive/html/guix-devel/2021-10/msg00055.html
I will submit a patchset shortly for review and if accepted we can
look to combine all the cmake patches for the large rebuild. Perhaps a
version update for cmake-bootstrap (v3.24 released August 2022) at the
same time?
Greg
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-04 16:00 ` Greg Hogan
@ 2024-03-04 23:01 ` Hartmut Goebel
2024-03-17 17:35 ` Ludovic Courtès
2024-03-27 15:01 ` Greg Hogan
0 siblings, 2 replies; 10+ messages in thread
From: Hartmut Goebel @ 2024-03-04 23:01 UTC (permalink / raw)
To: Greg Hogan; +Cc: Guix-devel
Hi Greg,
> I will submit a patchset shortly for review and if accepted we can
> look to combine all the cmake patches for the large rebuild.
Yes, of course we should combine them. May I ask you to take care of it
and include mine, which I just posted:
https://issues.guix.gnu.org/issue/69554
Many thanks in advance.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-04 23:01 ` Hartmut Goebel
@ 2024-03-17 17:35 ` Ludovic Courtès
2024-03-18 8:55 ` Hartmut Goebel
2024-03-27 15:01 ` Greg Hogan
1 sibling, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2024-03-17 17:35 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: Greg Hogan, Guix-devel
Hi,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
>> I will submit a patchset shortly for review and if accepted we can
>> look to combine all the cmake patches for the large rebuild.
>
> Yes, of course we should combine them. May I ask you to take care of
> it and include mine, which I just posted:
>
> https://issues.guix.gnu.org/issue/69554
Also, isn’t ‘BUILD_TESTING’ a convention rather than a flag CMake always
honors?
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cmake-build-system: build tests only if #:tests? is true?
2024-03-04 23:01 ` Hartmut Goebel
2024-03-17 17:35 ` Ludovic Courtès
@ 2024-03-27 15:01 ` Greg Hogan
1 sibling, 0 replies; 10+ messages in thread
From: Greg Hogan @ 2024-03-27 15:01 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: Guix-devel
On Mon, Mar 4, 2024 at 6:01 PM Hartmut Goebel
<h.goebel@crazy-compilers.com> wrote:
>
> Hi Greg,
> > I will submit a patchset shortly for review and if accepted we can
> > look to combine all the cmake patches for the large rebuild.
>
> Yes, of course we should combine them. May I ask you to take care of it
> and include mine, which I just posted:
>
> https://issues.guix.gnu.org/issue/69554
>
> Many thanks in advance.
I submitted #70031 without including this patch due to the time to
rebuild and test cmake dependencies, but will include in a v2 with any
additional post-review updates.
These patches will need to wait until core-updates is merged to
master, hopefully soon.
Greg
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-03-27 15:02 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-02 21:16 cmake-build-system: build tests only if #:tests? is true? Hartmut Goebel
2024-03-02 21:23 ` Ekaitz Zarraga
2024-03-02 22:22 ` Hartmut Goebel
2024-03-04 14:10 ` Jean-Pierre De Jesus Diaz
2024-03-04 3:07 ` Maxim Cournoyer
2024-03-04 16:00 ` Greg Hogan
2024-03-04 23:01 ` Hartmut Goebel
2024-03-17 17:35 ` Ludovic Courtès
2024-03-18 8:55 ` Hartmut Goebel
2024-03-27 15:01 ` Greg Hogan
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).