From mboxrd@z Thu Jan 1 00:00:00 1970 From: L p R n d n Subject: Re: First patch & hello Date: Wed, 14 Nov 2018 16:51:24 +0100 Message-ID: <10edc45bbfff91735097e6af9f214d9d@posteo.net> References: <6e5593a318bd45d6ce392561009389a0@posteo.net> <871s7nvp9a.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMxSM-0005gs-S4 for guix-devel@gnu.org; Wed, 14 Nov 2018 10:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMxSG-0006Dn-BO for guix-devel@gnu.org; Wed, 14 Nov 2018 10:51:54 -0500 Received: from mout01.posteo.de ([185.67.36.141]:45831) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gMxSA-0005rL-5h for guix-devel@gnu.org; Wed, 14 Nov 2018 10:51:44 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 1391216005F for ; Wed, 14 Nov 2018 16:51:26 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 42w89p1Hwbz6tmK for ; Wed, 14 Nov 2018 16:51:25 +0100 (CET) In-Reply-To: <871s7nvp9a.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Ricardo Wurmus writes: > Hi, >=20 > thank you for your contribution! >=20 >> 1 . I put the package under fontutils.scm but maybe there's a better >> place for a font viewer? >=20 > This seems fine to me. >=20 >> 2. I found there is a glib-or-gtk-build-system, I hesitated to use as >> Im=CC=80 >> not sure what its purpose. Can someone clarify its use? >=20 > The glib-or-gtk-build-system is an extension of the gnu-build-system > that is useful for GNOME packages and other packages that require a > little more setup after installation. Here=E2=80=99s what the comments i= n > =E2=80=9Cguix/build-system/glib-or-gtk.scm=E2=80=9D say: >=20 > ;; This build system is an extension of the 'gnu-build-system'. It > ;; accomodates the needs of applications making use of glib or gtk+=20 > (with "or" > ;; to be interpreted in the mathematical sense). This is achieved by=20 > adding > ;; two phases run after the 'install' phase: > ;; > ;; 'glib-or-gtk-wrap' phase: > ;; > ;; a) This phase looks for GSettings schemas, GIO modules and theming=20 > data. > ;; If any of these is found in any input package, then all programs in > ;; "out/bin" are wrapped in scripts defining the nedessary environment > ;; variables. > ;; > ;; b) Looks for the existence of "libdir/gtk-3.0" directories in all=20 > input > ;; packages. If any is found, then the environment variable "GTK_PATH"= =20 > is > ;; suitably set and added to the wrappers. The variable "GTK_PATH" has= =20 > been > ;; preferred over "GTK_EXE_PREFIX" because the latter can only point to= =20 > a > ;; single directory, while we may need to point to several ones. > ;; > ;; 'glib-or-gtk-compile-schemas' phase: > ;; > ;; Looks for the presence of "out/share/glib-2.0/schemas". If that=20 > directory > ;; exists and does not include a file named "gschemas.compiled", then > ;; "glib-compile-schemas" is run in that directory. >=20 >=20 >> 3. I tried to get a clean patch but it needed some manual work. What >> your workflow to produce patches? (I use emacs) >=20 > Usually you would make a local git commit and then run >=20 > git format-patch -1 >=20 > to generate a patch file from that commit. You could also directly=20 > send > it to the mailing list with =E2=80=9Cgit send-email=E2=80=9D. >=20 > What follows are some comments about the patch. I=E2=80=99m trying to be= extra > thorough; please don=E2=80=99t let this discourage you. Some of my comme= nts > will just be matters of opinion :) Thanks! It was exactly what I was looking for! >> Subject: [PATCH] gnu: Add font-manager. >>=20 >> --- >=20 > It seems that the commit message is missing here. In this case the > complete commit message would be: >=20 > gnu: Add font-manager. >=20 > * gnu/packages/fontutils.scm (font-manager): New variable. >=20 Do you know why it wasn't added? I used magit format-patch. >=20 > Please remove the last sentence. Please also reindent the description > string (there should be no indentation for following lines). Also > please use two spaces after sentences. =E2=80=9Cguix lint=E2=80=9D will = remind you of > these things Is there a way to specify a custom location for "guix lint"? A little bit like the "-L" option from "guix build" for example? I suppose the right way to invoke 'guix lint' should be to use=20 "./pre-inst-env" in a local guix repository, but I didn't find where I was supposed to find it. :/ > Could you please send an updated patch to guix-patches@gnu.org? >=20 I will soon. I just tested to build the package with "rounds=3D2" and it seems the package isn't deterministic. Is it acceptable or a total no-go? Thanks again, Lprndn