From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] Makefile.am: add a target that lists patches no longer used Date: Thu, 20 Jul 2017 09:02:00 +1000 Message-ID: <09644b83-6ad3-92d2-6e21-fd5c553bac9f@uq.edu.au> References: <1431992050-18271-1-git-send-email-tipecaml@gmail.com> <20170420191546.GA7000@jasmine> <20170420232023.01bb2e6d@centurylink.net> <20170421174106.GC3370@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXxz0-0001Si-M4 for guix-devel@gnu.org; Wed, 19 Jul 2017 19:02:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXxyx-0008Re-Ih for guix-devel@gnu.org; Wed, 19 Jul 2017 19:02:18 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:41491 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXxyw-0008Pt-WC for guix-devel@gnu.org; Wed, 19 Jul 2017 19:02:15 -0400 In-Reply-To: <20170421174106.GC3370@jasmine> Content-Language: en-US List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , Eric Bavier Cc: guix-devel@gnu.org Hi Eric, On 22/04/17 03:41, Leo Famulari wrote: > On Thu, Apr 20, 2017 at 11:20:23PM -0500, Eric Bavier wrote: > >> -----------BEGIN test-suite.log---------------- >> FAIL: tests/patches >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> test-name: distributed patches are used >> location: /home/bavier/projects/guix/tests/patches.scm:50 >> source: >> + (test-equal >> + "distributed patches are used" >> + '() >> + (lset-difference >> + string=3D? >> + distributed-patches >> + used-patches)) >> expected-value: () >> actual-value: ("/home/bavier/projects/guix/gnu/packages/patches/ath9k-= htc-firmware-binutils.patch" "/home/bavier/projects/guix/gnu/packages/pat= ches/ath9k-htc-firmware-gcc.patch" "/home/bavier/projects/guix/gnu/packag= es/patches/coreutils-cut-huge-range-test.patch" "/home/bavier/projects/gu= ix/gnu/packages/patches/gawk-shell.patch" "/home/bavier/projects/guix/gnu= /packages/patches/gcc-libiberty-printf-decl.patch" "/home/bavier/projects= /guix/gnu/packages/patches/gcc-4.9.3-mingw-gthr-default.patch" "/home/bav= ier/projects/guix/gnu/packages/patches/gcj-arm-mode.patch" "/home/bavier/= projects/guix/gnu/packages/patches/glibc-bootstrap-system.patch" "/home/b= avier/projects/guix/gnu/packages/patches/grub-CVE-2015-8370.patch" "/home= /bavier/projects/guix/gnu/packages/patches/grub-gets-undeclared.patch" "/= home/bavier/projects/guix/gnu/packages/patches/grub-freetype.patch" "/hom= e/bavier/projects/guix/gnu/packages/patches/guile-arm-fixes.patch" "/home= /bavier/projects/guix/gnu/packages/patches/icu4c-CVE-2017-7867-CVE-2017-7= 868.patch" "/home/bavier/projects/guix/gnu/packages/patches/icu4c-reset-k= eyword-list-iterator.patch" "/home/bavier/projects/guix/gnu/packages/patc= hes/ldc-disable-tests.patch" "/home/bavier/projects/guix/gnu/packages/pat= ches/ldc-1.1.0-disable-dmd-tests.patch" "/home/bavier/projects/guix/gnu/p= ackages/patches/ldc-1.1.0-disable-phobos-tests.patch" "/home/bavier/proje= cts/guix/gnu/packages/patches/libgit2-use-after-free.patch" "/home/bavier= /projects/guix/gnu/packages/patches/libxslt-CVE-2016-4738.patch" "/home/b= avier/projects/guix/gnu/packages/patches/mplayer2-theora-fix.patch" "/hom= e/bavier/projects/guix/gnu/packages/patches/patchelf-rework-for-arm.patch= " "/home/bavier/projects/guix/gnu/packages/patches/pcre-CVE-2017-7186.pat= ch" "/home/bavier/projects/guix/gnu/packages/patches/perl-net-ssleay-disa= ble-ede-test.patch" "/home/bavier/projects/guix/gnu/packages/patches/read= line-7.0-mingw.patch" "/home/bavier/projects/guix/gnu/packages/patches/so= prano-find-clucene.patch" "/home/bavier/projects/guix/gnu/packages/patche= s/texlive-texmf-CVE-2016-10243.patch" "/home/bavier/projects/guix/gnu/pac= kages/patches/util-linux-CVE-2017-2616.patch" "/home/bavier/projects/guix= /gnu/packages/patches/xf86-video-ast-remove-mibstore.patch" "/home/bavier= /projects/guix/gnu/packages/patches/xf86-video-intel-compat-api.patch" "/= home/bavier/projects/guix/gnu/packages/patches/xf86-video-intel-glibc-2.2= 0.patch") > At least one of these is a false positive: > icu4c-CVE-2017-7867-CVE-2017-7868.patch >> test-name: used patches are distributed >> location: /home/bavier/projects/guix/tests/patches.scm:54 >> source: >> + (test-equal >> + "used patches are distributed" >> + '() >> + (lset-difference >> + string=3D? >> + used-patches >> + distributed-patches)) >> expected-value: () >> actual-value: ("/home/bavier/projects/guix/gnu/packages/patches/python= -pbr-fix-man-page-support.patch" "/home/bavier/projects/guix/gnu/packages= /patches/jacal-fix-texinfo.patch" "/home/bavier/projects/guix/gnu/package= s/patches/vsearch-unbundle-cityhash.patch" "/home/bavier/projects/guix/gn= u/packages/patches/hmmer-remove-cpu-specificity.patch") >> result: FAIL >> While the first of these tests might not be ready, this second one seems = to be - I was just burned by a mistake of my own that this test would=20 have picked up. I added all 4 reported patches in to the set of=20 distributed patches in ca8fb248d, but shall we add this second test in to= o? Thanks, ben.